Strange shader behavior since r3133

[Getafix]

Following to a_c's observation that the shader or light has
strange behavior in our last nightlies (noticed with griff coriolis),
I 've done some binary search in the revisions and after 6 test builds I found that
there is a difference in the shader behavior from r3132 to r3133.

Shader Guru's should take over from here. This is as far as I can help on that.

[another_commander]

Ahruman had already warned us in his commit of 3133 that removal of the tex0, tex1 etc. uniform bindings would break older shaders that made use of them. This is exactly what happened here. Putting back the following line above line 720 of current OOShaderMaterial.m fixes appearance of the Griff Coriolis again:

[self setUniform:[NSString stringWithFormat:@"tex%u", i] intValue:i];

It was immediately obvious what happened once you spotted the revision where things changed.

[Getafix]

It was immediately obvious what happened...

Obvious?!? Yeah, right... Have a look at my signature, man!

--- Getafix is logging out annoyed by that continuous static noise in his head ---