comm_log in save-file in 1.73.4

[Commander McLane]

It seems a bug was introduced when the comm_log in the save-file was cut down in length. Can it be that instead of the last so-and-so-many lines the first so-and-so-many lines are saved? What I notice is that the content of comm_log in my save-file hasn't changed at all for many saves. It seems I am continuing with the same old stuff.

[Eric Walch]

It seems a bug was introduced when the comm_log in the save-file was cut down in length.

I think the cut down is okay but the reading in of the old data has a bug. Half a year ago I already tried to fix this. Part of the code has always been wrong as with multiple line messages, often only the first line is stored. This already was wrong in save files from 2005, but the player never saw the old log.

Shortly after this new feature was added I tried to fix it. I managed to change things with the multiple lines but other things got worse so I abandoned this work. I'll try again now. It was still on my to-do list. Maybe I understand this part of the code now better.

EDIT:
I think I fixed it now. The comm_log on screen is a different commlog than the one that was written to disk. Not all messages were written to both logs. When you delete all comm_log entries from a saved file, fly a bit till you get a message and save than, you'll still see no entry in the saved log while there is one on screen.

So it was not keeping the wrong lines but never adding new stuff to the lines it loaded from the saved file. I think I fixed it now. At least I see my messages in the saved file and it now really returns with the last messages after loading a game.

[Eric Walch]

Yes, I now have in my save file:

Code: Select all

Ident system locked onto Imperial Courier (modified): Commander McLane.
Imperial Courier (modified): Commander McLane: 
I didn't think that was possible!!!
Ident system locked onto Wreckage.
Weapon system overheated.

That ship was challenging me. It asked for it

[Commander McLane]

Yes, I now have in my save file:

Code: Select all

Ident system locked onto Imperial Courier (modified): Commander McLane.
Imperial Courier (modified): Commander McLane: 
I didn't think that was possible!!!
Ident system locked onto Wreckage.
Weapon system overheated.

That ship was challenging me. It asked for it

I'll remember to do the same to you next time, sir.