Fuel Collector Release 0.06

[Frame]

new version

0.03

http://wiki.alioth.net/images/c/c1/Fuel ... .03oxp.zip

fixed a major bug i introduced with the planet/moon naming

[Commander McLane]

Hi, Frame,

stumbled accross this in my logfile:

[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired

Think it is related to fighting with a buch of pirates and letting them eventually bite the dust. Thought you should know.

[Frame]

Hi, Frame,

stumbled accross this in my logfile:

[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired
[Fuel Collector]: WARNING!!! this.delayedmessage: Timer start before other is expired

Think it is related to fighting with a buch of pirates and letting them eventually bite the dust. Thought you should know.

oh yeah, that, i was worried that starting another timer with the same name would cause some sort of error.. so i threw in that catch... gotta rem out the log for that...

player will only get the notice of how much fuel he got for some moments after the first ship he destroyes... and for that very ship... but just thought of a way to add the fuel gatherd to a single value, and make to fuel notice show the combined fuel scooped..

thanks for the report...

Thanks...

[FSOneblin]

Can I find an updated version for 1.72? I'm getting some odd messages when collecting fuel after blowing up ships. (like Fuel: 9.1212323454).

FSOneblin

[Frame]

Can I find an updated version for 1.72? I'm getting some odd messages when collecting fuel after blowing up ships. (like Fuel: 9.1212323454).

FSOneblin

hmm nope... ..

Seems the 7 ly restriction in regard to how much fuel the player can carry has been lifted... gotta test that, will edit this in a moment...

Edit nope, the restriction still apply...

This was overdue for an update anyway...

Edit 2:

Seems you are blowing up something with a large amount of spawned fuel, like a fuel tanker... your fuel scoop will scoop between 1.5% and roughly 30 % of the victims fuel reserve...

At max if the victim is carrying 7 LY of fuel, You can be awarded about 2.1 ly of fuel.. pr kill...






working on it..

[Lestradae]

Hey Frame, good to see you back

[Frame]

Hey Frame, good to see you back

Thanks..

Got Version 0.04 down, a little change... planet vicinity does not affect usage in Oolite 1.72...

But still works as usual in 1.71 and 1.71.2

this change is due to a current bug in Oolite... It would be to costly to check for the vicinity to all planets in 1.72, where as 1.71.2 does this for you, and issues you a nice script trigger...

If everything checks out after my next run, i´ll upload 0.04 tommorow..

[Frame]

forgot: of course one of my first spawns by pure chance with the role pirate... after starting to test the fuel collector was my super "baby".. It slaughterd me...

its part of the OXP i plan to release in a years time....
here is some pics of it, in game... No shaders, and allready its pretty , but they dont reveal to much yet... since it is of the "wth is that type"

[Thargoid]

I seem to be getting an error now since I upgraded to the new version, using WinXP and v1.72:

Code: Select all

Warning (strict mode): reference to undefined property this.pllist
    Active script: "Fuel Collector" 0.1
    frame_fuel_collector.js, line 100:
    		this.pllist[pcounter] = system.planets[pcounter].distanceTo(system.sun)

Exception: TypeError: system.planets[pcounter].distanceTo is not a function
    Active script: "Fuel Collector" 0.1
    frame_fuel_collector.js, line 100:
    		this.pllist[pcounter] = system.planets[pcounter].distanceTo(system.sun)

Anyone else getting this?

[JensAyton]

I seem to be getting an error now since I upgraded to the new version, using WinXP and v1.72:

Code: Select all

Warning (strict mode): reference to undefined property this.pllist

Looks like a wee bit of a typo to me.

Code: Select all

Exception: TypeError: system.planets[pcounter].distanceTo is not a function
    Active script: "Fuel Collector" 0.1
    frame_fuel_collector.js, line 100:
    		this.pllist[pcounter] = system.planets[pcounter].distanceTo(system.sun)

This is a logic error: while functions that take a vector can be given an entity instead as a convenience, you can’t call vector methods on an entity directly. In other words, that should be:

Code: Select all

system.planets[pcounter].position.distanceTo(system.sun)

[Commander McLane]

I seem to be getting an error now since I upgraded to the new version, using WinXP and v1.72:

Code: Select all

Warning (strict mode): reference to undefined property this.pllist

Looks like a wee bit of a typo to me.

No, it isn't. 'pllist' stands for 'planet list'. I think the error is solely caused by the problem you explained.

[JensAyton]

No, it isn't. 'pllist' stands for 'planet list'. I think the error is solely caused by the problem you explained.

Well, it isn’t. :-) Regardless of whether it’s correctly spelled, the first error happens because this.pllist has not been created – as it’s an array, it should be initialized with this.pliist = []; before any use.

[Commander McLane]

No, it isn't. 'pllist' stands for 'planet list'. I think the error is solely caused by the problem you explained.

Well, it isn’t. Regardless of whether it’s correctly spelled, the first error happens because this.pllist has not been created – as it’s an array, it should be initialized with this.pliist = []; before any use.

I stand corrected.

That should teach me to throw around half-thought, snappy comments.

It won't. (I know myself.)

[Frame]

luckly version 0.4

features

Code: Select all

this.planetlist = new Array();
this.moonlist = new Array();

I can´t even remember the old code... anymore... but not that it matters

Gonna do a final check this evening.... and if everything
works out i´ll upload the version 0.4

[Frame]

I seem to be getting an error now since I upgraded to the new version, using WinXP and v1.72:

Code: Select all

Warning (strict mode): reference to undefined property this.pllist
    Active script: "Fuel Collector" 0.1
    frame_fuel_collector.js, line 100:
    		this.pllist[pcounter] = system.planets[pcounter].distanceTo(system.sun)

Exception: TypeError: system.planets[pcounter].distanceTo is not a function
    Active script: "Fuel Collector" 0.1
    frame_fuel_collector.js, line 100:
    		this.pllist[pcounter] = system.planets[pcounter].distanceTo(system.sun)

Anyone else getting this?

Btw why are you using Version 0.1, when 0.3 is released ?, i know i misspelled it 0.03, but i can tell its an old version you are using from

Code: Select all

    Active script: "Fuel Collector" 0.1