Page 1 of 1
PR to split GNUmakefile and add Clang support
Posted: Fri Jul 25, 2025 5:05 am
by mcarans
I've made a PR to add the Clang flag if compiler is Clang and split GNUmakefile into 3 files. It's a simple change that puts common flags and common files in flags.make and files.make and includes them in GNUmakefile. Anything OS specific is in GNUmakefile. I've also fixed the HOST_ARCH variable which was not set correctly (see
viewtopic.php?t=21896).
I have tested with Clang on Linux and a standard gcc build on Windows using latest nightly development environment.
Please let me know what you think.
https://github.com/OoliteProject/oolite/pull/521
Re: PR to split GNUmakefile and add Clang support
Posted: Fri Jul 25, 2025 5:15 am
by another_commander
I wanted to give this a test drive but was distracted with the HDR multi monitor stuff so it fell a bit behind. I will try to do it as soon as I get a chance. Provided that it does not change any of the existing functionality and Windows installers can still be built, I would be OK with it. Just need to find a chance to test properly.
Re: PR to split GNUmakefile and add Clang support
Posted: Sat Jul 26, 2025 3:41 am
by mcarans
another_commander wrote: ↑Fri Jul 25, 2025 5:15 am
I wanted to give this a test drive but was distracted with the HDR multi monitor stuff so it fell a bit behind. I will try to do it as soon as I get a chance. Provided that it does not change any of the existing functionality and Windows installers can still be built, I would be OK with it. Just need to find a chance to test properly.
Great. Thanks for improving Oolite over the years.
Is anyone running Oolite 32 bit these days? If not, a great simplification to the build would be to drop 32 bit support thus removing the need for 32 and 64 bit versions of files and the corresponding usage of one or other in the makefiles by way of HOST_ARCH.
Re: PR to split GNUmakefile and add Clang support
Posted: Tue Jul 29, 2025 5:30 am
by mcarans
another_commander wrote: ↑Fri Jul 25, 2025 5:15 am
I wanted to give this a test drive but was distracted with the HDR multi monitor stuff so it fell a bit behind. I will try to do it as soon as I get a chance. Provided that it does not change any of the existing functionality and Windows installers can still be built, I would be OK with it. Just need to find a chance to test properly.
I have removed 32 bit stuff in Makefile and GNUmakefile based on feedback from you and others here:
viewtopic.php?t=21910. I tested building package, installing it and running on Linux and Windows. Both worked fine.
https://github.com/OoliteProject/oolite/pull/521