Page 1 of 1

Deprecation Warnings about OXPs from Oolite 1.90

Posted: Sat Jun 19, 2021 9:02 pm
by hiran
It seems some OXPs produce deprecation warnings - I am not sure whether the OXP developers or possible maintainers are aware.
This is part of the logfile I get when loading a savegame:

Code: Select all

22:58:19.393 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.TAP.oxz/Config/script.js does not "use strict";
22:58:19.400 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.CommandersLog.oxz/Config/script.js does not "use strict";
22:58:19.404 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.TrafficControl.oxz/Config/script.js does not "use strict";
22:58:19.417 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Svengali.Pagroove.BGSSoundset.oxz/Config/script.js does not "use strict";
22:58:19.419 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.LaveAcademy.oxz/Scripts/laveAcademy_systemScript.js does not "use s
trict";
22:58:19.421 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.ByronArn.AutoRefuel.oxz/Config/script.js does not "use strict";
22:58:19.453 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.RingRacer.oxz/Scripts/ringRacer_systemScript.js does not "use stric
t";
22:58:19.459 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.extracts-tre-clan.oxz/Scripts/efttcaoil.js does not "use strict";
22:58:19.477 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.combat-simulator.oxz/Scripts/combatsimulator.js does not "use strict";
22:58:19.488 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.Thargoid.WelcomeMat.oxz/Config/script.js does not "use strict";
22:58:19.492 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.ships-library.oxz/Scripts/ingame-manual.js does not "use strict";
22:58:19.493 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.captsolo.solos-good-fortune.oxz/Scripts/captsolo.js does not "use strict";
22:58:19.503 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.systemfeatures.sunspots.oxz/Scripts/systemfeatures-sunspots.js does not "use strict";
22:58:19.504 [oxp-standards.deprecated]: Script /home/hiran/GNUstep/Library/ApplicationSupport/Oolite/ManagedAddOns/oolite.oxp.cim.camera-drones.oxz/Scripts/camera_drones.js does not "use strict";
I'm not sure whether just a line 'use strict' is missing or even more needs to be migrated.

Another set of warnings looks like this:

Code: Select all

23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M4
23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_COLORS
23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M3
23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_DTADAM
23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_DTADER
23:03:46.965 [oxp-standards.deprecated]: TL99 is deprecated for EQ_DTAWEA
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M0
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_CABAL_COMMON_SPECIALMARKETS
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M2
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_W0
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_CCL_OXPS_MINE
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M5
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_SAFETY_MINE
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_CABAL_COMMON_COMM
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_OXPCONFIG_M1
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_HYPER_RADIO_PIRATE
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_FIREWORKS_MISSILE
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_FIREWORKS_MINE
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_HYPER_RADIO_ADD
23:03:46.966 [oxp-standards.deprecated]: TL99 is deprecated for EQ_BEACON_DEVICE
And again I am left clueless as of what is missing or what is expected from an OXP developer...

Re: Deprecation Warnings about OXPs from Oolite 1.90

Posted: Sun Jun 20, 2021 5:42 am
by phkb
hiran wrote: Sat Jun 19, 2021 9:02 pm
I'm not sure whether just a line 'use strict' is missing or even more needs to be migrated.
In 99% of cases, that will be all that's required.
hiran wrote: Sat Jun 19, 2021 9:02 pm
And again I am left clueless as of what is missing or what is expected from an OXP developer...
In this case, for the TL99 issue, it's a slightly more complex fix, involving adding a condition script to the equipment item that performs the same function as whatever other restriction is in place.

Functionally, though, the OXP's producing these warnings will still function as is.

Re: Deprecation Warnings about OXPs from Oolite 1.90

Posted: Sun Jun 20, 2021 1:21 pm
by hiran
phkb wrote: Sun Jun 20, 2021 5:42 am
Functionally, though, the OXP's producing these warnings will still function as is.
I guess that is why it is warnings.
But I doubt the OXP authors get notified. After some more Oolite releases, when the depreciation gets strong enough these warnings turn into errors we may have a problem that requires a lot of work.

Thus it might be good to create visibility - but I do not yet know how.