Oolite Bulletins

For information and discussion about Oolite.
https://bb.oolite.space/

Markt, zusätzliche Verkaufswarenanzeigen

https://bb.oolite.space/viewtopic.php?t=20685

Page 1 of 2

Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 4:33 pm
by kleiner77
Hello,

I hope that I can express myself well over the translator because my English is not good.

But to my question:
I would like to display additional goods on the market screen, on the main screen (Moonshine, Heilige artifacts),
do not scroll down further with (arrow), since then two were missing at the top.

can one between the goods and continue (arrow), sort the goods and load space empty insert the blank that the two new goods land on the main page ???

because there is still space between platinum and further (arrow key) then displays my two new goods instead of being displayed to me by further.

I hope I could describe my request and someone can help me.

Thanks in advance .


addition: use the xenon ui ambiente and the DangerousHUD.GreenVariant.

but thank you very much

original

Platinum
Gem stones
Alien items
Next: page (or something like that)
Filters: all good sort: default
cash: 100.0 Load 0 of 20 T

My picture what I want:

platinum
Gem Stones
Alien items
and then next page
Filter: all good
Cash: ....
insert further down by code or something like that

plantinum
gem stones
alien items
Holy artifacts,
and then next, filter and cash.

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 5:34 pm
by Milo
On the market screen if you press the question mark key (?) it will cycle between several display modes. For example, "all", "all carried" (only show commodities that your ship is carrying), "all in stock" (only show commodities that the station has at least 1 to sell), etc. Does this help?

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 5:45 pm
by kleiner77
No, unfortunately not, because it still does not display all goods at the same time .....

Would like to have everything displayed, or just two more goods on the screen

addition: use the xenon ui ambiente and the DangerousHUD.GreenVariant.

but thank you very much

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 6:04 pm
by Milo
Adding two rows to the display can be done.

If you use Windows, you can download a modified version of oolite.exe from here to see the effect (put it in your oolite.app folder, make a backup of the current oolite.exe). This modified oolite.exe is based on the nightly build with other personal edits so I don't recommend playing with it unless you have the rest of the nightly build package and take some other modified files from me. The other modified Resources files can be downloaded from here (first install the latest nightly build then overwrite with my modified files).

Image

What I changed:

Code: Select all

diff --git a/src/Core/Entities/PlayerEntity.h b/src/Core/Entities/PlayerEntity.h
index d184d93c..1d50febb 100644
--- a/src/Core/Entities/PlayerEntity.h
+++ b/src/Core/Entities/PlayerEntity.h
@@ -145,8 +145,8 @@ enum
 	GUI_ROW_MARKET_START				= 2,
 	GUI_ROW_MARKET_SCROLLUP				= 4,
 	GUI_ROW_MARKET_SCROLLDOWN			= 16,
-	GUI_ROW_MARKET_LAST					= 18,
-	GUI_ROW_MARKET_END					= 19,
+	GUI_ROW_MARKET_LAST					= 20,
+	GUI_ROW_MARKET_END					= 21,
 	GUI_ROW_MARKET_CASH					= 20,
 	GUI_ROW_INTERFACES_HEADING			= 1,
 	GUI_ROW_INTERFACES_START			= 3,
What I changed (revised per phkb's comments below):

Code: Select all

diff --git a/src/Core/Entities/PlayerEntity.h b/src/Core/Entities/PlayerEntity.h
index 37e157a4..6172580e 100644
--- a/src/Core/Entities/PlayerEntity.h
+++ b/src/Core/Entities/PlayerEntity.h
@@ -141,13 +141,13 @@ enum
 	GUI_MAX_ROWS_EQUIPMENT				= 12,
 	GUI_ROW_EQUIPMENT_DETAIL			= GUI_ROW_EQUIPMENT_START + GUI_MAX_ROWS_EQUIPMENT + 1,
 	GUI_ROW_EQUIPMENT_CASH				= 1,
-	GUI_ROW_MARKET_KEY					= 1,
-	GUI_ROW_MARKET_START				= 2,
+	GUI_ROW_MARKET_KEY					= 0,
+	GUI_ROW_MARKET_START				= 1,
 	GUI_ROW_MARKET_SCROLLUP				= 4,
 	GUI_ROW_MARKET_SCROLLDOWN			= 16,
-	GUI_ROW_MARKET_LAST					= 18,
-	GUI_ROW_MARKET_END					= 19,
-	GUI_ROW_MARKET_CASH					= 20,
+	GUI_ROW_MARKET_LAST					= 19,
+	GUI_ROW_MARKET_END					= 20,
+	GUI_ROW_MARKET_CASH					= 21,
 	GUI_ROW_INTERFACES_HEADING			= 1,
 	GUI_ROW_INTERFACES_START			= 3,
 	GUI_MAX_ROWS_INTERFACES				= 12,
Obligatory legal note: This distribution of a derivative work is licensed under GPL v2 and/or CC BY-NC-SA 3.0 with attributions (Giles C Williams, Jens Ayton and contributors) and other terms as described in the OoliteReadMe.pdf included with Oolite.

Full list of changes compared to the nightly build:

Code: Select all

1. use shipdata key instead of name for ship.noPrimaryRole log message
2. disable "wait for station rotation alignment before assigning ships a dock"
3. sanity check for non-zero break pattern counter in-flight
4. double max entities limit (2048 -> 4096)
5. allow abandonShip from shipDied worldscript event
6. torus speed factor increased
7. display station blip instead of planet blip when basic compass changes target to station inside planetary or station aegis
8. recognize SHIFT+fast-activation-key to prime instead of activating
9. add new fast activation keys [ and ]
10. ctrl+fast activation key = mode, instead of prime
11. add two rows to the market screen

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 6:46 pm
by kleiner77
Thank you in advance, that sounds the same
what I wanted :-), will try it out tomorrow and get in touch

but I'm really enthusiastic about the answer

Thanks alot :-)

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 7:02 pm
by Milo
I'm interested to see how it will look now in a market that has extra commodities. I added a screenshot meanwhile.

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 7:39 pm
by kleiner77
yes exactly as described in the picture I would like to, but my pc does not allow the new oolite.exe to be started, unknown publisher ..... and that does not burden me ...

can I add this myself with the lines in my exe?
I think it has to be in the exe but unfortunately I'm on loan ... or where should the code be?
or what programs do I need ???

sorry for all the questions, but am anyway for the things and help
very enthusiastic, and that you took your time :-) really great ........

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Tue Jul 21, 2020 7:59 pm
by Milo
another_commander has made the process very simple for us on Windows. You can find instructions here: http://wiki.alioth.net/index.php/Develo ... On_Windows

But if your computer will not allow you to run programs you downloaded, I'm afraid you might run into the same problem when you try to run some of the tools to build the game yourself.

For only the market rows change, it would be easy for you to edit the two lines in the src/Core/Entities/PlayerEntity.h file.

So it just depends if you can run the tools or not.

Is it possible for you to bypass the "unknown publisher" warning? Usually there is an option to say "I know it is safe, open it anyway."

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 4:09 am
by phkb
I'm not sure the code tweak you made will work in all situations. The original lines in the PlayerEntity.h file are:

Code: Select all

	GUI_ROW_MARKET_LAST					= 18,
	GUI_ROW_MARKET_END					= 19,
 	GUI_ROW_MARKET_CASH					= 20,
There is a progression here that is lost if you change it to:

Code: Select all

	GUI_ROW_MARKET_LAST					= 20,
	GUI_ROW_MARKET_END					= 21,
 	GUI_ROW_MARKET_CASH					= 20,
The "CASH" line is going to overlap something, sometime.

I think if you're after 2 additional lines, you would need to add one to the top, and one to the bottom, like this:

Code: Select all

	GUI_ROW_MARKET_KEY					= 0,
	GUI_ROW_MARKET_START				= 1,
	...
	GUI_ROW_MARKET_LAST					= 19,
	GUI_ROW_MARKET_END					= 20,
	GUI_ROW_MARKET_CASH					= 21,

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 8:16 am
by kleiner77
Thank you for all the effort of you, really great, will try it out. Which program can I use to edit the entries? To make the new modifications?

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 9:00 am
by Cody
kleiner77 wrote: ↑Wed Jul 22, 2020 8:16 am
Which program can I use to edit the entries? To make the new modifications?
Notepad++ works for many of us.

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 11:09 am
by Milo
Here is how it looks with the modifications suggested by phkb above:

Image

Comparing to my previous version, this does what we want and shows the Alien Items row that was hidden before. Market Observer's added columns work correctly too, but the legends (labels at the top of the extra columns) need to be repositioned. Inside the market_observer.oxz (which can be opened as a zip file) there is a file Config\mo_market_hud.plist, and in the legends section, the first four entries have y = 184 that needs to be changed to y = 200. (The line numbers that need to be changed are 113, 120, 127 and 134.)

The final result:

Image

I updated my earlier post, replacing the link for the modified oolite.exe with a corrected version, and added the code diff based on phkb's suggestion.

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 11:17 am
by kleiner77
Many thanks to everyone, you really helped me a lot. You since pointed! :) :) :)

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 11:52 am
by kleiner77
Last help please again.... how do I get to the src/Core/Entities/PlayerEntity.h folder. Don't understand where I find him.... When I unpack oolite it does not exist. Many files and 3 folders but not this. And if I oolite with note+++ or other data of it that I see then, there are only funny font characters.... Sorry i'm really a leie. How do I get to the folders? Don't get to see it. Last help please, can someone describe to me only once in detail how I get there. Thank you

Re: Markt, zusätzliche Verkaufswarenanzeigen

Posted: Wed Jul 22, 2020 11:58 am
by Milo
You need to follow the instructions from the link I shared earlier: http://wiki.alioth.net/index.php/Develo ... On_Windows

One of the steps is to download ("check out") a copy of the source code using the "git" command. The PlayerEntity.h file (not folder) is in the source code, which needs to be compiled to produce a new oolite.exe after you make changes.

Incidentally, I tested with an extra commodity (I duplicated Witchfire Whiskey) and the Back and More options work fine:

Image

Image
All times are UTC
Page 1 of 2

Powered by phpBB® Forum Software © phpBB Limited