Test Win64 executable - custom laser sounds

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Test Win64 executable - custom laser sounds

Post by phkb »

I've got a test build demonstrating a PR which adds the ability to have custom laser sounds for each laser type. The goal here is to make it possible to customise the sounds each laser has: the sound it makes when fired, the sound it makes when it hits a target, and the sound it makes when that laser type hits your ship. The PR also allows the launch/impact sounds of missiles to be changed, so a standard missile can sound different to an ECM-hardened missile.

A zip file with a pre-built oolite.exe inside can be found here: oolite64bit.zip. It's just Win64 at the moment. To use it, you need the latest x64 nightly for Windows installed (it can sit right next to official 1.88 without interfering with it) and you need to just unzip the file linked,and drop the exe inside the trunk's oolite.app folder. This is my first time doing this, so let me know if I've botched the build process on the exe.

You can download a sample OXP that demnostrates the effects here: LaserMissileSoundVariation.oxz. This OXP isn't intended to be part of the official release - it's just for testing purposes.

Details about the PR can be found here, including the changes required to make your own OXP using the features: https://github.com/OoliteProject/oolite/pull/342.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 16081
Joined: Sat Jul 04, 2009 9:31 pm
Location: The Lizard's Claw
Contact:

Re: Test Win64 executable - custom laser sounds

Post by Cody »

phkb wrote: Mon Aug 26, 2019 5:05 am
This is my first time doing this, so let me know if I've botched the build process on the exe.
The .exe seems to work okay, but I can't answer for the rest of it.
I would advise stilts for the quagmires, and camels for the snowy hills
And any survivors, their debts I will certainly pay. There's always a way!
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Test Win64 executable - custom laser sounds

Post by phkb »

Cody wrote: Mon Aug 26, 2019 3:14 pm
The .exe seems to work okay
Well, that's good news! Step one, tick.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Test Win64 executable - custom laser sounds

Post by phkb »

*Bump*

I've just updated the prebuilt Oolite (link in first post) to include all the latest patches. I was curious as to whether anyone has had the opportunity to try this out at all.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Test Win64 executable - custom laser sounds

Post by phkb »

*double bump*

Once again, I've updated the prebuilt Oolite (link in first post) to include all the latest patches. I'd really be interested in any feedback on this patch.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6680
Joined: Wed Feb 28, 2007 7:54 am

Re: Test Win64 executable - custom laser sounds

Post by another_commander »

Giving this a check soon. Stand by.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6680
Joined: Wed Feb 28, 2007 7:54 am

Re: Test Win64 executable - custom laser sounds

Post by another_commander »

Works well I think. What is the licensing status of the test sounds in your OXP? Can we include those in the core game?

I think the PR on github is good to be approved in any case.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Test Win64 executable - custom laser sounds

Post by phkb »

another_commander wrote: Tue Aug 18, 2020 5:21 am
What is the licensing status of the test sounds in your OXP? Can we include those in the core game?
I think it's OK, but I'll check.
User avatar
phkb
Impressively Grand Sub-Admiral
Impressively Grand Sub-Admiral
Posts: 4830
Joined: Tue Jan 21, 2014 10:37 pm
Location: Writing more OXPs, because the world needs more OXPs.

Re: Test Win64 executable - custom laser sounds

Post by phkb »

Licences look OK, I think. I got the sounds from freesound.org:

Military laser sound from https://freesound.org/people/notyermom/sounds/434834/ License: https://creativecommons.org/publicdomain/zero/1.0/
Mining laser sound from https://freesound.org/people/bubaproduc ... ds/151022/ License: https://creativecommons.org/licenses/by/3.0/
Beam laser sound from https://freesound.org/people/jobro/sounds/35677/ License: https://creativecommons.org/licenses/by/3.0/

I think I just made a muted version of each for the "hit" sound. For the ECM missile launch sound I used the default launch sound and gave it some variation.

I'll do a final check and add them to the source later today.
User avatar
cbr
---- E L I T E ----
---- E L I T E ----
Posts: 1422
Joined: Thu Aug 27, 2015 4:24 pm

Re: Test Win64 executable - custom laser sounds

Post by cbr »

Is there any information how to add your custom soundset?
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 6680
Joined: Wed Feb 28, 2007 7:54 am

Re: Test Win64 executable - custom laser sounds

Post by another_commander »

This feature is already incorporated in 1.90. phkb's soundset is included in the game's core data files and the relevant configuration files are updated to use the new sounds.
Post Reply