Page 1 of 3
hey comanders i found whats been causeing some older oxp bug
Posted: Fri Oct 30, 2015 9:48 pm
by ashtiboy
hey comanders i found what has been causeing some older oxp from working at all thats been efecting some poplear oxz ship packs! this will be helpful for the ootlie comutity to restore the funchons of alot of poplear addons. ~ hope this helps ~ ashtiboy the mac oolite fan and player
*i have edited and gotin rid of all misinfomation related to this topic due to finding out that i can indrictly find wich ship that does not work by finding ship data load errors indrectly from how the shipyard plist and ship data entrys efect echother*
Re: hey comanders i found whats been causeing some older oxp
Posted: Fri Oct 30, 2015 10:20 pm
by Amah
Itsi, itsi, itsi! !We eat your yak disco!
ok, seriously. this seems to be a some kind of bug report. As far I understood there's bug in shipdata.plist, affects only Mac OS, the curly bracket is not parsed correctly with Oolite v1.82? Can anybody with a Mac confirm and maybe explain what's the deal.I have no problems here on Linux.
Re: hey comanders i found whats been causeing some older oxp
Posted: Fri Oct 30, 2015 11:02 pm
by phkb
Rather than the { at the beginning of the file, I suspect it's the lack of a ; on the last element. Mac's seem to be sensitive to this - each element in the list needs a ; to terminate it, otherwise it doesn't parse. I don't have all those OXP's, so someone else will need to check, but I've certainly run into this issue before (see
this post, or
here as well).
Re: hey comanders i found whats been causeing some older oxp
Posted: Fri Oct 30, 2015 11:11 pm
by Smivs
Clippers and YellOo Cabs were updated a while ago to fix this - do you have the current version? The first curly should be there, but the problem lay further down the code - missing semi-colons in the Materials dictionary. The thread discussion is
here.
Something similar may be causing problems with the other OXPs as well.
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 12:45 am
by ashtiboy
ok i will check
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 1:19 am
by ashtiboy
i checked my logs it seams that my mac with mac os x 9 does in fact can't parse any plist file with a { on the very top of the plist file i compadred my logs from before i delited the { and after and it seams that mac os x 9 does not like haveing a { on line 1 at all
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 3:25 am
by phkb
I think the issue is not in the "{" on line 1, otherwise every single OXZ will fail because they each have a manifest.plist file that begins with a "{".
The error may be reporting as failing to parse the plist file at character position 1, but I think the error is misleading. The actual bug will be, as smivs said, somewhere in the body of the file. Look for entries that don't have a terminating ";" character.
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 3:42 am
by phkb
For instance, in the "Noshader Mimoriarty's Radical Logistics ships", in the shipdata.plist file, on line 916, it looks like this:
Code: Select all
illumination_map = { name = "noshaders_lira_sub_rud_lit.png"};
You can add a semicolon like this:
Code: Select all
illumination_map = { name = "noshaders_lira_sub_rud_lit.png";};
It's the same with line 1046, 1170 and 1231. Can you add semi-colons to each of these lines and try the OXZ again?
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 10:01 am
by Amah
Thanks for clearing up,smiv, phkb and ashtiboy...
I'm currently fixing the missing ";" in the materials of the RL ships... Will upload a first update soon. Please check again.
I'm not sure what's wrong with the missing core ships, yet... but I'll go through that file...
Is there a way for me to check with no Mac for other syntax parsing errors?
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 10:07 am
by Wildeblood
This preciousness of the Mac plist parser would be the one good argument in favour of writing plists in XML format instead of nextstep.
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 10:35 am
by Amah
I have to admit as someone who normally codes in C, the javascript style plist is friendlier to my eyes ... but then again, I'm going through the missing core ship shipdata.plist for the second time and I haven't found anything yet...
/e: hmmh... I seem to have found a culprit:
Code: Select all
"noshaders_missingcoreships_tharglet_organic" = {
like_ship = "oolite_template_tharglet";
model="noshaders_tharglet_organic.dat";
materials =
{
"noshaders_missingcoreships_tharglet_organic_diffuse.png" =
{
diffuse_map = "noshaders_missingcoreships_tharglet_organic_diffuse.png";
specular_color = (0.2, 0.3, 0.2 );
shininess = 25;
emission_map = { name = "noshaders_missingcoreships_tharglet_organic_diffuse.png"; extract_channel = "a"; };
emission_modulate_color = (0.80, 0.0, 0.0);
--> }
};
};
Ashtiboy, could you add a ";" behind the closing curly bracket of the materials section and report back if it works for you now.
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 2:44 pm
by ashtiboy
thanks for the help but i can't seam to go into the oxz files for some reason becuse my computer does not reconizse a oxz as a file with packaged files inside to add the ;
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 2:48 pm
by Cody
On Windows, you rename the .oxz to .zip then extract and tinker - don't know about Macs though. I think the in-game manager will extract stuff too.
Welcome aboard, btw!
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 2:54 pm
by ashtiboy
ok thanks now i'm going to try to fix adcks ffe ships by looking for missing ; to get some of these oxps back up and runing
Re: hey comanders i found whats been causeing some older oxp
Posted: Sat Oct 31, 2015 3:41 pm
by Amah
Has adding the ";" fixed the missingcoreships for you? If yes, I'll upload the fix in the ingame expansion managerfor all.