Smugglers - The Galactic Underworld & Black Markets

[phkb]

I've just uploaded version 0.7.5, which fixes a small bug in the blackmarket script, but more importantly for users of Oolite 1.83/4, it shows the correct illegal goods information on the F7 system info screen when using the new functions to move the information along the currently set course.

[phkb]

Version 0.7.6 has been released. In this version:

• Better handling of situation where another OXP removes the smuggling compartment.
• Fixed issue with contracts where a Javascript error could occur in rare circumstances.
• Fixed Javascript error with script attached to police sting ship.
• Improved sting ship compatibility with other worldScripts.
• Really (hopefully, maybe) fixed vector error in Blackmarket script.
• Changed "==" comparisons to "===" for performance improvements.

Links in the first post or via download manager.

Edit: Just found another bug, so thought I'd turn it around fast this time!
0.7.7

• Fixed issue with smuggling compartments of various sizes appearing on the equipment screen.

[phkb]

Sorry for the constant updates. I wasn't going to release another one so soon, but this issue was pretty important, essentially losing illegal goods information on the F8 screen, resulting in a situation where the F4 Illegal Goods notifications would say one thing, but the F8 screen would say another. Anyway, version 0.7.8 fixes the issue.

[Devium]

Had an incident where I docked at a station on an extra planet (it had best prices) while carrying a load of illegally imported computers. Expected to try to bribe but as I was carrying the escape pod of a criminal that screen popped up first then no galcop screen. It did give me fugitive status however.

[phkb]

Thanks for that, Devium - a scenario I hadn't considered before. I'll run some tests and let you know when I find the bug.

Edit: And fixed. Version 0.7.9 available from the download manager. I wasn't marking off escape pods against normal slaves when checking to see if the player has slaves before they dock.

[Devium]

Not sure if this belongs here or not. Had a misjump where my energy banks were slowly depleting though I didn't see any reason why. Was close enough to jump back to planet but game closed when I tried.

Code: Select all

0:50:27.281 [LogEvents]: Player started 15 seconds standard jump countdown
10:50:29.156 [LogEvents]: Player got message from Cobra Mark I 27843 : Everything looks clean at the moment.
10:50:42.288 [LogEvents]: Player will enter witchspace due to standard jump
10:50:42.292 [LogEvents]: Player compass targeted in mode COMPASS_MODE_BEACONS
10:50:42.293 [LogEvents]: Player exited from the vicinity of [Planet position: (2.11446e+006, 1.63349e+006, 337411) radius: 70000 m]
10:50:42.293 [LogEvents]: Player lost lock on G-Z1 Icosahedron Station 24735
10:50:42.352 [LogEvents]: Player will exit witchspace
10:50:42.673 [LogEvents]: Player alert condition changed from 2 to 1
10:50:44.945 [LogEvents]: Player exited from witchspace
10:50:46.179 [LogEvents]: Player new day 2084892
10:50:46.674 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:50:50.179 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:50:53.674 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:50:54.426 [LogEvents]: Player gui screen changed from GUI_SCREEN_MAIN to GUI_SCREEN_SHORT_RANGE_CHART
10:50:57.173 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:00.674 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:02.194 [LogEvents]: Player gui screen will change from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_SYSTEM_DATA
10:51:02.214 [LogEvents]: Player gui screen changed from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_SYSTEM_DATA
10:51:04.175 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:05.110 [LogEvents]: Player gui screen changed from GUI_SCREEN_SYSTEM_DATA to GUI_SCREEN_MAIN
10:51:05.123 [LogEvents]: Player VIEW_FORWARD
10:51:07.112 [LogEvents]: Player gui screen will change from GUI_SCREEN_MAIN to GUI_SCREEN_STATUS
10:51:07.134 [LogEvents]: Player gui screen changed from GUI_SCREEN_MAIN to GUI_SCREEN_STATUS
10:51:07.673 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:09.628 [LogEvents]: Player gui screen will change from GUI_SCREEN_STATUS to GUI_SCREEN_MANIFEST
10:51:09.651 [LogEvents]: Player gui screen changed from GUI_SCREEN_STATUS to GUI_SCREEN_MANIFEST
10:51:11.178 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:14.409 [LogEvents]: Player gui screen changed from GUI_SCREEN_MANIFEST to GUI_SCREEN_SHORT_RANGE_CHART
10:51:14.677 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:18.177 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:21.381 [LogEvents]: Player gui screen changed from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_LONG_RANGE_CHART
10:51:21.672 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:23.506 [LogEvents]: Player gui screen changed from GUI_SCREEN_LONG_RANGE_CHART to GUI_SCREEN_SHORT_RANGE_CHART
10:51:24.032 [LogEvents]: Player gui screen will change from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_SYSTEM_DATA
10:51:24.033 [LogEvents]: Player gui screen changed from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_SYSTEM_DATA
10:51:25.174 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:28.673 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:31.170 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (Smugglers_Illegal 0.7.9): TypeError: system.mainStation is null
10:51:31.170 [LogEvents]: Player gui screen will change from GUI_SCREEN_SYSTEM_DATA to GUI_SCREEN_MARKET
10:51:31.198 [LogEvents]: Player gui screen changed from GUI_SCREEN_SYSTEM_DATA to GUI_SCREEN_MARKET
10:51:32.172 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:35.676 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:35.752 [LogEvents]: Player gui screen will change from GUI_SCREEN_MARKET to GUI_SCREEN_MARKETINFO
10:51:35.755 [LogEvents]: Player gui screen changed from GUI_SCREEN_MARKET to GUI_SCREEN_MARKETINFO
10:51:37.959 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (Smugglers_Illegal 0.7.9): TypeError: system.mainStation is null
10:51:37.960 [LogEvents]: Player gui screen will change from GUI_SCREEN_MARKETINFO to GUI_SCREEN_MARKET
10:51:37.963 [LogEvents]: Player gui screen changed from GUI_SCREEN_MARKETINFO to GUI_SCREEN_MARKET
10:51:39.176 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:41.005 [LogEvents]: Player gui screen changed from GUI_SCREEN_MARKET to GUI_SCREEN_MAIN
10:51:41.007 [LogEvents]: Player VIEW_FORWARD
10:51:42.677 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:43.223 [LogEvents]: Player VIEW_AFT
10:51:44.024 [LogEvents]: Player VIEW_FORWARD
10:51:46.179 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:49.676 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:53.181 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:51:56.677 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:00.176 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:03.679 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:07.176 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:10.673 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:14.180 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:17.674 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:21.200 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:22.641 [LogEvents]: Player VIEW_AFT
10:52:24.276 [LogEvents]: Player VIEW_FORWARD
10:52:24.675 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:28.179 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:31.672 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:35.174 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:38.678 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:42.180 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:45.673 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:47.866 [LogEvents]: Player gui screen changed from GUI_SCREEN_MAIN to GUI_SCREEN_SHORT_RANGE_CHART
10:52:48.862 [LogEvents]: Player gui screen changed from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_LONG_RANGE_CHART
10:52:49.175 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:49.569 [LogEvents]: Player gui screen changed from GUI_SCREEN_LONG_RANGE_CHART to GUI_SCREEN_SHORT_RANGE_CHART
10:52:51.114 [LogEvents]: Player gui screen changed from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_MAIN
10:52:51.117 [LogEvents]: Player VIEW_FORWARD
10:52:52.680 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:55.795 [LogEvents]: Player gui screen changed from GUI_SCREEN_MAIN to GUI_SCREEN_SHORT_RANGE_CHART
10:52:56.181 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:59.674 [script.javaScript.exception.notFunction]: ***** JavaScript exception (IST_masterScript 5.31): TypeError: s.filteredEntities is not a function
10:52:59.692 [LogEvents]: Player gui screen will change from GUI_SCREEN_SHORT_RANGE_CHART to GUI_SCREEN_SYSTEM_DATA

IST = In System Trader? [edit] Went ahead and posted in In System Trader thread as well.

[phkb]

Version 0.8.0 should fix this bug. Never thought of accessing the commodity details page in Interstellar space! I'm usually too busy with a bug infestation!

[TheOldGamer]

Hi there - I have an issue I haven't seen reported here yet: My title screen tells me " 'Smugglers - the Galactic Underworld' conflicts with 'New Cargos' and so was not loaded".
I used the OXP manager to install them; the relative versions are 0.8.0 for Smugglers and 1.2.3 for New Cargos. I suppose it would be easy enough to delete 'New Cargos' but it'd be nice to be able to use both.

[phkb]

Hi there - I have an issue I haven't seen reported here yet: My title screen tells me " 'Smugglers - the Galactic Underworld' conflicts with 'New Cargos' and so was not loaded".

This is less of a bug and more of a case of restricting possible conflict scenarios. Smugglers and New Cargoes are two similar but different packs. New Cargoes is attempting to expand the range of cargoes in use in the game, so food can be more than just "food", but specialty food products, really valuable to some cultures, but worthless to others. In some cases products are considered illegal to import/export, and special permits are required to carry them. There are time-limited special deals to be had on some of these special commodities.

To achieve some of this, New Cargoes turns off the default import/export restriction mechanism so it can fully implement it's own process. Actually, it used to, up until version 1.80 of Oolite. I think New Cargoes might actually be subtly broken in version 1.82 of Oolite, because it uses a now unsupported method of turning off the pre-existing restrictions on slaves, narcotics and firearms. So there is a chance you could be penalised by officials for carrying illegal cargo even though you have a permit for them. (I might be wrong on this point, but that's my reading of how the code works.)

Smugglers tries to do a similar thing, but without playing with the existing cargo types. It's still just the same 17 commodities, bought and sold on the same F8 screen, but now any of them could be considered illegal to import into a station. Rather than implement its own process for determining what is legal or not, it tries to use the core system functions to turn on or off the legal state depending on the system. Like New Cargoes, you can also purchase permits to allow you to import restricted items.

It's at these similar points that compatibility breaks down. Having both packs installed could mean some very confusing times for the player. They could buy a New Cargoes permit for a particular commodity, but because New Cargoes is no longer in complete control over the legality state, you could find yourself in trouble. In the situation where New Cargoes and Smugglers have both declared a commodity is illegal you could end up being dinged twice. Then there would be two systems offering you import permits - which should you buy, and why? Then there would be pricing issues, where a commodity bought via New Cargoes, having been declared illegal on another planet by Smugglers, could mean the player would be far better off smuggling it into that system, even though New Cargoes wanted to make it clear this cargo was only of value at another destination.

It's certainly possible to run the two packs together. If you edit the "manifest.plist" file of Smugglers, and change the line that reads "conflicts_oxps" to "optional_oxps" you'll be able to get both loaded. If you do this, though, and you run into problems where your legal status changes unexpectedly, you're kind of on your own. I don't think cim (the author of New Cargoes) or I would relish the job of trying to untangle the strands of what took place in a combined OXP situation.

So, while I'm sorry I can't provide it, I have to say that for the time being Smugglers and New Cargoes will have to remain officially incompatible.

[TheOldGamer]

Understood - and thanks so much for such a detailed and complete explanation; it really helps my attempts to learn how to mod this game.

I think I see a major advantage of Oolite: if conflicting add-ons are encountered, it's easy enough to simply remove one and enjoy the other, then reverse the two and play the second mod all without restarting the game. Thanks!

[TheOldGamer]

AAARRRRGH!!!!

OK - I just spent a couple of real-life hours buying up cheap computers at some of the local outlying stations, and was finding some pretty good deals. Imagine - computers for 18c/unit? Sweet! I'm down here in the South-east cluster which seems desperate to get rid of their outdated junk. I filled up, Hypercargoed and filled up again, and now have a bellyful of obsolete motherboards. Straight on to the nearest poor agricultural world (Leritean) and what comes up on the Market Inquirer? Computers - selling for 288c! Woot! I'm so pleased I don't even bother to paste the inevitable Witchpoint pirates; I just power out because I can't wait to sell off.
The happy feeling lasts right up until I dock - when I'm informed that computers are illegal, my entire cargo gets confiscated, I get slapped with a major fine and wind up on Offender status to boot - which I have to pay through the bloody nose to clear!

Phkb, you are evil! You are evil! You are evil!

Just kidding, of course; that's exactly what Smugglers is designed to do but wow! Talk about a wake-up call that things just got a whole lot more complicated. Checking the info on your route ahead becomes seriously critical, to avoid situations like this!

Awesome OXB, it REALLY adds the need to plan, prepare and think about your trading routes.
Well, I have about 20 grand to have to build up again...

[tsoj]

Hi,
first i really like your oxp, it makes trading much more interesting.
I installed version 0.8.0 with the oolite extension manager (1.82 and 1.83 on Linux) and when i buy a smuggling compartent or use it the HUD disappears and did not appear again when i want to fly again.

[Norby]

the HUD disappears

[wiki]HUDSelector[/wiki] probably can restore your HUD, except if you accidentally pressed the "o" key in pause mode when you must pause and "o" again.

[tsoj]

Yes if i press 'o' it appears but it would be nicer if it does it on its own imao.

[phkb]

OK, I've got a fix for this, but given I've released about 6 updates for this OXP in the last week (which probably counts as spam!) I might hold off releasing it immediately, just in case some other issue comes up in the meantime. Thanks for letting me know!