Page 1 of 1
Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 1:12 pm
by phkb
There seems to be an issue with the player.ship.targetSystem (in 1.80) when I'm in G5 Divees. Now, Divees and Tezabi have the same galactic coordinates (37,130). When I'm in Tezabi, I can set my destination to Divees and everything works OK. My HUD displays the correct system, player.ship.targetSystem also picks up the correct system, and things like BroadcastComms MFD and Navigation MFD use it to do various things with.
But, if I'm in Divees, and I set my destination to Tezabi, things go a little funny. Navigation MFD thinks I don't have a destination set. BroadcastComms MFD (which uses player.ship.targetSystem) also thinks I don't have a target system set.
However, my HUD quite happily displays my destination as Tezabi, so at least one unit seems to know where I'm going!
Is this a bug with player.ship.targetSystem? Or have I done something silly elsewhere?
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 1:21 pm
by Cody
Divees and Tezabi - ah yes, I remember them well! They, and the other double systems, caused some trouble way back.
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 1:29 pm
by spara
phkb wrote:Is this a bug with player.ship.targetSystem? Or have I done something silly elsewhere?
Looks like it. Has been fixed in Oolite 1.81.
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 1:33 pm
by phkb
spara wrote:Has been fixed in Oolite 1.81.
Ah, right. Thanks spara!
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 5:14 pm
by cim
In 1.80 and earlier the internal representation of currentSystem and targetSystem (and a few other similar variables) is as a set of 'x,y' coordinates. There's then a layer of stuff built on top of that for distinguishing properly between zero-distance doubles, which sometimes even works.
In 1.81 the internal representation is the system ID number. There may still be some bugs around zero-distance doubles, so if you're testing that version please keep your eyes open for them.
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 7:09 pm
by Cody
cim wrote:In 1.81 [snip]There may still be some bugs around zero-distance doubles, so if you're testing that version please keep your eyes open for them.
I've not seen any problems - apart from F6 not showing distance/travel time between a
double, that is.
Re: Issue with targetSystem at Divees/Tezabi
Posted: Mon Feb 23, 2015 7:50 pm
by cim
Cody wrote:apart from F6 not showing distance/travel time between a double, that is.
Thanks - that bit is still using coordinates more than it needs to. I'll fix it up.
Re: Issue with targetSystem at Divees/Tezabi
Posted: Thu Feb 26, 2015 6:12 pm
by cim
Okay, this should be fixed in tonight's nightly so that the distance/time for a jump between a zero-distance pair shows correctly. A bug with selection introduced at some point during 1.81 is also fixed.
Please keep looking for others.