Trunk nightly

[Cody]

Not a bug as such, but I've not seen this before: no docking clearance message from the station.
If not for spara's Nav-MFD, I'd not have known clearance had been granted - strange one!

[Cody]

Code: Select all

14:40:35.869 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 16 is out of range 16 (in 'objectAtIndex:')
14:40:35.882 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 17 is out of range 16 (in 'objectAtIndex:')
14:40:35.895 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 18 is out of range 16 (in 'objectAtIndex:')
14:40:35.908 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 19 is out of range 16 (in 'objectAtIndex:')
14:40:35.922 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 20 is out of range 16 (in 'objectAtIndex:')
14:40:35.935 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 21 is out of range 16 (in 'objectAtIndex:')
14:40:35.948 [exception]: ***** Exception in pollFlightControls [next target]: NSRangeException : Index 22 is out of range 16 (in 'objectAtIndex:')

<scratches head>

[kanthoney]

Thanks - should be fixed tonight.

[Cody]

Cool - you don't realise quite how much you use something 'til you can't use it.

[Cody]

I just pulled into Ceerti Main, grabbed a 30k parcel contract, checked my manifest - and it wasn't there! Nor was it on F4 - gone, it was! I know (or suspect) that contracts have a shelf-life*, as I've seen them disappear from the list before - but to lose one after I've hit Accept (even had the Contract Accepted message) is a bit much.

*After experimenting, I don't believe this is connected to shelf-life (if such a thing actually exists) - they simply disappear.
Two of four contracts wouldn't register and disappeared - the other two were accepted fine. <scratches head>

[another_commander]

Is this reproducible? If yes, does it happen without OXPs?

[Cody]

Reproducible with that particular save, yes - message incoming!

[another_commander]

Looks like Cody and the RNG can't get along with each other.

The problem in that particular save was that the 30K parcel was from some guy named Erra Sole, but the manifest contained already a parcel contract randomly generated with the same sender name. Due to a specific check in the parcel validation functions, senders of the same name were excluded and the contract information was silently deleted.

Removing that specific check solves the problem and I think that it won't be an issue if every now and then senders with the same name come up. This does happen in real life too, so why not? I will remove the check for tonight's nightly and maybe you can test and see for yourselves if there are any other hidden side effects that I may have missed. It's just one line, should be easy to bring back in case of unforseen problems.

[Cody]

Looks like Cody and the RNG can't get along with each other.

Ain't that the truth! I had one of those 'hyperspace failed' events yesterday, and the randomly selected damaged item was the cloak!
So both disappeared contracts had sender-names already in my manifest, eh? Good fix, as this would happen.

[Norby]

Minor notice: the third page is unnecessary.

[Cody]

In F4 contracts, the system type icons seem to be missing from the contracts' details.

[another_commander]

Should be fixed for tonight's nightly. Please test and advise.

[Cody]

Should be fixed for tonight's nightly.

It is indeed - thanks.

[Cody]

Is there a problem with the nightly? The latest available is 1.85.0.6847-161017-05ec85b - there has been a commit since then, yes?

[another_commander]

Yes. The Penguin-Signal searchlight is switched on - stand by for super-hero arrival.