Moderators: another_commander, winston, Getafix
Code: Select all
if (scannerUpdated) return; // there's never the need to draw the scanner twice per frame!
Code: Select all
for (i = [dialArray count] - 1; i >= 0; i--)Code: Select all
for (int i = 0; i < [dialArray count]; i++)Code: Select all
- (void) drawDials
{
z1 = [[UNIVERSE gameView] display_z];
// reset drawScanner flag.
_scannerUpdated = NO;
_compassUpdated = NO;
// tight loop, we assume dialArray doesn't change in mid-draw.
NSInteger i;
const NSInteger dialArray_count = [dialArray count];
//for (i = [dialArray count] - 1; i >= 0; i--)
for (i = 0; i < dialArray_count; i++)
{
Good catch. Could you send us a pull request with that change, please.drumz wrote:Ok, on branch master I modified drawDials like so:
hud.plist so that the "drawScanner" entry is at the end of the dials section rather than the beginning, the bug reappears? (If it does, could you try to find out which of the other dials is interfering with it?)
If the "fix" does work, I suggest putting up the hud.plist on box.com (or similar) for others to download.drumz wrote:You should be able to simply reverse the order of the "dials" elements in hud.plist in 1.77 to "fix" the bug. I didn't test this yet.
The simplest solution, for those on 1.77, is to create your own OXP. Go to your AddOns directory, and create a new directoy, let's say ScannerFix.oxp. Inside that directory create a directory names Config. Inside that directory create a file named hud.plist, with the following contents:JazHaz wrote:If the "fix" does work, I suggest putting up the hud.plist on box.com (or similar) for others to download.drumz wrote:You should be able to simply reverse the order of the "dials" elements in hud.plist in 1.77 to "fix" the bug. I didn't test this yet.
Code: Select all
![[EliteWiki]](/images/elitewikismall.png){kind=small}
New Cargoes
{
dials = //these are drawn, in order, after the legends
(
{ // fps counter, x and y give the location, the size defines the character size
height = 18;
selector = "drawFPSInfoCounter:";
width = 18;
x = -300;
y = -20;
y_origin = 1;
},
{ // weapons systems offline text, x and y give the location, the size defines the character size
height = 8;
selector = "drawWeaponsOfflineText:";
width = 8;
x = -175;
y = 2;
y_origin = -1;
},
{ // ship's clock, x and y give the location, the size defines the character size
height = 12;
selector = "drawClock:";
width = 12;
x = -48;
y = 6;
y_origin = -1;
},
{ // status indicator light, x and y give the location, the size defines the icon size
height = 8;
selector = "drawStatusLight:";
width = 8;
x = -108;
y = 24;
y_origin = -1;
},
{ // missile display, x and y give the location, the x-spacing is given by spacing, the size defines the icon size
height = 12;
selector = "drawMissileDisplay:";
spacing = 16;
width = 12;
x = -228;
y = 16;
y_origin = -1;
},
{ // altitude bar
height = 8;
selector = "drawAltitudeBar:";
width = 80;
x = -200;
y = 31;
y_origin = -1;
},
{ // weapon temperature bar
height = 8;
selector = "drawWeaponTempBar:";
width = 80;
x = -200;
y = 41;
y_origin = -1;
},
{ // cabin temperature bar
height = 8;
selector = "drawCabinTempBar:";
width = 80;
x = -200;
y = 51;
y_origin = -1;
},
{ // fuel bar
height = 8;
selector = "drawFuelBar:";
width = 80;
x = -200;
y = 61;
y_origin = -1;
},
{ // just draws a surround 2 units around the selected size, you could also use drawGreenSurround:
height = 40;
selector = "drawYellowSurround:";
width = 80;
x = -200;
y = 46;
y_origin = -1;
},
{ // aft shield bar, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 8;
selector = "drawAftShieldBar:";
width = 80;
x = -200;
y = 78;
y_origin = -1;
},
{ // forward shield bar, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 8;
selector = "drawForwardShieldBar:";
width = 80;
x = -200;
y = 94;
y_origin = -1;
},
{ // energy gauge, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 48;
selector = "drawEnergyGauge:";
width = 80;
x = 200;
y = 35;
y_origin = -1;
labelled = yes;
},
//{ // yaw bar, can draw a surround 2 units out from the dial size specified
// // this is disabled by default, uncomment as required to enable
// draw_surround = yes;
// height = 8;
// selector = "drawYawBar:";
// width = 80;
// x = 200;
// y = -130;
//},
{ // pitch bar, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 6;
selector = "drawPitchBar:";
width = 80;
x = 200;
y = 70;
y_origin = -1;
},
{ // roll bar, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 6;
selector = "drawRollBar:";
width = 80;
x = 200;
y = 80;
y_origin = -1;
},
{ // speed bar, can draw a surround 2 units out from the dial size specified
draw_surround = yes;
height = 8;
selector = "drawSpeedBar:";
width = 80;
x = 200;
y = 95;
y_origin = -1;
},
{ // fuel scoop status
alpha = 0.75;
selector = "drawScoopStatus:";
x = -132;
y = 88;
y_origin = -1;
},
{ // station aegis
alpha = 1.0;
selector = "drawAegis:";
x = -132;
y = 24;
y_origin = -1;
},
//{ // stick sensitivity indicator
// alpha = 1.0;
// selector = "drawStickSensitivityIndicator:";
// x = 151;
// y = -165;
// height = 12;
// width = 12;
//},
{ // scanner zoom indicator
alpha = 1.0;
selector = "drawScannerZoomIndicator:";
x = 108;
y = 24;
y_origin = -1;
},
{ // scanner
alpha = 1.0;
selector = "drawScanner:";
x = 0;
y = 60;
y_origin = -1;
height = 72.0;
width = 288.0;
rgb_color = (1.0, 0.0, 0.0);
},
{ // compass
alpha = 1.0;
selector = "drawCompass:";
x = 132;
y = 24;
y_origin = -1;
rgb_color = (0.0, 0.0, 1.0);
},
{ // Targeting enhancement
equipment_required = "EQ_SCANNER_SHOW_MISSILE_TARGET";
selector = "drawTargetReticle:";
}
);
}
I've packaged the fix into an OXP and zipped it. The OXP can be downloaded from:drumz wrote:The simplest solution, for those on 1.77, is to create your own OXP. Go to your AddOns directory, and create a new directoy, let's say ScannerFix.oxp. Inside that directory create a directory names Config. Inside that directory create a file named hud.plist, with the following contents:JazHaz wrote:If the "fix" does work, I suggest putting up the hud.plist on box.com (or similar) for others to download.