Page 1 of 1

Clippers 1.3.1 leaves an error in the log

Posted: Sun Jan 20, 2013 10:40 pm
by Halfhand
Hi,

Ive found this error message in my log file

Code: Select all

22:13:00.285 [gnustep]: 2013-01-20 22:13:00.285 oolite[2716] File NSData.m: 3046. In -[NSDataMappedFile initWithContentsOfMappedFile:] unable to open AddOns/ClippersV1.3.1.oxp/requires.plist - oxp/AIs
turns out its a permissions issue.

original file looks like this

Code: Select all

-rw------- 1 root root 25 Dec 16  2011 requires.plist
i changed it to match other addons

Code: Select all

-rw-rw-r-- 1 root root 25 Dec 16  2011 requires.plist
That cleared the error from the log.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 4:04 am
by Diziet Sma
Smivs is currently recovering from a tummy bug, but I'm sure he'll be squashing this bug soon..

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 9:49 am
by Smivs
Hi Halfhand,
I don't think this is an error in the OXP. The requires.plist simply specifies the version of Oolite that an OXP will work under - Clippers has a version of 1.75.3 specified, so will work with that or any subsequent versions. What version of Oolite are you currently using? The current version is 1.77, so if you have an earlier version you should update.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 10:17 am
by Eric Walch
Smivs wrote:
I don't think this is an error in the OXP. The requires.plist simply specifies the version of Oolite that an OXP will work under -.
No, the log clearly shows it is not able to load the plist in the first place, so it can't evaluate the content. The read/write privileges are indeed a bit unusual. r/w for the user, but no access for the system. That probably means on the mac that if you put the oxp in the program folder and use an account that has no full access to the program folder, you might have similar issues. I always put my oxps in the user area and my account has full access to the program folder, so I can't easy verify if these privileges also could affect a mac system.
Normally the privileges are read only for the system and everyone else as stated in the first post.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 1:07 pm
by Halfhand
thats right Eric, only root (the owner) has access to the file so when the game runs under my account it has no privs to read the file.

world:read is the min required.

if the game was installed just for my account then i would be the owner and the problem would not have arisen.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 1:39 pm
by Eric Walch
Halfhand wrote:
thats right Eric, only root (the owner) has access to the file.
The good side is that this is a file that only limits access, so if this file can't be read, oolite will use that OXP with all versions. :)
Halfhand wrote:
world:read is the min required.
I am not so good at command level terminology. On command level the mac uses unix, but in the finder surrounding it is called:
Image
I assume "world" will be the same as "everyone" :lol:

Re: Clippers 1.3.1 leaves an error in the log

Posted: Mon Jan 21, 2013 1:51 pm
by Halfhand
yes, everyone:read would have fixed it.

group:rw wasn't really necessary but i made it the same as other OXPs just to be sure.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Tue Jan 22, 2013 2:05 pm
by Smivs
:shock: :?
Eh, sorry but you've lost me with all this mac-speak! Could somebody please clarify if there is an error in my OXP causing this (and if so what the solution is) or whether it was an installation issue.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Tue Jan 22, 2013 2:21 pm
by Eric Walch
Smivs wrote:
:shock: :?
Eh, sorry but you've lost me with all this mac-speak! Could somebody please clarify if there is an error in my OXP causing this (and if so what the solution is) or whether it was an installation issue.
The original report was by Halfhand and I think he is on Linux. Both Linux and the Mac are based on Unix and there privileges are important. I would expect this to be the same for windows, but apparently not. It is definitely an oxp error that the file has non-standard privileges.

On unix systems there is a clear difference between files that are accessible by everybody, or only by selected people or a selected group. I have no idea how privileges are set on windows systems. I know that on the mac it is advised for safety reasons to never do your normal work on an account with administrator privileges. The same will be true for Linux. So, you install the oxp with an account that has administrator privileges. Than you leave your account and log in with your normal account. Than, when playing Oolite, this oxp will bug because lack of privileges.

Re: Clippers 1.3.1 leaves an error in the log

Posted: Tue Jan 22, 2013 2:34 pm
by Smivs
Well I'm a Linux user! Ubuntu 10.10 with a system-wide install, and of course it works fine here.
The requires.plist is in the .oxp folder and in its entirety looks like this

Code: Select all

{
	version = "1.75.3";
}
So.......?

Re: Clippers 1.3.1 leaves an error in the log

Posted: Tue Jan 22, 2013 4:04 pm
by Diziet Sma
Smivs.. the problem isn't the file's contents.. it's the files permissions.. its' attributes.

Right-click the requires.plist and select 'Properties'. Now change to the Permissions tab. Can you see that nobody except the owner of the file is allowed to read it? If the owner happens to be 'root', (as can happen with system-wide install, but not necessarily, as it depends where the AddOns folder is located) Then Oolite will not have permission to read the file. When that happens, Oolite reports unable to open AddOns/ClippersV1.3.1.oxp/requires.plist.

Look at the picture below. Do you see the difference in permissions between equipment.plist and requires.plist? In this instance, I'm the owner of the files. But if root was the owner, neither Oolite nor I would be able to open the requires.plist file.. Group and Others have no permissions. They need to be changed to Read-only.

Image

Re: Clippers 1.3.1 leaves an error in the log

Posted: Tue Jan 22, 2013 4:20 pm
by Smivs
Ah, thanks Dizzie. Yes, it's 'none' where it should be 'read only'. What a PITA! How does that happen then?! <mumbles and grumbles a lot>.
I'll have to check all my OXPs I suppose and sort out this and any others.
Watch this space...