Oolite Bulletins

The playerJumpFailed handler is called at the end of a witchspace or galactic witchspace countdown, if the jump is not possible. The reason parameter is a string specifying why the jump failed; currently, the possible values are “blocked”, “too far” and “insufficient fuel”. Other values may be added in future.

Code: Select all

this.playerJumpFailed = function(reason)
{
     // Your code here
}

cim wrote:

"too far" = destination outside 7 LY range (which should be impossible, as it would require the destination to move)
"insufficient fuel" = destination inside 7 LY range but fuel level drops between initiating countdown and completion.
"blocked" = heavy object too near player
"malfunction" = misjump that causes jump to fail
"malfunction" = Galactic Hyperdrive destroyed while GH countdown in progress
"no target" = hyperspace system was set to current system while countdown in progress (which should be impossible, as you can't change the destination when a countdown is in progress)

A heavy object is too close if mass / distance-squared >= 10

Wildeblood wrote:

- Also, are all those implemented in 1.76.1 - I'm not interested in trunk-only cases?

Wildeblood wrote:

- What do you mean by '"malfunction" = misjump that causes jump to fail'? Does playerJumpFailed fire for a misjump into interstellar space? If so, before or after the other jump-related events? Or do you mean something else?

Wildeblood wrote:

- So does playerJumpFailed fire with "too far" when you have insufficient fuel and the countdown refuses to start/aborts immediately?
- And does "no target" occur when you press H without setting a target first, and the countdown refuses to start?

Wildeblood wrote:

Now the big question, how do I check for this in javascript: "A heavy object is too close if mass / distance-squared >= 10"?

function() {
// get all entities within scanner range of player ship
  var blockers = system.filteredEntities(this, function() {return true; }, player.ship, 25600);
  for (var i=0; i<blockers.length; i++) {
// if they are a ship
    if (blockers[i].isShip) {
// get distance by comparing positions
      var d = player.ship.position.subtract(blockers[i].position).magnitude();
      if (blockers[i].mass / d*d >= 10) {
// too close and heavy, return the blocking entity
        return blockers[i];
      }
    }
  }
// if we get this far, nothing is blocking
  return null;
}

cim wrote:

If the "maintenance level" check on entering witchspace fails, there are three possible outcomes:
1 - ship remains in current system and takes internal damage

// if they are a ship
    if (blockers[i].isShip) {

Wildeblood wrote:

I'll have a bit more of a think about the maintenance / misjump issue. At first sight, I think it's irrelevant. I can't recall seeing this first case happen:-

cim wrote:

1 - ship remains in current system and takes internal damage

Wildeblood wrote:

The most massive object of all - the planet - doesn't count?

scriptedMisjump : Boolean (read/write)

When true, the next hyperspace jump will be a misjump. The scriptedMisjump flag will remain true during the shipWillExitWitchspace() event handler, and will be set to false after the shipExitedWitchspace() event.

Wildeblood wrote:

Actually, I've had a bit more of a think about it and this maintenance level business is an issue. There is no way I can test for that, is there?

Wildeblood wrote:

When can I check this, anytime or only after the jump begins with shipWillEnterWitchspace?

cim wrote:

A heavy object is too close if mass / distance-squared >= 10

cim wrote:

var d = player.ship.position.subtract(blockers.position).magnitude();
if (blockers.mass / d*d >= 10) {
// too close and heavy, return the blocking entity
return blockers;

I see what you did there.

I can start by checking alertCondition. If it's green, no need to check further for blocking masses, I can go straight on to checking for sufficient fuel.

Wildeblood wrote:

I can start by checking alertCondition. If it's green, no need to check further for blocking masses, I can go straight on to checking for sufficient fuel.

Wildeblood wrote:

cim wrote:

A heavy object is too close if mass / distance-squared >= 10

cim wrote:

var d = player.ship.position.subtract(blockers.position).magnitude();
if (blockers.mass / d*d >= 10) {
// too close and heavy, return the blocking entity
return blockers;

I see what you did there.

Wildeblood wrote:

Does "return null" actually do anything when it's the last line anyway?

Wildeblood wrote:

Version 3

Code: Select all

this.$checkForNearbyMasses = function()
	{
	var blockers = system.filteredEntities(this, function() {return true;}, player.ship, 25600);
	for (i = 0; i < blockers.length; i++)
		{
		if (blockers[i].isShip
      && blockers[i].mass / player.ship.position.squaredDistanceTo(blockers[i]) >= 10) return blockers[i];
		}
	}

Is this still equivalent, or have I got ahead of myself?

this.$checkForNearbyMasses = function ()
{
    var psPos = player.ship.position;
    var blockers = system.filteredEntities(this, function (entity)
    {
        return entity.isShip &&
               entity.mass / psPos.squaredDistanceTo(entity) >= 10;
    }, player.ship, 25600);
    
    if (blockers.length > 0)  return blockers[0];
    // Or, if you don't care about the specific entity, return blockers.length > 0;
}

	var blockers = system.filteredEntities(this, function (entity) {
		return entity.isShip &&
		entity.mass / player.ship.position.squaredDistanceTo(entity) >= 10;
		}, player.ship, 25600);

    var psPos = player.ship.position;
    var blockers = system.filteredEntities(this, function (entity)    {
        return entity.isShip && 
         entity.mass / psPos.squaredDistanceTo(entity) >= 10;
    }, player.ship, 25600);

Ahruman wrote:

3. it only looks up global.player.ship.position once.