Page 1 of 1

Bug with decimal-separator

Posted: Sat Jun 02, 2012 3:10 pm
by Poovga
Hello Commanders,
I haven't been playing Oolite much these two last years but I am back in trade and fight :)

I just loaded the new version and a bunch of OXP's, including my only OXP Oolite en Français (Oolite in French)

On the F2 screen (Commander's presentation), the total of money is shown as 12number-decimal-separator2 Cr and the bounties while flying are unreadable.
I have been unable to find "decimal-separator" in the config files.

I'd like to know if it comes from my OXP, so I could modify it... I may have replaced the decimal separator by a coma (as we are used to do in French) instead of the English dot. I imagine that the coma could mean another thing for the programming language.

Has anybody got a clue?

Thanks,

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 3:24 pm
by Cody
The "number-decimal-separator" = "."; is line 40 in Oolite's descriptions.plist, and a comma will work... I think.

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 3:36 pm
by Poovga
Hola El Viejo,

Here are the not working lines :

// Currency format
"@-credits" = "%@ ₢";

// *** Misc. messages ***
// Messages used when awarding bounties
"bounty-@" = "Prime : %@";
"total-@-credits" = "Total : %@";

Can you see anythong wrong with them?

Thanks,
Poovga

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 3:39 pm
by Cody
Hola! Heh, that's beyond me... wait for a boffin to appear.

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 3:54 pm
by Eric Walch
El Viejo wrote:
Hola! Heh, that's beyond me... wait for a boffin to appear.
Why, it looks that you already pointed to the right location in the right file. I just downloaded the french localisation version. That does not include those separators. So probably they need to be added there from Oolite itself and adapted to the localized files.

Actually, the whole installation description for those files are a bug. It is not offered as a nice oxp that overrides the internal descriptions, but it tells to replace Oolites internal files with it. But that only works with Oolite 1.72.2 were it was tested with. In newer oolites you will lose essential descriptions, like the new formatting rules.

The way it is presented it is already incompatible with Oolite 1.73 and higher. It would already be compatible with any oolite if the folder was renamed to 'Config' and put in a new folder "French_Localisation.oxp" But a complete rewrite with the overwrite_plists would be better.

If Poovga is able to make it a working oxp for him, it would be good for al french speaking players that it replaces the current buggy version. (Look for instance to the German or Italian version how they created an oxp from it.

EDIT: The german version I just downloaded has a bug that it contains an oxp inside an oxp. No idea what went wrong there. Oolite can work correctly with it, but its not a good example, so stick to the Italian version. :P

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 4:18 pm
by Poovga
Eric,

My only OXP is no more working *sigh*.
I start by removing the buggy files from box.net and links...
Then I'll have a look to the Italian files and do what have to be done.

More job on my plate, but French commanders will fly back with a better experience...

Thanks for quick tracking of the problem and the solution.

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 4:21 pm
by Commander McLane
Poovga wrote:
Eric,

My only OXP is no more working *sigh*.
I start by removing the buggy files from box.net and links...
Then I'll have a look to the Italian files and do what have to be done.
The only thing you really need to do is to look into the current descriptions.plist and translate everything in there, especially those lines which didn't exist at the time of Oolite 1.72.

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 4:32 pm
by Poovga
Ok... Seems easier put that way :)
But description.plist is a big file...

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 6:54 pm
by Commander McLane
Poovga wrote:
Ok... Seems easier put that way :)
But description.plist is a big file...
Just open the 1.76.1 description.plist and the existing French OXP description.plist side by side. Copy any entry that isn't yet in the French OXP into it and translate it. Delete any entry from the French OXP that has no counterpart in Oolite 1.76.1.

Warning: many entries have been renamed since 1.72. So it may indeed be a lot of work after all this time.

Re: Bug with decimal-separator

Posted: Sat Jun 02, 2012 10:19 pm
by Poovga
Hello McLane,

I am on it: Oolite is my favorite line on my resume :)

If it goes well, there is still a few hours of translating to go and, probably, a couple of days for testing...
Update to come then.

Re: Bug with decimal-separator

Posted: Thu Jul 19, 2012 4:15 pm
by Nzingu
Hi all !!

I'm so glad i found this topic !

I tried to install french on oolite, with a rather poor result !
In this state, french oolite isn't easy access !

I'm a newbie in this game, but i like the project (though it's sometimes really long to get to the station !)
and i think i could help in completing the translation job (not good at all at coding, but i'd like my kids to play on linux,
and i can exchange english for french in some part of a file)

So please Poovga, tell me if you got something done about that, otherwise i may try and do the job !

Thank you all !


Nzingu

PS: I'd really like to get rid of the decimal-separator too !

Re: Bug with decimal-separator

Posted: Fri Jul 20, 2012 11:51 am
by Fatleaf
Nzingu wrote:
I'm a newbie in this game, but i like the project (though it's sometimes really long to get to the station !)
and i think i could help in completing the translation job (not good at all coding, but i can exchange english for french in some part of a file)

So please Poovga, tell me if you got something done about that, otherwise i may try and do the job !

Thank you all !
Welcome To The Friendliest Board This Side Of RiedquatTM Nzingu.

We all were once a newbie so stick with it and you will find everyone here ready to help. It is great you are offering to help and I'm sure it will be greatly appreciated.