Some sensible tweaks

[Svengali]

Addendum: Has anyone ever done this in a ship OXP - adding a sound effect to a shipSpawned event to alert the player when a particular ship is about?

Cabal_Common_Music (used in Vector and the demo) does something similiar. It plays the specified musicfile when a specific ship is close to the player. Dunno if it still works in v1.80/v1.82. Oh, and establishing streams is costly.

[Wildeblood]

The problem is that "legality_export" is present on all items. It's just zero for most of them. Which means that the undocumented launch option will be available as long as the player has any cargo at all.

Yeah, nah. If it's zero the condition test (0 & 1) should fail, not pass. Something else is happening.

[Lone_Wolf]

Yeah, nah. If it's zero the condition test (0 & 1) should fail, not pass. Something else is happening.

WildeBlood, that sounds like you assume js treats market[prop].legality_export as a Boolean value where 0 equates false .

legality_export is a number according to wiki, and i think js doesn't convert that into a boolean value, but interprets your condition as "does market[prop].legality_export exist" .

[cim]

WildeBlood, that sounds like you assume js treats market[prop].legality_export as a Boolean value where 0 equates false .

JS treats various things as false in that sort of check - false, 0, "", null and undefined. Usually useful; occasionally a problem when the sort of false something is matters.

[Cholmondely]

Wiki page put up for Dockside Services: http://wiki.alioth.net/index.php/Dockside_Services

As far as I can tell, this OXP is now redundant. Everything it does is already incorporated into the Game Code.

Or am I wrong?

[Cholmondely]

Wiki page put up for Undocumented Launch: http://wiki.alioth.net/index.php/Undocumented_Launch