One of the test pilots testing a WIP found an unexpected behaviour in the OXP... when I checked the save file I came to the conclusion that when the arrival report is displayed and if the player presses F2 instead of space, the mission screens are not displayed. That means missionScreenOpportunity is not fired. If the player launches and docks again the mission screen for the related stage will be displayed. Thanks to Wyvern for finding this bug.
Last edited by Okti on Sat Jul 30, 2011 5:53 pm, edited 1 time in total.
In playerEntitiesControls.m are the missionscreens handled special so they only accept certain keys. Probably the same should happen for report screens. Best place to fix is probably line 3110:
Meh, I've just had some fun with semi-random breakages related to new event functionality, so I couldn't agree more!
Therefor I want to do some longer testing before committing.
First tests I just did, show that it works as wanted. The report page now only accepts a spacebar and the F1 key like the missionscreen. And missionscreens are triggered correct after leaving the report page.
The report screen now only accepts the spacebar as input (And the F-1 key to launch).
It was the addition of a single check after all that is not likely to interfere with other stuff.
I could not find any incompatibilities, not even when testing legacy mission screens.
Yep, that was my commit number. Somehow there is a lot of update action the past days so that we are further than I thought.
And I have still one other in the pipeline with a correct size check on launching ships. It's fully ready but I want to find some time to do some in-game tests with a few models that just fit.
