Page 61 of 65
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 7:45 pm
by Cody
Shadered, of course!
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 9:49 pm
by tsoj
I really like the fully dark blued shadered steel.
Once we decided which textures to use, I will put them up on the GitHub, including the (possibly preliminary Komodo textures). For the release file, I would remove all bigger elements (i.e. images) that are not currently used.
Then when we verified that it all works (I would like to test if everything spawns the way it should) I would say we put in on the Oolite Wiki Website and to the Expansion Manager.
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 10:06 pm
by Cody
<nods>
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 10:34 pm
by Cody
Got one of these again (and I'm nowhere near any HIMSN station system):
Code: Select all
22:17:30.050 [WARNING]: Warning! Global namespace polluted by:
22:17:30.050 [WARNING]: ["timeToFirstWarning","timeToForcedLaunch","_assert","isAtHIMSNStation","_forcedStationLaunch","_generateAlienItemPrice"]
Question: is a Navy station spawned at the other Xeer (G7)?
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 11:06 pm
by tsoj
Cody wrote: ↑Thu Dec 23, 2021 10:34 pm
Got one of these again (and I'm nowhere near any HIMSN station system):
Code: Select all
22:17:30.050 [WARNING]: Warning! Global namespace polluted by:
22:17:30.050 [WARNING]: ["timeToFirstWarning","timeToForcedLaunch","_assert","isAtHIMSNStation","_forcedStationLaunch","_generateAlienItemPrice"]
Question: is a Navy station spawned at the other Xeer (G7)?
I think I know how to fix this. All these functions are declared in the form:
function blablabla(a,b,c){ … }
I thought this would be okay, but it seems like the better practice would be to do this:
this.blablabla = function(a,b,c){ … }
There should only be a station at Xeer Galaxy 1.
For the time being, I will leave it like that, until I get time to properly test that I don't mess up anything in the process of fixing this warning. I made a note, so that I don't forget about it.
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 23, 2021 11:09 pm
by Cody
Cool! Although... perhaps there should be a station at Xeer (G7) too?
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 30, 2021 3:24 pm
by cbr
The Aquatica Cargo Hauler has been send on his way with the paint/paintscheme for the release...
Meanwhile here are some variants.
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 30, 2021 5:09 pm
by Cody
Nice! Looking at the descriptions.plist: even though the carriers don't appear (is that correct?), I'd be inclined to change their names to star/system names. And what of ordinary Navy ships - how are they named? Any opinions?
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 30, 2021 9:05 pm
by Cholmondely
cbr wrote: ↑Thu Dec 30, 2021 3:24 pm
The Aquatica Cargo Hauler has been send on his way with the paint/paintscheme for the release...
Meanwhile here are some variants.
These look superb! Thank you!
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 30, 2021 10:32 pm
by cbr
Cody wrote: ↑Thu Dec 30, 2021 5:09 pm
Nice! Looking at the descriptions.plist: even though the carriers don't appear (is that correct?), I'd be inclined to change their names to star/system names. And what of ordinary Navy ships - how are they named? Any opinions?
Star/System/Region names would be fitting for oolite based navy ships.
Code: Select all
this._addNavyBattleFleet = function(pos)
{
// Add Navy Carrier and defending fleet:
var navyCarrier = system.addShips("himsn_komodo_carrier",1,pos,0)[0];
The only link with the carrier in himsn_main.js.
I combined this function with a launchedfromstation condition, stil no fleet added.
I wonder if the only ships launched are/were stations defenders
Regarding the naming ordinary oolite navy ships perhaps they could be bundled in region fleets,
region named fleet group build up like Norby did with cargofleets and the sherifs
Re: Her Imperial Majesty's Space Navy
Posted: Thu Dec 30, 2021 10:48 pm
by Cody
Thanks! No carriers is fine by me, but I'll rename them anyway.
Re: Her Imperial Majesty's Space Navy
Posted: Fri Dec 31, 2021 1:53 am
by tsoj
A quick release with the new textures by cbr and a few bug fixes.
Direct link:
0.9-alpha
I haven't had the time to properly test everything. I will do that next year.
The changes in the shipdata.plist for the new textures I had to enter manually, so I hope I didn't mess something up.
@cbr, if you want, you can take a quick look
here if you see something obvious missing. I noticed that at some places there is still the "shininess" parameter, even though there's also a new "gloss". Is that intended?
Re: Her Imperial Majesty's Space Navy
Posted: Fri Dec 31, 2021 10:06 am
by Cody
Thanks tsoj - grabbed!
Re: Her Imperial Majesty's Space Navy
Posted: Fri Dec 31, 2021 12:48 pm
by cbr
The new upload seem to work and the models show up in the gallery like intended!
I still encounter the shininess setting in several oxps so I do not remove them explicitly ( ( as of ) yet )...
Re: Her Imperial Majesty's Space Navy
Posted: Fri Dec 31, 2021 2:00 pm
by Cody
Polluted namespace error has gone. The only log blemish now (which is of no consequence) is:
Code: Select all
Script ../AddOns/himsn.oxp/Scripts/himsn_constrictor_conditions.js does not "use strict";