Explaining on the previous post:
The flashers on the comlim-escape-pod are broken (perhaps due to a c&p-mistake). Instead of
Code: Select all
<string>*FLASHER* 0.04.42 -1.54 0.0 2</string>
<string>*FLASHER* 3.83 -2.21 -1.54 0.0 2</string>
<string>*FLASHER* -3.83 -2.21 -1.54 0.0 2</string>
it should probably be
Code: Select all
<string>*FLASHER* 0.0 4.42 -1.54 0 2 0.0 2</string>
<string>*FLASHER* 3.83 -2.21 -1.54 0 2 0.0 2</string>
<string>*FLASHER* -3.83 -2.21 -1.54 0 2 0.0 2</string>
(just copied from the default Oolite escape-pod's shipdata).
However, as I opened the shipdata anyway, there are some more problems: The escape-pod's script-actions are screwed up as well:
Code: Select all
<key>script_actions</key>
<array>
<string>debugOn</string>
<dict>
<key>do</key>
<array>
<string>commsMessage: [commissarharikiri]</string>
<string>setLegalStatus: 200</string>
</array>
</dict>
<string>debugOff</string>
</array>
If they start with a <key>do</key>, there is a <key>conditions</key> missing in front of it. If there are no conditions to it, the <key>do</key> is wrong, and the whole thing should just read (without the debug-commands, which aren't needed anyway except for play-testing):
Code: Select all
<key>script_actions</key>
<array>
<string>commsMessage: [commissarharikiri]</string>
<string>setLegalStatus: 200</string>
</array>
Just by the way: It's har
akiri.
Oh, and just to be sure that this is actually what you wanted:
script_actions are performed if the entity gets
scooped, not when it is
killed (that would be
death_actions). The messages themselves indeed seem to be appropriate for the case of scooping, although they seem to suggest a suicide of the sender. So probably they should include the suicide itself as well. Something like the escape pod exploding and damaging the player's fuel scoops. As this is not scriptable in legacy, perhaps it would be a good opportunity to switch to a ship-script instead of the
script_actions-array?
Another easily detectable problem is in the astromine: It has
station among its roles, unqualified. Which means that in Communist systems it may get chosen as main station. I doubt this is intended. So it should read
station(0) instead.
The comfactory on the other hand has a ridiculously low role probability for its station-role:
station(0.00000001), which may make things unnecessarily complitated for the system populator. Better use
station(0) as well.
Same goes for the slapu.
Oolite's other complaint is about the missing model for dock-factory. As this version of the dock isn't used anyway (the comfactory uses slapu-dock), it should be deleted altogether. Or alternatively an extra model should be added.
Leaving shipdata now. Another problem is the existence of a descriptions.plist in the AI-folder. Has no place there, and if it is intended for use, its content should go inside the existing descriptions.plist in the Config-folder.
Furthermore, while the pleas contained in it sound communist, the key is called 'trident-plea', which is certainly not from Commies (another c&p-problem, I think).
These should be brushed out in version 2.08. And then there is
this, of course. Although I don't know for the moment how to fix it.
