Trunk nightly

[another_commander]

Done - thank you!

[Getafix]

<Creaky sound of door opening... Approaching gasping and panting sounds... Getafix crawls slowly in the room in a rather unpleasant shape...>



Guys 'n' gals, disproportionally balancing between R/L and OO/L realms, and with disk cylinders resembling to something between swiss cheese and blue cheese, the nightly server is slowly recovering.
There will be interruptions, as the server is still in ER, hopefully gradually fading out.

<Getafix, painfully exits the room...>

[Cody]

Muchas gracias, amigo!

[Cody]

Not a bug as such, but I've not seen this before: no docking clearance message from the station.

Had this happen again last night - no request acknowledgement, no clearance message, but I did get the thirty-second warning.

[Getafix]

The nightly server shows clearly its age and it's down.
I'll have a look as soon as I manage to get my hands on it, i.e. tonight.

[Cody]

If the ASC gets damaged, it defaults to the basic planet only, yes?

[Commander_X]

... or to the station when close enough to it.

[Cody]

Thanks, that's what I thought... which is why this had me puzzled. The damaged ASC seemed to work fine, showing planet, sun, nav buoy, and hermit.

[another_commander]

Interesting... This bug goes as far back as at least v1.82.

[another_commander]

This should now be fixed with commit 3207533. In order to fix this, a new JS PlayerShip property, compassType, was introduced. What it does, is basically make the compass work as a dual-mode piece of equipment, if one wishes so, rather than being two separate pieces (basic and advanced equipment).

It is meant to be used mostly internally, but of course scripters can make use of it as well; they will just need to be a bit careful with it, because it lets you do stuff that would not be allowed in the normal game.

player.ship.compassType had to be introduced because the compassTarget and compassMode existing properties were by design read-only. What it does is set the compass to either basic mode or advanced mode, without caring about the Advanced Space Compass equipment being present or not. If you do not have the ASC present or have it damaged, then the property will still set the compass type to whatever the scripter wants, but it will print a log warning in this case. Note that switching your basic compass to an advanced one like this is not a permanent change; it all gets reset whenever the universe is recreated, i.e., after a hyperspace jump to a new system, so be careful if you do decide to incorporate it in your scripts.

Usage:
player.ship.compassType = "OO_COMPASSTYPE_BASIC"; or
player.ship.compassType = "OO_COMPASSTYPE_ADVANCED";
Any other value will result in an error.

Of course, if you never use this property in your scripts, the only difference you should see is that when the ASC breaks now, it breaks as expected. And, hopefully, the ASC is the only thing that I've managed to break during this attempt. If you see any problems with this, let me know. If you think that it would be best if the compass type should not be switchable without the Advanced Compass equipment being present, feel free to say so, It should be posible to change the current warnings of the property to errors and reject changes if so desired (although I'd think it's best the way it is now).

[Cody]

Thanks - sounds like you had some fun with that one.

[Cody]

My ASC took a hit again... erm, is this correct breakage? Still locked onto the station, I reckon, but showing the red circle?

[another_commander]

It should lock on the main station on breakage, if the main station is nearby. If it is not the case, I am suspecting OXP interference because for me it works OK.

Meh, what'd you expect, it's broken anyway...

[Cody]

Yeah, it's broken anyway... and I'm an old fool! <chortles> Where's my medication?

[Getafix]

...Meh, what'd you expect, it's broken anyway...