Page 6 of 6

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Fri Jun 21, 2013 10:13 pm
by Switeck
Duggan wrote:
Am I to follow these instructions within the System Redux oxp or do I have to go into the innards of the game itself?
Neither OXP is the "innards of the game itself". To edit that (which is unnecessary to add rings) would require editing the core game's source code.

You need to edit BOTH the System Redux OXP and edit the systemfeatures-ring.js script in System Features: Rings OXP as well to get rings to appear around a planet added by System Redux.

Since I haven't carefully studied System Redux OXP, I can't tell you what/where in it to alter to add rings to its planets.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Fri Jun 21, 2013 11:52 pm
by Duggan
Thank you once again for your time Switeck You have provided clarity for the outcome I envisaged which , though not too far removed from yours, remains a little way off . :)

Don't mind me . I am also thinking would not one of these further lend towards the immersiveness.

http://www.pinktentacle.com/images/comet_1.jpg

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:03 pm
by JazHaz
What would I need to do to vary the shape of the Sunspots? They are all the same at the moment. Real sunspot groups on our sun can be a lot bigger, sometimes they can be seen without magnification.

Warning!
Looking at or near the Sun will cause immediate and irreversible damage to your eyes. Eye damage is often painless, so there is no warning to the observer that damage has occurred until it is too late. Do not point a telescope or its viewfinder at or near the Sun. Do not look through a telescope or its viewfinder as it is moving.

Image

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:20 pm
by cim
JazHaz wrote:
What would I need to do to vary the shape of the Sunspots? They are all the same at the moment. Real sunspot groups on our sun can be a lot bigger, sometimes they can be seen without magnification.
If you have shader support, the sunspots should vary in shape a bit (and change slowly over time). You can get a sunspot group by adding several sunspots near each other, I suppose.

What's really needed is a better fragment shader that can do a bit more variety, and perhaps a larger model for it to work over, but my shader knowledge isn't good enough to put that together.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:29 pm
by JazHaz
cim wrote:
JazHaz wrote:
What would I need to do to vary the shape of the Sunspots? They are all the same at the moment.
If you have shader support, the sunspots should vary in shape a bit (and change slowly over time).
Hmm, I'm not seeing that, maybe its because my sessions are short. And they don't seem to vary over saves.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:34 pm
by cim
JazHaz wrote:
Hmm, I'm not seeing that, maybe its because my sessions are short. And they don't seem to vary over saves.
Try doing

Code: Select all

worldScripts["System Features: Sunspots"]._addSunspot()
from the debug console a few times. If they don't look any different to each other, then check your log file for shader errors.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:56 pm
by JazHaz
I did as you suggested.

Image
Debug Sunspots by JazHaz, on Flickr

No sunspots on the sun. No shader errors in the log either.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 2:59 pm
by cim
JazHaz wrote:
No sunspots on the sun. No shader errors in the log either.
50/50 chance they got added to the other side of the sun. I tend to have to add ten or twenty before I can guarantee seeing a few of them.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sat Sep 28, 2013 3:20 pm
by JazHaz
cim wrote:
JazHaz wrote:
No sunspots on the sun. No shader errors in the log either.
50/50 chance they got added to the other side of the sun. I tend to have to add ten or twenty before I can guarantee seeing a few of them.
D'oh! OK try again....

EDIT: Here we go:

Image
Sun with 2 sunspots already, about to add more by JazHaz, on Flickr

Image
Same sun, but with lots more by JazHaz, on Flickr

It seems to work. And the ones near the edge of the sun appear as if they were around the side (though I know that the sun is just a flat image, and not a globe at all). Very nice!

Maybe it doesn't need improving.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Sun Sep 29, 2013 9:40 am
by Diziet Sma
JazHaz wrote:
Maybe it doesn't need improving.
I wouldn't agree entirely.. I think your earlier point about sizes and shapes still stands.. I'd love if they could be made a little more realistic, even though Cim has already done a fantastic job with them..

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Tue Nov 12, 2013 8:30 pm
by Duggan
Sorry for the thread necromancy, but this oxp may need a little look see for 1.79,

I can't take a snap shot in trunk however, broadly speaking, the planetary ring does not go behind the planet anymore, rather there is the elipse formed by the planetary ring superimposed on to the planet.

I only mention this for reference to the future release of oolite, it still works fine in 1.77.1.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Tue Nov 12, 2013 8:34 pm
by cim
Not entirely surprising - the shader for the rings does some very strange stuff. I'll have a look at some point.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Tue Dec 17, 2013 11:35 am
by Zireael
Does the sunspots part work with Realistic Stars OXP?

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Tue Dec 17, 2013 11:38 am
by cim
Zireael wrote:
Does the sunspots part work with Realistic Stars OXP?
It should do.

Re: [RELEASE] System Features: Sunspots and Rings OXPs

Posted: Wed Dec 18, 2013 5:05 am
by Diziet Sma
cim wrote:
Zireael wrote:
Does the sunspots part work with Realistic Stars OXP?
It should do.
I can confirm it does.. I use Realistic Stars in conjunction with Sunspots and Rings.