Page 46 of 54
Re: Split: Re-scaling experiment
Posted: Thu May 21, 2020 1:20 pm
by another_commander
It seems a bit better overall for normal planets, but for the large ones it goes a bit off. Check out Reorte at low altitude for an example.
Edit: With a quick experiment, a cosThreshold value of 0.08 at Reorte seems pretty ok. That should cover also most of the rest of the large planets.
Re: Split: Re-scaling experiment
Posted: Thu May 21, 2020 2:58 pm
by Redspear
I'm getting a similar look with:
Code: Select all
float cosThreshold = -1.333333e-6 * atmRadius / 10 + 0.17333333;
Seems to work well with different sizes.
Re: Split: Re-scaling experiment
Posted: Thu May 21, 2020 3:11 pm
by another_commander
I think I got this one that looks good for the three sizes I tried: Ra, Lave and Reorte. You can try giving it a go if you want:
Code: Select all
float cosThreshold = -1.11055807437937e-7 * atmRadius + 0.1511346252;
cosThreshold varies from 0.12 (Ra) to 0.08 (Reorte). Note that we are
not dividing radius by 10 with this one.
Re: Split: Re-scaling experiment
Posted: Thu May 21, 2020 6:19 pm
by Redspear
another_commander wrote: ↑Thu May 21, 2020 3:11 pm
I think I got this one that looks good for the three sizes I tried: Ra, Lave and Reorte. You can try giving it a go if you want:
Thanks. I'll try it at some other planets, likely Diso, Tionisle, Isionor, Leesti and Ontiat.
another_commander wrote: ↑Thu May 21, 2020 3:11 pm
cosThreshold varies from 0.12 (Ra) to 0.08 (Reorte). Note that we are not dividing radius by 10 with this one.
Yeah, I noted the e-7 rather than e-6 (I'd tried that also).
For anyone not following, a crude explanation according to my understanding.
The first part of the calculation (that gets multiplied to atmRadius) scales the relationship of atmosphere to planet size, which is why a rough and ready / 10 modifier worked, because a_c had already scaled it for planets 10 times smaller (i.e. default sizes). The second part (again, crudely speaking) sets the baseline of where we are scaling from (a starting point). Too high and the atmosphere lies mostly within the planet radius, too low and you lose the subtle haze effect you can see in some of the pictures. So if the first value is close enough to be functional (i.e. reflects change in planet size) then there's some room to fine tune with the second for the look you want.
Although the haze looks really good, there's something to be said for a higher visible atmosphere (esp. at increased planet sizes) and so I tried lower values added to atmRadius with...
Code: Select all
vec3 fresnel = vec3(pow(1.1 - (NdotV * 0.31831), kFresnelExponent));
which predictably restored some of the cloudiness (less like a glass ceiling) but did little for the reduced fading.
Re: Split: Re-scaling experiment
Posted: Thu May 21, 2020 8:09 pm
by Commander_X
gizmo wrote: ↑Mon May 18, 2020 4:05 pm
Redspear wrote: ↑Mon May 18, 2020 11:48 am
another_commander wrote: ↑Mon May 18, 2020 10:59 am
I think that releasing a binary would go a long way to enabling more extensive testing. Just a zip file with the oolite.app and AddOns folders should be all that is needed.
Fair enough, I'll give that a go.
Yeah, that would be great as I haven't managed yet to compile Oolite on my system (Slackware Linux with Plasma 5).
<I tried to PM, but it seems the system is a bit off for now -- sorry for the noise here>
As a fellow Slackware user, we can try to work this out. Maybe open a thread to follow on your issues.
Re: Split: Re-scaling experiment
Posted: Fri May 22, 2020 12:55 pm
by Redspear
another_commander wrote: ↑Thu May 21, 2020 3:11 pm
I think I got this one that looks good for the three sizes I tried: Ra, Lave and Reorte. You can try giving it a go if you want:
Code: Select all
float cosThreshold = -1.11055807437937e-7 * atmRadius + 0.1511346252;
cosThreshold varies from 0.12 (Ra) to 0.08 (Reorte). Note that we are
not dividing radius by 10 with this one.
Seems to work well. Here it is at Ontiat (a little bigger than Reorte)
...and here it is with
Redspear wrote: ↑Thu May 21, 2020 2:58 pm
Code: Select all
float cosThreshold = -1.333333e-6 * atmRadius / 10 + 0.17333333;
Both are captured at the point where atmospheric friction requires slowing down. Second image has a slightly larger reach I think (which I like) but here's the tradeoff...
Not the clearest comparison, so apologies for that, but the haze seems to be a little more confined to the planet 'edge' with my fomula (second pic).
In any case, I think the 'problem' is essentially fixed.
Re: Split: Re-scaling experiment
Posted: Fri May 22, 2020 9:17 pm
by Redspear
And at the other end of the scale...
Ra this time, again with:
Code: Select all
float cosThreshold = -1.333333e-6 * atmRadius / 10 + 0.17333333;
I could spend ages tweaking this but I think that's a pretty good consistency among planet sizes.
If a problem presents itself in future then I'll look at it again.
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 12:51 am
by Commander_X
Quick question -- is the sun expected to have the size like in the another_commander's screenshot below ?
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 1:06 am
by Redspear
Commander_X wrote: ↑Sat May 23, 2020 12:51 am
Quick question -- is the sun expected to have the size like in the another_commander's screenshot below ?
Not in my build.
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 2:50 am
by Commander_X
Strange, either "Modest" or "Plus" oxp dropped over a self-build (nightly) show that type of sun.
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 7:21 am
by Redspear
Commander_X wrote: ↑Sat May 23, 2020 2:50 am
Strange, either "Modest" or "Plus" oxp dropped over a self-build (nightly) show that type of sun.
That's the size you get without either of the the oxps being active.
Could you please check that whichever one you're using is unzipped and placed in the addons folder with an .oxp extension (obvious I know but...) Then please check planetinfo.plist is included and each reference of 'sun radius =' has been preceeded by '//'.
Without that, what you get is the default sun sizes, which are approximately 10 times too small (one can argue about the distance of course but certainly they're too small without the change).
I was under the impression that including planetinfo.plist would overwrite the default version? If not you could always cut and paste...
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 7:56 am
by another_commander
Redspear, I think you may have an already modified planetinfo.plist inside your Resources/Config folder. If I recall correctly, the OXP planetinfo overrides the one in Resources, but only for values that are redefined. If your Resources/Config planetinfo contains a sun radius value and the OXP one does not (i.e. it has it commented out), then the sun radius from the Resources one will be used.
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 8:39 am
by Redspear
Ah yes, that makes perfect sense.
The oxp doesn't define sun radius and so it defaults to the preset values...
Looks like I'll have to include it as a core change.
Re: Split: Re-scaling experiment
Posted: Sat May 23, 2020 11:03 pm
by Redspear
Quick test build release:
Win 64 Test Build
There's a few other things in there:
- 30/20km scanner as seen in some of my pics
- Target scanner text as suggested by Disembodied
- Dulled target reticles (I've always found them to be a bit overbearing)
Rescale _Plus is enabled by default. If you'd like to try out Rescale_Modest then simply swap the suffixes (i.e. rename Rescale_Modest.off to Rescale_Modest.oxp and rename Rescale_Plus.oxp to Rescale_Plus.off).
It's a big file so I don't know holong my bandwidth limits will hold up for...
Re: Split: Re-scaling experiment
Posted: Sun May 24, 2020 8:22 am
by another_commander
Congrats on your first release!