Page 5 of 6

Re: OXP table and v1.75

Posted: Wed Mar 16, 2011 8:24 am
by Eric Walch
Smivs wrote:
The compatibility was checked by Fatleaf, who installed each of the OXPs, ran them for a while and checked for log errors. He has done an amazing bit of work for us and deserves great thanks.
If any OXPs are found to have problems, please try to report these on the OXP's thread where possible.
One problem with testing by just running the oxp for a while is that you miss the code lines that are only used in special situations. In particular, will mission oxps contain such code that only pops up when doing that special mission. The most sure way to fix them is explicit search the code for known casing problems.
Having said that, I think most mission oxps are already checked by the authors. From my updated oxps I know that one still has a bug. But that won't be noticed by the player, as it now just not adds a non-essential ship.

Re: OXP table and v1.75

Posted: Wed Mar 16, 2011 9:21 am
by Smivs
To emphasise Eric's point, the OXPs were loaded and played briefly, then the logs were checked. If they loaded OK and showed no errors they have been marked as compatible, but this is not a guarantee that every aspect of the OXP will work OK.
Those with known issues have been marked as Y* and those known not to work are also marked (as 'N').
To repeat myself, if any issues are discovered please report them, ideally on the thread for the OXP in question, but a mention here might be helpful as well.
Cheers,
Smivs.

Re: OXP table and v1.75

Posted: Thu Mar 31, 2011 1:27 pm
by Smivs
OXPs are the subject of yet another thread so I've re-animated this one to remind authors to please check and confirm whether their OXPs are 1.75 compatible.
There are still several on the OXP table which are marked as 'unknown'.
It is ultimately the responsibility of the author to confirm compatibility, and either correct the OXP's entry on the table, or let me or any of the Wiki wizards know so that we can change it for you.
Please take a moment to check the table and if your OXP entries need adjusting, please let us know.

Re: OXP table and v1.75

Posted: Mon Apr 11, 2011 11:14 am
by Lone_Wolf
from [wiki]OXP List[/wiki]

Ships Dragon Assault Craft adds a heavy combat ship, and the Military Smart Missile, an improved hard head Cdr. Wyvern 2008-11-26 Y*

I have been using a Dragon-M with oolite 1.75.1 now for several hours play time and did not notice errors in the log, or weird behaviour.
(except together with Target Autolock Plus, but that's likely a game code problem, not an oxp problem. https://bb.oolite.space/viewtopic.php?f=3&t=9620 )

Re: OXP table and v1.75

Posted: Mon Apr 11, 2011 11:16 am
by Smivs
Thanks, LW. Sounds stable so I'll update the entry.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 9:17 am
by Smivs
On another thread Maresnest suggested that 'Factions', his new OXP needs all the systems OXPs to be installed to work, but then it became clear that this was not the case, because that old Chestnut Realistc Shipyards is still listed as a systems OXP but is clearly not needed for Factions to work.
What I'm wondering is whether all the 'broken' OXPs (those at the bottom of the table) should still be listed by catagory, or whether this should be left blank for their entries?
Any thought, opinions?

Re: OXP table and v1.75

Posted: Mon May 30, 2011 9:25 am
by maik
Smivs wrote:
On another thread Maresnest suggested that 'Factions', his new OXP needs all the systems OXPs to be installed to work, but then it became clear that this was not the case, because that old Chestnut Realistc Shipyards is still listed as a systems OXP but is clearly not needed for Factions to work.
What I'm wondering is whether all the 'broken' OXPs (those at the bottom of the table) should still be listed by catagory, or whether this should be left blank for their entries?
Any thought, opinions?
I don't think it makes much sense to say that the Factions OXP needs "all" other system OXPs. This might work at one point in time but as soon as new system OXPs arrive they might break Factions. When an OXP has dependencies it is important to list them precisely.

To answer the other question: I don't see a good reason to remove the category of broken OXPs. I do, however, see a good reason to remove Realistic Shipyards. All information I have points to it not being relevant for Oolite anymore. It hasn't been downloadable since I started mucking with the OXP List.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 9:34 am
by Smivs
What I'm suggesting is that the broken OXPs should have their categories removed, to prevent them showing in the sortable lits. This would mean editing each wiki page to remove the category link at the bottom. Worth doing in my view.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 9:46 am
by maik
I know what you mean. I'd rather add something like a "broken" sticker to broken OXPs that have their own wiki page though. Similar to the deleteme sticker. That way, when you don't go via the OXP List but the category and end up on a broken OXP's wiki page you get a warning.

Even broken OXPs still do belong to a category after all.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 9:53 am
by Commander McLane
maik wrote:
I don't think it makes much sense to say that the Factions OXP needs "all" other system OXPs. This might work at one point in time but as soon as new system OXPs arrive they might break Factions. When an OXP has dependencies it is important to list them precisely.
Quote for emphasis.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 10:13 am
by Smivs
That's what I was thinking, Maik. Introduce a 'Broken' category.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 10:40 am
by maik
Smivs wrote:
That's what I was thinking, Maik. Introduce a 'Broken' category.
Am already in the process of doing that. Just keeping the OXP category of the broken OXPs as well, so they would be listed e.g. in both Systems and Broken. When you navigate to the wiki page of the broken OXP you get a warning sticker next to the download.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 11:15 am
by Smivs
I'm not sure that's the best way forward. If people (as in this case) want to find all the systems OXPs they will want to find ones that work. Many do not read readmes and wiki pages, they see a link and download and that's it! so a warning on the wiki page may not be sufficient.
The more I think about this the more persuaded I am that we need a 'broken' category, and OXPs in that category are not referenced elsewhere.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 11:45 am
by maik
Check the pages in Broken OXPs and tell me if you can miss the sticker when you actually get close to the download link.

I don't agree with removing the broken OXP's actual category. I have to add it again afterwards and have to remember what it was before I removed it.

Those two and a half people who are unable to see the big sticker next to the download link will be helped in the board.

Re: OXP table and v1.75

Posted: Mon May 30, 2011 1:03 pm
by Smivs
Agreed, but let's stick with RS for a minute as this is the one we're discussing.
Maresnest originally suggested that all systems OXPs were needed for his OXP to work, so I 'helpfully' put up a link to the Systems OXPs. On that page is a link to RS and there is no indication whatsoever that this OXP is broken, and I don't think that is good. Broken OXPs should not show under the categories to my mind.
I'm even starting to question whether they should have a place on the OXP table page.
RS (and others) are not only broken, but there is not even a download link for it. What is the point of listing something that nobody can download and that would not work if they could.
I don't think they should be expunged from the Wiki altogether, but segregating them from available working OXPs might be sensible.