Page 5 of 7

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Sun Feb 27, 2011 4:49 pm
by Zireael
Will it be updated for Oolite 1.75.1?

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Mon Feb 28, 2011 6:30 pm
by Frame
yes it will... ill look at the fuel collector to start with, and the bounty scanner.. too..

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Mon Feb 28, 2011 6:58 pm
by Zireael
Frame wrote:
yes it will... ill look at the fuel collector to start with, and the bounty scanner.. too..
Yupee, thanks, I thought you'd disappeared! Give a shout here when you are done updating them, please?

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 6:27 am
by CommonSenseOTB
Yeah, I got bored and needed a change from huds this evening and decided to have a look at the save anywhere oxp. It's been what, 6 months since 1.75.1 and it hasn't been touched and so many players need it and won't even upgrade without it. This was actually the first time I looked at the code of this oxp. Boy did I get the shock of my life when I discovered the truth about this oxp. :shock:

Do you know what I found? 2 typos, a handful of bad equals and an incorrect GUI screen check. That was all that was wrong with this oxp. It took me 5 hours from start to finish including researching the changes between oolite versions, finding the bugs and playtesting. As it stands, the copy I modified is compatible with oolite versions 1.74.2, 1.75.1, 1.75.2, and 1.75.3. I'm simply amazed that nobody fixed this. :?

So now what do I do with this bugfixed copy of SaveAnywhere(3.2?).oxp. The oxp is listed as broken. Does that mean that it has been abandoned or that someone can fix it and repost a link for it to download? Does anyone know Frames intentions for this oxp? I would like to post a download link for this ASAP for the vast number of players who want and need it so they can play their way and upgrade to 1.75.3.

DH, Ganelon, lave, this one's for you. Someone please help me. What should I do here? :)

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 6:33 am
by Ganelon
I don't know what the protocol is on this sort of situation. However, I would like to be the first person you've listed to thank you, anyway!

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 6:45 am
by Thargoid
PM Frame and ask him. He's been on the board in the last few days (posted those sweet pics of his new ship) and should be able to advise you and/or give you permission to release or whatever.

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 6:56 am
by Capt. Murphy
Nice one CSOTB - you'll make a lot of people very happy.

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 7:12 am
by CommonSenseOTB
Thargoid wrote:
PM Frame and ask him. He's been on the board in the last few days (posted those sweet pics of his new ship) and should be able to advise you and/or give you permission to release or whatever.
PM has been sent. :wink:

Believe it or not I just wanted a little code diving diversion this evening. Oh well... :D

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 9:26 am
by DaddyHoggy
<BIG FEATHERY HUG>

As Thargoid says - Frame's around (more than recently) I'm sure he'll answer a PM

You're a star.

DH (on behalf of Save-Anywhere users everywhere!)

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 12:10 pm
by Mauiby de Fug
Congratulations! I took a look at it a while back, fixed the system/System things, guessed there was a problem with the GUI screen things from the resulting behaviour, but as I know nothing about them I didn't bother to look any further. And I doubt I'd have found the bad equals things unless I'd spent some serious time trawling through all 950 lines of the code. I'm sure a lot of people will be happy to get their play style working with 1.75 Oolite, and for those who haven't upgraded they can try out all the brand new features and oxps that people have created!

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 12:44 pm
by CommonSenseOTB
You know, after taking a good look at the code I have to admire Frame for coming up with it. At 15k it is a beautiful piece of work considering what it does. And all of you are very welcome. Only thing is I seem to be choking on feathers at the moment. :P If I had known I might die a fluffy death of asphixiation I would have at least done a few more huds<cough><cough>. :lol:

Anyway, back to the huds, tralala! :)

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 5:30 pm
by Dragonfire
YAYYYYYYYYYYY! I'll actually be able to save from the space bars! WOOOOT. Can't wait for the release!

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 9:16 pm
by CommonSenseOTB
I'm going to be a little busy for the next few days and as Frame was on the board and has not opened my PM he must be real busy. As far as I know posting a list of corrections for a broken oxp is not an issue so I am posting the list here and you can make the corrections yourself in your own copy of SaveAnywhere3.1.oxp in the main script file. At such time as Frame renders a decision on this you will know as soon as I do.

An early CSOTB christmas gift. Enjoy! :D

=============================================

CommonSenseOTB SaveAnywhere3.1 Bugfix Readme

The following lines should be corrected to appear as follows:

------------------------------------------------------------------------------------

line 487 let lstation = system.addShips(role,1,[-150000000,0,0],0)[0] //CommonSenseOTB bug found was big S for system

line 529 this.tracker = system.addShips("frame2_dumb_object", 1, this.mz,0)[0]//CommonSenseOTB bug found was big S for system

line 831 if(guiScreen !== "GUI_SCREEN_OPTIONS" && guiScreen !== "GUI_SCREEN_MISSION" && guiScreen !== "GUI_SCREEN_STATUS")//CommonSenseOTB bug found deprecated != and also changed "GUI_SCREEN_SAVE" to "GUI_SCREEN_OPTIONS"

line 846 if(guiScreen !== "GUI_SCREEN_OPTIONS" && guiScreen !== "GUI_SCREEN_MISSION" && guiScreen !== "GUI_SCREEN_STATUS")//CommonSenseOTB bug found deprecated != and also changed "GUI_SCREEN_SAVE" to "GUI_SCREEN_OPTIONS"

line 884 if(guiScreen !== "GUI_SCREEN_STATUS")//CommonSenseOTB bug found deprecated !=

------------------------------------------------------------------------------------



Compatibility

Works and tested with 1.74.2, 1.75.1, 1.75.2, 1.75.3
As far as I can tell it works just like it used to.
This bugfix is for compatibility purposes only.

=============================================


Pretty simple, huh? There is no reason now for anyone NOT to upgrade to oolite 1.75.3 as they can now save anywhere again.

Have fun and see you later. 8)

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 9:58 pm
by Eldon
Wonderful! I've been missing this soooo much. I'd managed to catch the s/S switch from the depreciation logs, but the rest of it is beyond me for now.

Thank you.

Re: Save Any Where OXP Version 3.1 [RELEASE]

Posted: Wed Jul 20, 2011 10:16 pm
by Ganelon
Save Anywhere not working didn't keep me from upgrading. But it was sorely missed for what it can add to character roleplay. Being able to start and end sessions from a planet surface or location other than the official main station just fits better sometimes.

I haven't upgraded to 1.75.3 yet, but I'll probably do so as soon as I get a good quiet night to spend all night in space "putting it through the paces". A quiet night, lights out, subwoofs just loud enough for a modest bit of rumble, and a new update or OXP to explore with. Now that's livin'.