Page 5 of 5
Re: Joystick sensitivity toggle
Posted: Thu Jan 16, 2014 9:36 pm
by kanthoney
Well, this seems to be just about ready. At least, I haven't anything wrong with it tonight. If I still haven't found any problems this time tomorrow I'll submit the pull request.
I've implemented the per-axis deadzone suggestion.
If you can't wait and can compile from git sources, you can clone my git repo at
https://github.com/kanthoney/oolite. It's the joystick_configurator branch you want.
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 9:01 am
by kanthoney
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 9:55 am
by Diziet Sma
This afternoon I managed to get in a couple of hours on 1.77.1. The difference, even in precision mode, without the non-linear control was amazing.. very hard to get used to the lack of fine-control.. the tiniest of nudges would move the sights far too much, from left of the target, to right of the target..
Please port this back for 1.77.2, if possible..
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 10:57 am
by kanthoney
You're looking forward to this, I can tell!
Actually, the worst thing about 1.77 is the little hop that you get coming out of the deadzone, which takes a couple of lines of code to fix. There are a couple of maintenance branches on git, though, so I don't know which one is best to supply a patch for.
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 12:05 pm
by Diziet Sma
kanthoney wrote:Actually, the worst thing about 1.77 is the little hop that you get coming out of the deadzone
You got that right.. very annoying, it is.. and if you have a fix for it, that's great!
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 6:40 pm
by cim
kanthoney wrote:Actually, the worst thing about 1.77 is the little hop that you get coming out of the deadzone, which takes a couple of lines of code to fix. There are a couple of maintenance branches on git, though, so I don't know which one is best to supply a patch for.
maintenance/1.78 is the one for the next release in that series: there probably won't be a 1.77.2 before 1.78. If you're lucky, the original fix for that was in its own commit, and it can just be cherry-picked into the branch. If not, yes, it'll need a separate patch.
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 7:28 pm
by kanthoney
Having just checked, there's no fix for this in 1.78. Would you like one?
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 7:58 pm
by cim
Yes, I think that's small enough to be considered a bug rather than a new feature, so if it's quick to do then a patch would be useful.
Re: Joystick sensitivity toggle
Posted: Fri Jan 17, 2014 8:15 pm
by kanthoney
OK, whizzed your way! Turned out to be a bit more than two lines, but still wasn't much.