21/06/2020 - Version 3.03, updated by Milo; added indication on F5F5 screen showing whether current IronHide armour is civilian or military grade.
Code: Select all
<key>mission_ironHide_cost</key>
<string>00</string>
<key>mission_ironHide_milFlag</key>
<string>100</string>
<key>mission_ironHide_percentage</key>
<string>100</string>
<key>mission_ironHide_strength</key>
<string>400</string>
Code: Select all
<key>mission_ironHide_cost</key>
<string>00</string>
<key>mission_ironHide_milFlag</key>
<string>100</string>
<key>mission_ironHide_percentage</key>
<string>100</string>
<key>mission_ironHide_strength</key>
<string>400</string>Forgot to look at that... the original save file didn't, the savefile after buying IH has it.Milo wrote: ↑Mon Jun 22, 2020 1:41 amThat's very strange, milFlag should be either zero or one, not 100, and I don't see anything that could set it to 100. The military upgrade not being offered in that case is not surprising because it requires milFlag to be zero. Did that save not have EQ_IRONHIDE in the list of equipment under <key>extra_equipment</key><dict>?
Let me know if this works, I made the assumption that SSH first assigns the new ship as the player ship and then restores the equipment.21/06/2020 - Version 3.04, updated by Milo; improved handling of invalid ironHide_milFlag missionVariable (not zero or one) from old saved game; modified allowAwardEquipment handler to allow other OXPs to add IronHide to player ships (e.g., Ship Storage Helper).
It does a replaceShip(), removes all "inherited" equips from the new ship, then tries to award what was in the stored ship, then re-instates the state (missionVariables) for several OXPs... but with EscortDeck, it's restoring NPCs too - that's what I'm working on, with EscortDeck and HyperSpaceHangar a ship can be a player ship, then be turned into a NPC (an escort), and vice-versa, and I want to preserve equipment/OXP state as much as possible as it moves from player->NPC->player.Milo wrote: ↑Mon Jun 22, 2020 1:57 amAh, I will have to allow scripted awardEquipment for that.Let me know if this works, I made the assumption that SSH first assigns the new ship as the player ship and then restores the equipment.21/06/2020 - Version 3.04, updated by Milo; improved handling of invalid ironHide_milFlag missionVariable (not zero or one) from old saved game; modified allowAwardEquipment handler to allow other OXPs to add IronHide to player ships (e.g., Ship Storage Helper).
For the player->npc->player scenario with SSH, I am still blocking awardEquipment("EQ_IRONHIDE") on non-player ships. I expect you will keep the original player equipment list during the npc transition even if some equipment can't be awarded while it is an npc ship and restore it when it becomes a player ship again?21/06/2020 - Version 3.05, updated by Milo; re-assess damage-to-armour multiplier each time the ship launches, in case another OXP replaced the player ship, awarded IronHide, or changed the grade of the armour.
Why do that?Milo wrote: ↑Mon Jun 22, 2020 2:48 amFor the player->npc->player scenario with SSH, I am still blocking awardEquipment("EQ_IRONHIDE") on non-player ships. I expect you will keep the original player equipment list during the npc transition even if some equipment can't be awarded while it is an npc ship and restore it when it becomes a player ship again?
Shield Cycler does something like that, it removes the "user-versioned" EQs (Basic, Standard, Advanced), puts in a EQ_SC_SHIELD_CYCLER_INTERNAL and controls everything from the worldScript vars. It would be much simpler if it got rid of the EQ_..._INTERNAL, right now you have to check for that AND two booleans AND the equip. version (which could be None) in the worldScript vars to see if it's enabled.Milo wrote: ↑Mon Jun 22, 2020 2:48 amThinking about it, there's no particular reason that I need the EQ_IRONHIDE equipment after the initial purchase, other than for other OXPs that look for it. I could derive everything from the ironHide_percentage and ironHide_milFlag. Less edge cases with inconsistent variables/equipment states if other OXPs are modifying them.
21/06/2020 - Version 3.06, updated by Milo; if armour percentage is above zero but EQ_IRONHIDE is missing at startUp or at launch, set percentage to zero (in case another OXP removed IronHide without changing percentage); allow other OXPs to awardEquipment("EQ_IRONHIDE") to NPC ships (e.g., Ship Storage Helper using it as a placeholder for player->npc->player transitions), but IronHide does nothing for NPC ships, so outside of scripted additions, do not allow NPC ships to spawn with IronHide armour, and do not allow awardEquipment("EQ_IRONHIDE_MIL" or "EQ_IRONHIDE_REPAIRS") on NPCs because those are used only as script triggers from the F3 purchase screen.
Since I discovered HyperSpaceHangar and EscortDeck I started to collect non-player ships that I recovered as usable derelicts.... in that collection I have now a GalCop Viper (the code for NPC vs NPC must be different than NPC vs player, because all GalCop Vipers I turned into derelicts exploded - self-destruct? - around half a minute latter), a Navy Viper, an Armoured Transport Viper, a GalTech Escort Fighter, a Manta Ray. The Vipers I found as derelicts, the others I fought and turned into derelicts.Milo wrote: ↑Sun Jun 21, 2020 8:15 pm21/06/2020 - Version 3.02, updated by Milo; doubled price variance for larger ships and applied proportional adjustment to repair costs (they were still using the baseline price); improved compatibility with ShipVersion OXP by not offering IronHide for purchase on ships that ShipVersion does not allow to use it (when ShipVersion OXP is detected, civilian IronHide is only for ships with mass 30t or higher and military IronHide is only for ships with mass 130t or higher).
).Priority AI for police (spawned as defense ships or otherwise) sets a flag oolite_flag_selfDestructAbandonedShip which causes the Priority AI to schedule a 10 second timer from shipLaunchedEscapePod to call explode() on the ship.the code for NPC vs NPC must be different than NPC vs player, because all GalCop Vipers I turned into derelicts exploded
The GalCop Viper datakey was viper-pursuit... that uses the police AI.Milo wrote: ↑Wed Jul 15, 2020 8:03 pmPriority AI for police (spawned as defense ships or otherwise) sets a flag oolite_flag_selfDestructAbandonedShip which causes the Priority AI to schedule a 10 second timer from shipLaunchedEscapePod to call explode() on the ship.the code for NPC vs NPC must be different than NPC vs player, because all GalCop Vipers I turned into derelicts exploded
I'm not sure how any of them survived to be salvaged. Maybe you have police ships that aren't using priority AI?
I didn't fight it till the pilot abandoned ship, I found it already as a derelict in one of the Devil's Triangle Anarchy systems (Raleen, G1) same as the Navy Viper.
Code: Select all
"commsPackA_vigilante_beginningFight" = ("Your crimes end here!","Death to pirates!","It's the [oolite_entityName]. Open fire!","You'll pay for your crimes, [oolite_entityCrew]!","It's time to clean up %H…","Confirmed on the [oolite_entityClass]; wanted dead or alive in [commsPackA_number] systems…","Pick your targets and break to attack!","Offender targets acquired…");