For information and discussion about Oolite.
https://bb.oolite.space/
I'm suspecting something like this. Could it depend on the OS? Have to windows install somewhere and test. I'm so out of my league hereWildeblood wrote:I wonder... (ignore what follows, it's just me thinking out loud)... is it because gatherMarketValues (?) is writing the array and printValues is reading the array at the same time...?
.There's something strange going on when switching to market screen. Wierdest thing is that it behaves just ok in my installation, except that 'var j' bug that Wildeblood noted of course (I'm using Linux, that might have something to do with it). Wildeblood's note about array-handling makes sense, I wasn't thinking in objects when I should have, instead procedurally. I have passed a test version (changes in object and array handling) to Solonar, let's see if that solves something.JeX wrote:I can also confirm that the "stuck HUD" persists on MarketObserver 1.6.1 with the newest AI trading assistant installed (not sure this is what affects it as the stuck HUD has occurred before I played with AI T assistant).
It was reproducable simply by reloading a game, then pressing F8 and then F4.
Also, it takes a long while to actually get to the market screen after pressing F8 (at least 1-2 seconds), while with only AI trading assistant the lag was unnoticeable.
Thanks a lot for helping and reporting.I wouldn't go as far as saying a second or two, but there's a definite 1/2 second or so lag here. The lag is longer with marketObserver on its own than with both OXPs together, so I assume it's caused by loading the images for the adverts. Anyway, this one fixes all the problems for me:JeX wrote:Also, it takes a long while to actually get to the market screen after pressing F8 (at least 1-2 seconds), while with only AI trading assistant the lag was unnoticeable.
. It's a shame as I really liked them. Maybe I'll release two versions of the oxp. One with the ads and one without. Glad Wildeblood has already done a hud for me to use 
.
The end it adds to.Wildeblood wrote:What's the difference between unshift and push?
Code: Select all
arr = [1,2,3,4];
arr.push(5); // arr = [1,2,3,4,5];
arr.unshift(0); // arr = [0,1,2,3,4,5];
Okay (?), what's the difference between shift and push then?cim wrote:The end it adds to.Wildeblood wrote:What's the difference between unshift and push?Code: Select all
arr = [1,2,3,4]; arr.push(5); // arr = [1,2,3,4,5]; arr.unshift(0); // arr = [0,1,2,3,4,5];
Wildeblood wrote:Okay (?), what's the difference between shift and push then?cim wrote:The end it adds to.Wildeblood wrote:What's the difference between unshift and push?Code: Select all
arr = [1,2,3,4]; arr.push(5); // arr = [1,2,3,4,5]; arr.unshift(0); // arr = [0,1,2,3,4,5];
Code: Select all
arr = [1,2,3,4];
arr.push(5); // arr = [1,2,3,4,5];
arr.unshift(0); // arr = [0,1,2,3,4,5];
v = arr.shift(); // arr = [1,2,3,4,5]; v = 0;
v = arr.pop(); // arr = [1,2,3,4]; v = 5;
Sorry? We must be having a communication problem. Are you talking of playerSoldCargo -function?Wildeblood wrote:Bloody Spara! I've just looked at it again and realized the reason I couldn't understand how it works is because his in-line comments explaining how it works are wrong.
*<shivers>*Wildeblood wrote:Bloody Spara! I've just looked at it again and realized the reason I couldn't understand how it works is because his in-line comments explaining how it works are wrong.
oh oh...
Code: Select all
while(unitCount > 0 && this.$buyLog[commIndex].length > 0) { //purge buys from log
currentElement = this.$buyLog[commIndex].shift();
if (currentElement[0] > unitCount) { //enough purchases in one log entry
if (this.$traderRankFeat)
this.$profit = this.$profit + unitCount * (price - currentElement[1]);
currentElement[0] = currentElement[0] - unitCount;
this.$buyLog[commIndex].unshift(currentElement);
unitCount = 0;
}
else { //not enough puchases in one log entry
if (this.$traderRankFeat)
this.$profit = this.$profit + currentElement[0] * (price - currentElement[1]);
unitCount = unitCount - currentElement[0];
}
}Code: Select all
this.$sortPurchaseBook = function()
{
function descendingSort(a,b) {return b[1] - a[1]}
for (var i = 0; i < this.$purchaseBook.length; i++)
{
if (this.$purchaseBook[i].length > 1)
{
this.$purchaseBook[i].sort(descendingSort);
}
}
}Wildeblood wrote:That first comment, "enough purchases in one log entry":-
...
It should say, "More than enough purchases in one log entry."
Perfectly clear to me. But I can quite understand someone else has hard time understanding it.
I have used sort function in Trophy Collector, where it was straightforward ordering by the first element of array in array. I seem to have missed the sortfunction parameter. Looks quite handy. It looks so handy, that I'll have to rewrite the ordering function. Thanks for the tip.Wildeblood wrote:Anyway, on a more useful note, javascxript includes a handy array sorting function you seem to be unaware of:-Code: Select all
this.$sortPurchaseBook = function() { function descendingSort(a,b) {return b[1] - a[1]} for (var i = 0; i < this.$purchaseBook.length; i++) { if (this.$purchaseBook[i].length > 1) { this.$purchaseBook[i].sort(descendingSort); } } }
.