(NEW RELEASE)MilitaryTargettingSystemv1.oxp for 1.76+

[Rese249er]

I've noticed an odd interaction between this OXP and the BETA Cargo Spotter OXP. When Cargo Spotter is active, the salvage targeting simply doesn't work. No idea why; maybe you can hash it out?

It annoys me because the CargoSpotter doesn't light up bright enough for me to see the cargo, unless I'm extremely close range.

[CommonSenseOTB]

I've noticed an odd interaction between this OXP and the BETA Cargo Spotter OXP. When Cargo Spotter is active, the salvage targeting simply doesn't work. No idea why; maybe you can hash it out?

It annoys me because the CargoSpotter doesn't light up bright enough for me to see the cargo, unless I'm extremely close range.

Not sure about that one. The next version will have something (similar? ) for all target types built into it...probably...I'll have a look at the code for cargo spotter again and see if I can spot anything.

[Diziet Sma]

Running 1.77 the following appears in my logs now and then:

Code: Select all

9:51:00.897 [script.javaScript.exception.notFunction]: ***** JavaScript exception (<unidentified script>): TypeError: entity.hasRole is not a function
09:51:00.897 [script.javaScript.exception.notFunction]:       AddOns/MilitaryTargettingSystemv1.oxp/Scripts/militarytargettingsystem.js, line 80.
09:51:27.358 [script.javaScript.exception.notFunction]: ***** JavaScript exception (<unidentified script>): TypeError: entity.hasRole is not a function
09:51:27.358 [script.javaScript.exception.notFunction]:       AddOns/MilitaryTargettingSystemv1.oxp/Scripts/militarytargettingsystem.js, line 104.
09:51:33.594 [script.javaScript.exception.notFunction]: ***** JavaScript exception (<unidentified script>): TypeError: entity.hasRole is not a function
09:51:33.594 [script.javaScript.exception.notFunction]:       AddOns/MilitaryTargettingSystemv1.oxp/Scripts/militarytargettingsystem.js, line 80.

[JazHaz]

When I get destroyed in combat, I keep getting this message appearing on my debug console:

Code: Select all

Warning: removeFrameCallback(): invalid tracking ID.
    Active script: militarytargettingsystem 1.0
    militarytargettingsystem.js, line 177:
       removeFrameCallback(this.mtesnt2);//----------

It also appears in my log:

Code: Select all

14:04:53.164 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (militarytargettingsystem 1.0): removeFrameCallback(): invalid tracking ID.
14:04:53.164 [script.javaScript.stackTrace]:  0 (militarytargettingsystem.js:177) <anonymous function>
14:04:53.164 [script.javaScript.stackTrace]:     this: [Script "militarytargettingsystem" version 1.0]

When this happened just now, I didn't have the MTS installed in my bounty hunter's cobra (yet). I do have it in my trader commander.

Edit: this is the JS script where the error is occurring:

Code: Select all

this.shipDied = function()
   {
   removeFrameCallback(this.mtesnt);//----------
   removeFrameCallback(this.mtesnt2);//----------
   }

The second removeFrameCallback is line 177. Looks fine to me though. CommonSense has not been on the BBS since February though. Can anyone suggest a fix?

[Commander McLane]

Edit: this is the JS script where the error is occurring:

Code: Select all

this.shipDied = function()
   {
   removeFrameCallback(this.mtesnt);//----------
   removeFrameCallback(this.mtesnt2);//----------
   }

The second removeFrameCallback is line 177. Looks fine to me though.

How fine it is depends entirely on the value of this.mtesnt2 at the time of executing the command. Obviously the variable doesn't contain the value it's supposed to. This can have a variety of reasons. For instance, the variable may not have been created properly previously. For instance, there could be a typo in the place where it's created. Or the variable is deleted before line 177 is reached.

[Tricky]

When I get destroyed in combat, I keep getting this message appearing on my debug console:

Code: Select all

Warning: removeFrameCallback(): invalid tracking ID.
    Active script: militarytargettingsystem 1.0
    militarytargettingsystem.js, line 177:
       removeFrameCallback(this.mtesnt2);//----------

It also appears in my log:

Code: Select all

14:04:53.164 [script.javaScript.warning.ooliteDefined]: ----- JavaScript warning (militarytargettingsystem 1.0): removeFrameCallback(): invalid tracking ID.
14:04:53.164 [script.javaScript.stackTrace]:  0 (militarytargettingsystem.js:177) <anonymous function>
14:04:53.164 [script.javaScript.stackTrace]:     this: [Script "militarytargettingsystem" version 1.0]

When this happened just now, I didn't have the MTS installed in my bounty hunter's cobra (yet). I do have it in my trader commander.

Edit: this is the JS script where the error is occurring:

Code: Select all

this.shipDied = function()
   {
   removeFrameCallback(this.mtesnt);//----------
   removeFrameCallback(this.mtesnt2);//----------
   }

The second removeFrameCallback is line 177. Looks fine to me though. CommonSense has not been on the BBS since February though. Can anyone suggest a fix?

I changed the script to this...

Code: Select all

this.shipTargetLost = function (target) {
    if (target && target.isValid && this.mtelasttarget && this.mtelasttarget.isValid) {
        this.mtelasttarget.scannerDisplayColor1 = this.mtelasttargetscannerdisplay1;
        this.mtelasttarget.scannerDisplayColor2 = this.mtelasttargetscannerdisplay2;
    }
}

this.shipDied = function () {
    if (isValidFrameCallback(this.mtesnt)) {
        removeFrameCallback(this.mtesnt);
    } //----------
    if (isValidFrameCallback(this.mtesnt2)) {
        removeFrameCallback(this.mtesnt2);
    } //----------
}

[Digital86]

The device found a Escape Pod.
But she invisible, on a radar too it isn't visible.
It is impossible to catch in cargo
It is impossible to shoot

[Diziet Sma]

The device found a Escape Pod.
But she invisible, on a radar too it isn't visible.
It is impossible to catch in cargo
It is impossible to shoot

That's a known bug with the  Escape Pod Locator. It's survived many attempts to track it down and kill it. You can read all about it here:
https://bb.oolite.space/viewtopic.ph ... 62#p190862

Edit:
I've made a test-patch for the Escape Pod Locator, based on a suggestion by cim. The download link is in the above thread.

[Cholmondely]

Wiki page now up: Military Targeting System

I'm just not capable of including the ttypo in the wiki page title!

[Cmdr Wyvern]

CSOTB sure had a knack for making Oolite do magic it wasn't ready for, back in the day. (Many of his HUDs still look epic)

This oxp would be sorely showing it's age by now. There's newer oxps,

Telescope,
Target Filtering,
Target System Plugins,

come to mind, that does what this does and then some.