For information and discussion about Oolite.
https://bb.oolite.space/
If there are a few examples on the wiki of how things should be done, I'm pretty sure that some of us won't mind taking these new things and adding them to the wiki.Kaks wrote:The difference in hassle is not that big, and I don't really mind adding a new page to the wiki. It needs to be done at some point or other, so we might as well do it to begin with anyway.
I do mind writing documentation in general, though!
Kaks wrote:You mean something like this?Hmmm, it's not on the wiki yet.Code: Select all
system.info.distanceToSystem(System.infoForSystem(0, 55));
Code: Select all
system.info.distanceToSystem(system.infoForSystem(galaxyNumber, 55))Code: Select all
this.addSpaceBarToSystem = function () {
function systemIsAllowed() {
var notAllowed = [46];
if (notAllowed.indexOf(system.ID) > -1) {
return false;
}
return true;
}
function spacebarNumber(systemID) {
var spacebars = [ // 20 systems per row
1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 2, 3, 3, 3, 3, 3, 3, 4, 4,
4, 4, 4, 4, 5, 5, 5, 5, 5, 5, 6, 6, 6, 6, 6, 6, 7, 7, 7, 7,
7, 7, 40, 40, 40, 40, 40, 8, 8, 8, 8, 8, 8, 9, 9, 9, 9, 9, 9, 10,
10, 10, 10, 10, 10, 11, 11, 11, 11, 11, 11, 12, 12, 12, 12, 12, 12, 13, 13, 13,
13, 13, 13, 14, 14, 14, 14, 14, 14, 15, 15, 15, 15, 15, 15, 16, 16, 16, 16, 16,
16, 17, 17, 17, 17, 17, 17, 18, 18, 18, 18, 18, 18, 19, 19, 19, 19, 19, 19, 20,
20, 20, 20, 20, 20, 20, 21, 21, 21, 21, 21, 21, 21, 22, 22, 22, 22, 22, 22, 22,
23, 23, 23, 23, 23, 23, 23, 24, 24, 24, 24, 24, 24, 24, 25, 25, 25, 25, 25, 25,
25, 26, 26, 26, 26, 26, 26, 26, 27, 27, 27, 27, 27, 27, 27, 28, 28, 28, 28, 28,
28, 28, 29, 29, 29, 29, 29, 29, 29, 30, 30, 30, 30, 30, 30, 30, 31, 31, 31, 31,
31, 31, 31, 32, 32, 32, 32, 32, 32, 32, 33, 33, 33, 33, 33, 33, 33, 34, 34, 34,
34, 34, 34, 34, 35, 35, 35, 35, 35, 35, 35, 36, 36, 36, 36, 36, 36, 36, 37, 37,
37, 37, 37, 37, 37, 38, 38, 38, 38, 38, 38, 38, 39, 39, 39, 39
];
return spacebars[systemID];
}
function addSpacebar(type) {
var coords = [
[-41190, 33291, 240408],
[-5106, 5174, 388275],
[12644, 13830, 353962],
[25774, -10946, 314064],
[-48509, -9524, 266555]
],
coordIndex = [1, 2, 3, 4, 0, 1, 2, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 1,
2, 3, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 1, 2, 3, 4, 0, 3],
position = coords[coordIndex[type - 1]];
missionVariables.random_hits_seedy_spacebar_name = '[random_hits_barname' + type + ']';
system.addShipsAtPrecisely('random_hits_spacebar' + type, 1, 'pwm', position);
missionVariables.random_hits_spacebar_position = position;
system.addShipsWithinRadius('random_hits_griff_autominer', '[random_hits_rocks_number]', 'pwm', position, 15000);
system.addShipsWithinRadius('asteroid', '[random_hits_rocks_number2]', 'pwm', position, 25000);
system.addShipsWithinRadius('random_hits_minesweeper', 1, 'pwm', position, 4000);
}
if (system.countShipsWithRole('random_hits_spacebar1') === 0) {
if (system.government === 0 && systemIsAllowed()) {
addSpacebar(spacebarNumber(system.ID));
if (missionVariables.random_hits_seedy_spacebar_name === null && !system.isInterstellarSpace) {
addSpacebar(17);
}
}
}
};That's not a variable, but an entry in descriptions.plist (and yes, Random Hits uses a lot of those for the randomized descriptions).pmw57 wrote:The property list uses variables such as [random_hits_rocks_number2].
That's a good idea. I take it that there are situations where keeping the names in the descriptions.plists file is more appropriate (for data separation and internationalisation) in which case reading them in when the script starts, into a script-based array would be an appropriate solution.Kaks wrote:pmw57, I would seriously consider internalising those descriptions.plist arrays as js arrays and pick a random adjective/name from those.
Whenever any description from descriptions.plist is accessed, oolite has to go through a dictionary (obj-c speak for associative array) made up of the sum of all the descriptions.plists for all oxps put together, which isn't exactly the most efficient way of doing things, but was the only available option using legacy script...
Okay, so for now I will cache the desired descriptions when the script loads, to help avoid any cross-use issues.Kaks wrote:One situation I can think of is if an AI.plist needs to access a string. In that case, we definitely want to keep the original string inside descriptions.plist...
Er, what exactly is this intended to achieve? JavaScript’s Math.random() is not affected by Oolite’s random seed resets. Math.random() doesn’t seem to be an especially good PRNG (although better than either of Oolite’s), but “stirring” it like this shouldn’t give you an appreciably “more random” result.pmw57 wrote:Code: Select all
Instead of bickering, here is a better way to seed a random number based on the time. [code]this.ReserveDutySystemDetermination = function() { var sec = clock.minutesComponent * 60 + clock.secondsComponent, dummy; for (var i = 0 ; i < sec ; i++) { dummy = Math.random(); } this.ReserveDutySystemDeterminationPt2(); }
You're right. It's not not the best way, it's just a better way than what was being done before.Ahruman wrote:Er, what exactly is this intended to achieve? JavaScript’s Math.random() is not affected by Oolite’s random seed resets. Math.random() doesn’t seem to be an especially good PRNG (although better than either of Oolite’s), but “stirring” it like this shouldn’t give you an appreciably “more random” result.pmw57 wrote:Code: Select all
Instead of bickering, here is a better way to seed a random number based on the time. [code]this.ReserveDutySystemDetermination = function() { var sec = clock.minutesComponent * 60 + clock.secondsComponent, dummy; for (var i = 0 ; i < sec ; i++) { dummy = Math.random(); } this.ReserveDutySystemDeterminationPt2(); }
You're right. It's not not the best way, it's just a better way than what was being done before.pmw57 wrote:Er, what exactly is this intended to achieve? JavaScript’s Math.random() is not affected by Oolite’s random seed resets. Math.random() doesn’t seem to be an especially good PRNG (although better than either of Oolite’s), but “stirring” it like this shouldn’t give you an appreciably “more random” result.
How do you do that? I'd like to do the same withe the descriptions.plist I use for personalities.oxp, but don't know how to.pmw57 wrote:Okay, so for now I will cache the desired descriptions when the script loads, to help avoid any cross-use issues.Kaks wrote:One situation I can think of is if an AI.plist needs to access a string. In that case, we definitely want to keep the original string inside descriptions.plist...