Oolite Bulletins

Screet wrote:

Thus, should your much more readable code still have the old tendency of selecting the same systems, maybe it's enough to simply request n times (for n seconds) a random number before running that code - and I'd guess that the next version of GalNavy would then come with a shorter and better script

pmw57 wrote:

What's this about random numbers? The existing code from the OXP (Galactic Navy 5.0) doesn't use random numbers for ReserveDutySystemDetermination

It only uses galaxy and system.ID for one description per system. The same description per system.

Screet wrote:

Code: Select all

this.ReserveDutySystemDetermination = function()
{
	var sec = clock.secondsComponent;
	for(var i = 0 ; i <= sec ; i++) {
		this.ReserveDutySystemDeterminationPt2();
	}
}

this.ReserveDutySystemDeterminationPt2 = function()
{

this.ReserveDutySystemDetermination = function()
{
	var sec = clock.minutesComponent * 60 + clock.secondsComponent,
		dummy;
	for (var i = 0 ; i < sec ; i++) {
		dummy = Math.random();
	}
	this.ReserveDutySystemDeterminationPt2();
}

sec = sec % 1000;

Svengali wrote:

It seems you haven't took a look at all in RH, then you'd know that LB has scripted it in XML, not in JS (only the ship-scripts are JS).

Screet wrote:

Add the log line and give the modified version from me a try...

Kaks wrote:

About modernising older OXPs: pmw57, what about converting Taranis?

Provided you contact the original oxp maker and they give you the go-ahead, I'm sure there won't be any problem with you converting that to js. Plus the Taranis HQ could really do with some shader update, instead of using flashers!

LittleBear wrote:

If I was starting it now I'd have written in JS, but I haven't got the heart (or the time really) to translate the legacy script to a JS one. Its just too darn big, so when I have the time to finishs it, it'll just have to be left in legacy as it would be too time consuming (and would probabley break stuff) to re-write it. Its like the old joke: "Q: How do I get to Dublin?", "A: Well I woudn't start from here."

LittleBear wrote:

Yeah sure, if you want to convert it. I've put comments in the script so you can see what each bit is meant to be doing, but its a real looooong script!

I don't think there'd be a way for Ooolite to know that a system it picked at random from all 255 systems in the current Galaxy (rather than picking a system at random from a pre-set list) is one that the player cannot actually reach.

I'd checked this with another commander before resorting to lists and there is not a mathmetical relationship between planetnumbers that can be used to calaculate distance between two systems or the position of a given system, only between the co-ordinates of two system, which I don't think is accessable with an OXP script.

pmw57 wrote:

So was OSE but most of that was duplicate repeating structures that were easily brought down to size.

When I separate bits that change from the bits that don't (there's a fancy name for that somewhere) the code will be a lot smaller, and easier to follow.

pmw57 wrote:

It would be nice if there was a systemDistance(targetID [, sourceID]) which returned false (or -1) for not reachable.

Hmm, maybe that should be a scripting request for the developers.

system.info.distanceToSystem(System.infoForSystem(0, 55));

Kaks wrote:

You might want to have a look at the Progress thread. It's a goldmine of information not yet ported to the wiki, like this post!