Oolite Bulletins

LittleBear wrote:

Eric has pointed out the first one. Although I switch the escorts AI with the script to the custom AI (which checks for friendly fire). As it takes a few seconds to run, it is possible that the escorts are in bog-standard escort AI when they get hit by the mark, so I really need to add an auto-ai false. It shouldn't happen very often, but it is a known bug.

LittleBear wrote:

On the Second one. Is the variable for revenge : YES ? The counter still counts even if the variable is NO, but nothing will happen. I reduced the chance of revenge being taken to 1 in 3 everytime you make a hit, so it will be less frequent. The dice should be re-rolled when you are paid for making a hit. I might have forgotten though to reset the YES / NO roll. Could you pull into a bar and post your variables with a screenie? I pretty busy with RL ATM so may be a while before I can look into it though.

Screet wrote:

LittleBear wrote:

Eric has pointed out the first one. Although I switch the escorts AI with the script to the custom AI (which checks for friendly fire). As it takes a few seconds to run, it is possible that the escorts are in bog-standard escort AI when they get hit by the mark, so I really need to add an auto-ai false. It shouldn't happen very often, but it is a known bug.

LittleBear wrote:

There's somthing up as the code should force a revenge encounter if you go over a certain number without an enounter. Bother - I have broken something in the new release.

Screet wrote:

Furthermore, I just got this after a space bar has been blown up by a q-bomb:

If I understand things properly, the script should better be written as this:

Code: Select all

this.shipDied  = function(whom)
{
  	if(whom && whom.primaryRole == "player") { 
		player.bounty += (Math.ceil(Math.random()*25));			
	}
}

Screet

this.shipDied  = function(whom)
{
  	if(whom && whom.isPlayer) { 
		player.bounty += (Math.ceil(Math.random()*25));			
	}
}

Screet wrote:

If I understand things properly, the script should better be written as this:

Code: Select all

this.shipDied  = function(whom)
{
  	if(whom && whom.primaryRole == "player") { 
		player.bounty += (Math.ceil(Math.random()*25));			
	}
}

Screet

• Only one space each side of the equals sign.
• A space between function and parenthesis, because here we are not calling a function, just defining one.
• Follow the parenthesis with a space and the opening brace.

this.shipDied = function (whom) {

• A mix of spaces and tabs is not good for indenting. Either use 4 spaces, or a single tab. Due to widely varying environments, the standard we should use is 4 spaces.
• Leave a space between the if keyword and the parenthesis, as this is not a function that is being called.
• Always compare using the strict equality operators. The standard equality operators use a complicated set of rules to determine equality, which allows too many strange situations to occur.
• I will not bicker about quotes. The standard is single quotes when scripting for web pages (to prevent confusion) but here I am okay with double quotes.

	if (whom && whom.primaryRole === "player") {

• The outer parenthesis are not required, nor do they aid in understanding the code.
• Leave a space either side of operators, the asterix. This aids the readability of the code when things get complex.
• Lots of whitespace at the end of the statement is removed
• Many scripts fail to complete their statements with semicolons. Without, the statement may not end depending on what follows after it, so use the semicolons. Like fullstops in writing, they serve a purpose.

		player.bounty += Math.ceil(Math.random() * 25);

• This line is okay as it is, leave it lined up underneath the if statement

	}

• This brace closes the definition for the this.shipDied function, so it should be properly finished with a semicolon.

};

this.shipDied = function (whom) {
	if (whom && whom.primaryRole === "player") {
		player.bounty += Math.ceil(Math.random() * 25);
	}
};

Eric Walch wrote:

Yes, with q-bombs the whom is always nil so you need to be check for whom first.

Micha wrote:

Eric Walch wrote:

Yes, with q-bombs the whom is always nil so you need to be check for whom first.

I wonder if this should be considered as a bug in Oolite, and fixed. I guess the problem is that the Q-Bomb no longer exists. Should it be whoever dropped the q-bomb then? What if they are dead by now as well?

What happens in other situations when 'whom' is dead by the time this event is fired? Eg, missiles?

this.shipDied = function (whom, why) 
{ 
    log(this.name, "Whom = " + whom + " Why = "+why);
}

Whom = [PlayerShip "Boa Class Cruiser" ID: 100 position: (-51138.8, -98190.2, 531325) scanClass: CLASS_PLAYER status: STATUS_IN_FLIGHT] Why = removed

Commander McLane wrote:

But still the kills through secondary blasts are awarded to the player, if he launched the first q-bomb, aren't they?

So how does the code determine the connection between the secondary kills and the player? There must be something in the code already. (Unless, of course, my assumption is wrong, and secondary kills are not awarded. However, a certain experience with the Tionisla Orbital Graveyard seems to tell me otherwise, ahem...)