Page 3 of 5

Re: [UPDATE] LongRangeScanner

Posted: Mon Feb 14, 2011 2:51 pm
by gizmo
Okti wrote:
Hi All,
There is a new new equipment for Long Range Scanner called Jump Planner.
This equipment allows you to break 7 LY limit for destination system.
How is that supposed to work?
The only effect for me (running trunk) is a dropping of the TAF to 0.06.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 4:21 pm
by Okti
Hi Gizmo,


If you buy the jump planner, on top of LongRangeScanner, When you use F6-F6 to display the Galactic Map choose a system out of 7 LY's. then press F5 to display longrangescanner menu. You must see an option to display "Display Target System Info". Select that and another menu must be displayed.

You have the option to make cheat jumps to the selected system.

If it does not work could you please look for scripting errors on your latest.log and inform me if you can find any.

Okti

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 4:24 pm
by gizmo
Okti wrote:
When you use F6-F6 to display the Galactic Map choose a system out of 7 LY's. then press F5 to display longrangescanner menu. You must see an option to display "Display Target System Info". Select that and another menu must be displayed.
You have the option to make cheat jumps to the selected system.
that's excatly what I've done ...

I'll have a look at the logs and keep you updated.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 4:57 pm
by gizmo
Excerpt from the log:

Code: Select all

[script.javaScript.warning.ooliteDefinedError]: ----- JavaScript warning (LongRangeScanner 0.1): Incorrect usage: System instance property “info” accessed on constructor instead of instance. Replace “System.info” with “system.info”. This warning will be removed and the script will fail in Oolite 1.75.1.
[script.javaScript.warning.ooliteDefinedError]: ----- JavaScript warning (LongRangeScanner 0.1): Incorrect usage: System instance property “info” accessed on constructor instead of instance. Replace “System.info” with “system.info”. This warning will be removed and the script will fail in Oolite 1.75.1.
[script.javaScript.exception.unexpectedType]: ***** JavaScript exception (LongRangeScanner 0.1): TypeError: ships is null
[script.javaScript.exception.unexpectedType]:       /home/or/.Oolite/AddOns/LongRangeScanner v0.1.oxp/Config/script.js, line 47.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 5:26 pm
by Okti
Hi Gizmo,

I Uploaded a new version here

This is developed under trunk version 1.75.0.4324.


If you still experience the same problem please let me know. Also I am using windows Vista. and I wonder if it is operating system or not.

Okti

Edit: This version only works with trunk 1.75.0 and above and the equipment can be primed by shift N and activated by n.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 5:45 pm
by gizmo
Version 0.2 works (and no more compatibility errors in the log).

BTW: I'm running Oolite on top of Linux but that really shouldn't make any difference.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 5:54 pm
by Okti
Hi gizmo,

I am glad it works fine now. But I discovered a bug in 1.75.0.4324 about missionScreenEnded
event is not raised.

Can you please confirm me by pressing F6-F6 and then F5 to display the lr menu and select one of the options and then press F1 for forward view. If the TAF is not set to 1 than there must be bug in Ooolite. I have already reported that bug. But I may be wrong.

Okti

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 6:01 pm
by gizmo
Bug confirmed for trunk version 4341.
The bug only happens when exiting the menu without selecting any further action.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 6:11 pm
by Okti
Hi gizmo,

Apart from the bugs in oolite, did you find the new equipment usefull?

You can make a fortune on long range contracts. :lol:


Okti

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 6:15 pm
by gizmo
I simply installed the LRS update to see if it works. I yet have to find a reason to use it as I normally don't do any contracts - the cargo bay is always full of "bounty hunting leftovers" :mrgreen:

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 6:17 pm
by Eric Walch
Okti wrote:
But I discovered a bug in 1.75.0.4324 about missionScreenEnded event is not raised.
I don't think this is a bug. The main use of the missionScreenEnded was to signal other oxps that they can set up a page of their own. However, before 1.74 it was forbidden to create a mission screen when not docked. Therefor it was deliberate that the missionScreenEnded did not fire when flying to prevent other oxp to set up a page for their own when in flight. I wasn't even aware that we had mission screens in flight until I saw your oxp. It has probably changed with the new 1.74 mission screen code.

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 6:35 pm
by Okti
Hi Eric,

Thargoids Vortex OXP is using the same handler. Which I borrowed the code from as well as the licence file :D .

Okti

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 7:32 pm
by JensAyton
To reinforce what Eric said, missionScreenEnded() shouldn’t be used in new development. Use missionScreenOpportunity() to show new screens, and mission.runScreen() completion callbacks to handle the end of a screen. (To show a sequence of screens, start a new screen in the runScreen() callback.)

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 7:39 pm
by Okti
Hi Ahruman,

Is that true for mission screens displayed during flight?

Okti

Re: [RELEASE] LongRangeScanner

Posted: Mon Feb 14, 2011 7:57 pm
by JensAyton
Okti wrote:
Is that true for mission screens displayed during flight?
The stuff about runScreen() should be. missionScreenOpportunity() won’t fire in flight.

…so, in fact, there’s no way to defer an in-flight mission screen while another one is in effect, other than starting a timer and polling guiScreen. *peers over his spectacles at the person who hacked in in-flight mission screens*