matt634 wrote:First, you have copied every single texture, model, image, etc... from the original OXP and set it up in a way that you're OXP loads last. Which means that if another author ever makes any change what so ever to any one of the 90 OXPs you've included, and a player downloads the new OXP, your OXP will override the changes and the player will see nothing new. I have this same problem on a much smaller scale with my own OXP that I need to correct.
This particular problem is what the
new override plists in 1.72 are intended for. Of course, in order to be useful, they must be adopted by OXPers who take the time to understand their ramifications.
matt634 wrote:You have given multiple ships like the ringhals and sidewinder the role scavenger even though they don't have fuel scoops. This means when they launch to scoop something... well I don't what will happen :(
Off the top of my head, I believe that they’ll fail to enter the approach-to-scoop AI state, and just fly around scanning for stuff. They won’t clean up debris and they won’t return to base unless something else clears it all out.
matt634 wrote:I am concerned with this newest idea to change the roles originally assigned by the authors which you obviously don't understand. My advice would be to leave them alone or include a disclaimer.
I agree, apart from the disclaimer bit.
Lestradae, I generally avoid commenting on the content of OXPs, but the large numbers of subtle bugs you’re introducing by randomly messing around with roles is going to break the game in complicated ways, and most users will assume it’s the game’s fault. I thought the idea of the OXP was to make the game feel more realistic – the hint’s in the name – and assigning carriers as freighter escorts or Leviathans as shuttles does not mesh with that goal.
Lestradae wrote:That`s true, and if someone actually reads the text about this OXP to which I have devoted a wiki-page, they will find a reminder saying: …
One of the core rules of software design is: Users Do Not Read Documentation. Whenever you assume that something won’t be a problem because it’s in the manual or Read Me file, you’re doing it wrong.
Lestradae wrote:The only one potential problem you found is if someone goes actually looking if scavenging ships really scoop their loot. Who who just plays this game is ever going to do that?
I did.
One of Oolite’s major “selling points” is that life goes on as normal around you. Among other things, this means that if something breaks or dumps cargo near the station, scavengers pop out, clean it up and go back to the station. This makes sense.
After your messing about, what happens is that something breaks or dumps cargo near the station, ships immediately launch from the station and wander around randomly until they crash with something or fly off randomly into space, and the rubbish is left floating around. This does not make sense, so what’s the point of assigning the scavenger role to the wrong ships?
Lestradae wrote:2. It adds in actually all ship oxps that contain playable ships for convenience but five (which contain more than "just" additional ships AND some are still worked on by their authors, which is why they are not in). Result: No cluttered AddOns folder, no downloading 85 oxps. Just the one and loads of new ships to buy in one go.
This assumes that everyone wants to have all the playable ships at the same time. I strongly doubt this, especially since many – probably most – Oolite players play on low-end systems. In fact, before Realistic Shipyards, the only person I ever saw suggesting the idea of using all the ship OXPs at once was you, and numerous people expressed surprise that anyone would do that.
Lestradae wrote:3. As there are many more ships to take from, so the basic roles (trader, pirate, hunter, wingman, police, sunskimmer etc.) are distributed more broadly. So you meet, as someone formulated it, "old friends in new roles". That`s WANTED.
That would make perfect sense, if it was implemented by someone who understood the role system and carefully considered which ship to put in which roles. If it was done properly, though, I’d expect relatively few ships to have their role changed, because the original authors already considered which roles their ships suited.
Lestradae wrote:I assumed that Oolite`s role system basically works as intended.
It works exactly as intended. You have amply demonstrated that you do not understand the intention.
Lestradae wrote:Concerning the police ships there might (note, might, as in could be) one or the other hiccup due to the scan_class / role of police being reworked by Ahruman as we speak.
This reworking is happening only in your imagination.
In the test releases, since at least 1.69, police are identified by scan class. In future versions, they will be identified by scan class. In previous versions, they were sometimes identified by role and sometimes by scan class with no clear distinction between the cases. That was a bug.
Lestradae wrote:If you have some specific criticism that doesn`t just have fluffy insinuations in it but says something concrete, I will go to great length of responding to it, thinking about it, taking it aboard completely or partially if I find that criticism has merit and will change things accordingly.
matt634’s criticisms were concrete, precise and entirely correct.
Lestradae wrote:And if someone should again find the nerve to publicly insult me here on the forum, well after I was told that the moderators are too "friendly" to step in at such behaviour and hope for self-regulation in such matters, I would in the future respond accordingly and build on the hope that they will be equally friendly with me if I answer on the same level.
Matt, concerning the nature of my answers, there is a simple rule to gauge my reaction for the future: You reap what you sow.
I forget & forgive destructiveness the moment someone (anyone!) comes up with something constructive anyways, and be it to show me concrete, factual (!) problems with something I do.
Valid, constructive criticism is tolerated and welcome on this board. Threats are another matter.
Lestradae, your mistakes are not a problem. The can be corrected, with the help of the community. However, your defensive and arrogant attitude
is a problem. I suggest you adjust it.
(easy to do by sticking some blue and red flashers on as sub-entries to the cop version).