Oolite Bulletins

spara wrote:

Ok. Tested this quite a bit tonight. Got to the point where rats got seriously itchy. I was a bit amused that my Commander with 18 kills under belt and flying an Adder required 10 pirates to stop from making some in-system trading . Maybe some scaling of the number of foes would be in order? Anyway, I had no trouble injecting my way through and off I was to a nearby Kiota station to get some radioactives (BlOomberg and extra stations makes a nice moneymaking machine ). When I got back, police had done it's job and there were tons of cargo canisters to loot. Docked, sold my cargo, fueled and off I go to get more radioactives and there's 10 new pirates waiting again! Injected through... and so on . I think this pirate part of this oxp needs some serious work to make it usable.

I really like the changing markets part (including the equipment). The friends part and the comms messages give some nice color as long as they don't get too repetitive and frequent (it happens easily, if the texts are too few and too 'special' and always trigger at the same point). The pirate part in my opinion does not work as visioned. Some randomization / scaling would be in order. And something needs to be done about that furball triggering every time I launch, it does not feel right. Ambush somewhere else? Maybe some special pirates?

Hope this helps to develop this oxp further, I see great potential in it.

Dr.Tripsa wrote:

I blame you for my lack of a social life, Spara. Just kidding!

Dr.Tripsa wrote:

Fixed as well is a bug that could change prices on you WHILE docked.

spara wrote:

]I can see that you have gone through some effort to prevent the prices from changing while docked, but can't really see the reason for it. Except maybe some caution not to break other oxps. If you let the prices change while not in the market screen, it probably should not cause any trouble. It would make sense that the prices might change while fueling or doing something that passes the time.

Looking forward to test the latest version later today. Keep up the good work.

Dr.Tripsa wrote:

spara wrote:

]I can see that you have gone through some effort to prevent the prices from changing while docked, but can't really see the reason for it. Except maybe some caution not to break other oxps. If you let the prices change while not in the market screen, it probably should not cause any trouble. It would make sense that the prices might change while fueling or doing something that passes the time.

Looking forward to test the latest version later today. Keep up the good work.

That's exactly it actually, Want to keep this OXP 'friendly' to other OXPs, that and I want to avoid at all costs any changes which might have a player thinking they will pay one price while quite another gets deducted.

I could have it check for the Screen yes, but what if a change happened 'just as' the screen changed...
This actually happened to me when testing , Furs jumped about 20CR / TC , costing me much more than what was on the screen.

better IMHO to lock in a price set once docked until undocked.

spara wrote:

I get occasional messages from friends (did not know I had any ).

<key>mission_IN_SYSTEM_TRADER_REP</key>
<string>{"Lave":{"reputation":1,"parcelRepCounter":1,"departure":180058019114.25272},"Reorte":{"reputation":0,"parcelRepCounter":0,"departure":180058088877.65167},"Quator":{"reputation":0,"parcelRepCounter":0,"departure":180058125770.58093},"Ra":{"reputation":1,"parcelRepCounter":1,"departure":180058129472.5497},"Relaes":{"reputation":3,"parcelRepCounter":3,"departure":180058171775.23315},"Zasoer":{"reputation":2,"parcelRepCounter":2,"departure":180058188773.99908}}</string>

<key>mission_IN_SYSTEM_TRADER_REP</key>
<string>
{
	"Lave":{
		"reputation":1,
		"parcelRepCounter":1,
		"departure":180058019114.25272
	},
	"Reorte":{
		"reputation":0,
		"parcelRepCounter":0,
		"departure":180058088877.65167
	},
	"Quator":{
		"reputation":0,
		"parcelRepCounter":0,
		"departure":180058125770.58093
	},
	"Ra":{
		"reputation":1,
		"parcelRepCounter":1,
		"departure":180058129472.5497
	},
	"Relaes":{
		"reputation":3,
		"parcelRepCounter":3,
		"departure":180058171775.23315
	},
	"Zasoer":{
		"reputation":2,
		"parcelRepCounter":2,
		"departure":180058188773.99908
	}
}</string>

	var s = "";
	for (var a in this.IN_SYSTEM_TRADER_REP) {
		s += "''" + a + "'' :\n";
		for (var b in a) {
			s +=" ''" + b + "'' : " + a.b + "\n";
		}
	}
	log(s);

''Lave'' :
''0'' : undefined
''1'' : undefined
''2'' : undefined
''3'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined
''Reorte'' :
''0'' : undefined
''1'' : undefined
''2'' : undefined
''3'' : undefined
''4'' : undefined
''5'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined
''Quator'' :
''0'' : undefined
''1'' : undefined
''2'' : undefined
''3'' : undefined
''4'' : undefined
''5'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined
''Ra'' :
''0'' : undefined
''1'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined
''Relaes'' :
''0'' : undefined
''1'' : undefined
''2'' : undefined
''3'' : undefined
''4'' : undefined
''5'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined
''Zasoer'' :
''0'' : undefined
''1'' : undefined
''2'' : undefined
''3'' : undefined
''4'' : undefined
''5'' : undefined
''getOneToken'' : undefined
''substituteEscapeCodes'' : undefined

var s = ""; 
for (var a in this.IN_SYSTEM_TRADER_REP) {
	s += "''" + a + "'' :\n";
	for (var b in this.IN_SYSTEM_TRADER_REP[a]) {
		s +=" ''" + b + "'' : " + this.IN_SYSTEM_TRADER_REP[a][b] + "\n";
	}
}

• OXP hijacked by ocz (at least for version 1.5)
• License changes form "cc by 3.0" to "cc by-nc-sa 4.0"
• Fixed for new commodity markets since oolite ver. 1.81 (pre 1.81 backward compatibility is broken now. Can be restored if demanded in https://bb.oolite.space/viewtopic.php?f=4&t=13702 )
• Deepened reputation system by saving reputation per system and recalculating it when returning in dependence on absence time.
• Bonus increase in parcel reputation now is also bound to the systems.
• Commodity cycling happens for all stations in the system on base of their own market properties. (Same commodity, same time.)
• Fixed ambush pirate fleets attack behaviour. Before they stayed inactive, now they should attack.
• The ambush pirate fleets now appear somewhere in front of the player, at the edge of the scanner range.
• The ambush pirate fleets sizes are now also dependant on the worth of the player's ship. A Transporter shouldn't have to face 16 ships.
• New version log as object. (I know I'm being a kid here, but I wanted to test this new idea.)

ocz wrote:

Anyone any idea why?

	missionVariables.IN_SYSTEM_TRADER_REP = JSON.stringify(this.IN_SYSTEM_TRADER_REP);

    var hold = {};
    for (var a in this.IN_SYSTEM_TRADER_REP) {
        hold[a] = JSON.stringify(this.IN_SYSTEM_TRADER_REP[a]);
    }
    missionVariables.IN_SYSTEM_TRADER_REP_store = JSON.stringify(hold);

    var hold = JSON.parse(missionVariables.IN_SYSTEM_TRADER_REP_store);
    for (var a in hold) {
        this.IN_SYSTEM_TRADER_REP[a] = JSON.parse(hold[a]);
    }