Re: The ultimate crash
Posted: Mon Apr 09, 2012 2:14 pm
Nice find.cim wrote:Found it! SVN patch against current trunk below to fix both my graphics oddities, and the general crashing bugs.
Its of cause an oolite bug, but oxp makers were always warned to clean up their own timers. The Kiota station uses two timers, but only one is stopped when the ship dies. None is stopped when the ship is removed because the player jumps to another system.cim wrote:Thargoid's Wild Ships exposes this bug consistently, because it adds three stations each with two timers to many systems, so you don't need (m)any more timers from other sources to make this code path occur when the Kiota timers from the old system are being cleaned up. I guess most previous OXPs didn't involve that many timers that regularly.
Specially for timers etc we got a '
entityDestroyed
' handler in 1.75 that always fires when an entity is fully deleted. The station should have stopped the running timers there.Anyhow, it is good to hear that when a script fails to stop them, oolite's engine will handle it now without crashing.