Oolite Bulletins

Reval wrote: ↑Sat Dec 03, 2022 2:47 pm

Question: is it possible to access a variable from another OXP's world-script?

If so, what is the syntax for doing this? (could someone perhaps give me an example?)

this.name = "world-script-A";

this.$variable = 42; // the variable you want to access

var variable = worldScripts["world-script-A"].$variable; // read 
worldScripts["world-script-A"].$variable = 123; // write

Redspear wrote: ↑Mon Dec 05, 2022 3:54 pm

Code: Select all

if (System.infoForSystem(galaxyNumber, player.ship.targetSystem).ID < 86) {
        ...first code thing
	}
	else {
		if (System.infoForSystem(galaxyNumber, player.ship.targetSystem).ID < 171) {	
		...second
		}
		else {	
			...third
			}
		}		

Another cry for help...

Only the third of these options is ever firing.

Lave, for example, is ID #7 and so should trigger the first but it triggers the third instead
It works if I swap ID for economy for example (with different numbers of course).

That it triggers at all suggest that my use of '.ID' is ok but why no discrimination upon calling the value (of ID)?

Any advice please?

if (player.ship.targetSystem < 86) {
        ...first code thing
}
else {
	if (player.ship.targetSystem < 171) {	
		...second
	}
	else {	
		...third
	}
}

Alnivel wrote: ↑Mon Dec 05, 2022 4:38 pm

Why are you even trying to get an ID through the system information if you already have one?

Alnivel wrote: ↑Mon Dec 05, 2022 4:38 pm

Is undefined lesser than 86? JS thinks not. Is undefined lesser than 171? Same, so the third branch is being executed.

Alnivel wrote: ↑Mon Dec 05, 2022 5:51 pm

2. Is there a handler that gets called when the cargo in cargo hold is destroyed? Or how else to track it?

Alnivel wrote: ↑Mon Dec 05, 2022 5:51 pm

3. How to find out if a certain OXP is installed if it doesn't have any worldscript? More specifically, I'm want to check retexture OXPs, addition versions. The only way I see is to use Ship.shipDataForKey, but maybe I'm missing something obvious?

const oxzList = oolite.resourcePaths
for (let kowntr = 0; kowntr < oxzList.length; kowntr++)
	if (oxzList [kowntr].indexOf ("oolite.oxp.Griff.Ferdelance.oxz") > -1)
		log (name, oxzList [kowntr] + " is installed")

Massively Locked wrote: ↑Mon Dec 05, 2022 7:32 pm

Alnivel wrote: ↑Mon Dec 05, 2022 5:51 pm

3. How to find out if a certain OXP is installed if it doesn't have any worldscript? More specifically, I'm want to check retexture OXPs, addition versions. The only way I see is to use Ship.shipDataForKey, but maybe I'm missing something obvious?

This is a bit clunky, but it seems to do the job. I'm using Griff's Fer-de-Lance as an example.

Code: Select all

const oxzList = oolite.resourcePaths
for (let kowntr = 0; kowntr < oxzList.length; kowntr++)
	if (oxzList [kowntr].indexOf ("oolite.oxp.Griff.Ferdelance.oxz") > -1)
		log (name, oxzList [kowntr] + " is installed")

Forgot one thing- you might want to add a "break" at the end of the IF statement since oxzList tends to be lengthy.

Massively Locked wrote: ↑Mon Dec 05, 2022 7:36 pm

I've been thinking about adding a wiki page regarding things in "regular" Javascript that are NOT available in Oolite Javascript. I've run across a handful. They're mainly string methods: includes, startsWith, endsWith, replaceAll. Also some techniques for deep copying don't seem to be implemented.

So…

1. Worthwhile or a waste of time & space?
2. If worthwile- do you know of any moar? And please correct me if I'm wrong about those I listed. Also, if someone has already done this somewhere, point me to it.

Redspear wrote: ↑Mon Dec 05, 2022 6:16 pm

Alnivel wrote: ↑Mon Dec 05, 2022 5:51 pm

2. Is there a handler that gets called when the cargo in cargo hold is destroyed? Or how else to track it?

Maybe

// establish cargo count in hold

this.shipTakingDamage = function(amount, whom, type)
{
// test if cargo count has decreased
}

Massively Locked wrote: ↑Mon Dec 05, 2022 7:32 pm

Alnivel wrote: ↑Mon Dec 05, 2022 5:51 pm

3. How to find out if a certain OXP is installed if it doesn't have any worldscript? More specifically, I'm want to check retexture OXPs, addition versions. The only way I see is to use Ship.shipDataForKey, but maybe I'm missing something obvious?

This is a bit clunky, but it seems to do the job. I'm using Griff's Fer-de-Lance as an example.

Code: Select all

const oxzList = oolite.resourcePaths
for (let kowntr = 0; kowntr < oxzList.length; kowntr++)
	if (oxzList [kowntr].indexOf ("oolite.oxp.Griff.Ferdelance.oxz") > -1)
		log (name, oxzList [kowntr] + " is installed")

Forgot one thing- you might want to add a "break" at the end of the IF statement since oxzList tends to be lengthy.

Switeck wrote: ↑Tue Dec 06, 2022 9:09 am

I keep a lot of older versions of OXPs and OXZs.
To keep track of them, I often rename the original files from "Whatever.oxz" to "Whatever v1.2.oxz" (in the case of version 1.2).

Would your logic still work with the renamed files?

Reval wrote: ↑Tue Dec 06, 2022 9:21 am

Definitely worthwhile! - if you have the time. I for one would appreciate it greatly, because I've frequently run across methods from my 'standard javascript manual' that don't work at all in 'Oolite JS'.

Alnivel wrote: ↑Tue Dec 06, 2022 1:59 pm

It seems like it can only be fully relied upon for managed OXPs…