Page 12 of 13

Re: Email System (Release)

Posted: Sun Oct 09, 2016 2:58 am
by phkb
Hey Astrobe, what text did you have for the escape pod email?

Re: Email System (Release)

Posted: Sun Oct 09, 2016 4:41 pm
by Astrobe
phkb wrote:
Hey Astrobe, what text did you have for the escape pod email?
Something quite bland, since I didn't even pass the first stage. If I were to put a bit more effort to it, I would say something like "Your escape pod has been rescued by a fellow trader. Upon close examination, our experts concluded your ship will be allowed to fly again after the necessary repairs are done. As per your contract, we cover for hull and structural damage repair costs, but internal equipment damage is at your charge. We also inform you that cargo loss is *not* covered by your current contract."

The sender would be the insurance company (I think there are a bunch of ads for insurance companies in YAH; anyone?) rather than Galcop.

Re: Email System (Release)

Posted: Thu Oct 13, 2016 10:25 pm
by phkb
Version 1.7.0 has been released. In this version:
  • Fixed issue where docking fine email was being sent after using an escape pod.
  • Added new email for when the player purchases, uses or sells an escape pod.
  • Better handling of sale of items via Ship Configuration.
Download via the manager, or from links in the first post.

Re: Email System (Release)

Posted: Fri Oct 06, 2017 10:33 am
by Norby
Harmless pilots need some text in descriptions.plist:

Code: Select all

11:43:32.428 [script.javaScript.warning.ooliteDefined] ReportJSError (OOJavaScriptEngine.m:203): ----- JavaScript warning (GalCopAdminServices 1.7.3): Unknown expansion key [elite-fed-subject-Harmless] in string.
11:43:32.431 [script.javaScript.warning.ooliteDefined] ReportJSError (OOJavaScriptEngine.m:203): ----- JavaScript warning (GalCopAdminServices 1.7.3): Unknown expansion key [elite-fed-body-Harmless] in string.

Re: Email System (Release)

Posted: Sat Oct 07, 2017 4:30 am
by phkb
Norby wrote:
Harmless pilots need some text in descriptions.plist
The reason there is no next for "Harmless" pilots is because the Elite Federation email is only supposed to be triggered when the player changes rank. I take a snapshot of the player's current rank when they launch, and compare it to their rank when they next dock. If there's a difference, an email is sent. The only way to get an email for a Harmless rating is if the player was "Mostly Harmless" when they launched (or any rank other than "Harmless"), and something happens during flight to reduce their score to be less than 8, so when they dock they are now rated "Harmless".

I'll include a check for a new rank of Harmless for the next release, but I'd be very interested to work out what happened to create this scenario!

Re: Email System (Release)

Posted: Sat Oct 07, 2017 1:12 pm
by Norby
I just loaded a harmless pilot with 1 score, launched then docked back. Here is the log. Since then I tried to reproduce it many times but without success.

Re: Email System (Release)

Posted: Wed Jul 22, 2020 6:03 pm
by phkb
Version 1.7.8 has been released, which fixes a couple of issues noted in other threads.

Re: Email System (Release)

Posted: Sat Dec 05, 2020 10:34 pm
by Cholmondely
Bizarre e-mails.

Buying selected goodies - but the e-mail says otherwise:

When I bought the IronHide Armour, everything went tickety-click e-mail-wise. But, when I bought the upgrade, I got this:
...

This is to confirm that the following items were removed, as per your request:

- IronHide Armour Military Upgrade

You were charged 750.0Cr

...
Ditto with Automatic Target Acquisition addon.

In each case, I did indeed get the goodies in question, but the e-mails were rather confusing.

_______________________________________________________________________________________

Buying lasers:
...

- Beam Laser: Rapid cycle laser, ...

The cost of this item was NaN.NaNCr. (Note: You were refunded the cost of any laser ...

_______________________________________________________________________________________

I presume that in each case the confusion is due to the relevant .oxp (or the Oolite game programme) combined with the use of an AppleMac.

Re: Email System (Release)

Posted: Sun Dec 13, 2020 9:44 pm
by phkb
Cholmondely wrote: Sat Dec 05, 2020 10:34 pm
the confusion is due to the relevant .oxp
This.
Cholmondely wrote: Sat Dec 05, 2020 10:34 pm
combined with the use of an AppleMac
But probably not this.

I'll investigate and report back.

Re: Email System (Release)

Posted: Sun Dec 13, 2020 11:49 pm
by phkb
Cholmondely wrote: Sat Dec 05, 2020 10:34 pm
Ditto with Automatic Target Acquisition addon.
This is Target Autolock Plus, yes?

Re: Email System (Release)

Posted: Mon Dec 14, 2020 12:01 am
by Cholmondely
phkb wrote: Sun Dec 13, 2020 11:49 pm
Cholmondely wrote: Sat Dec 05, 2020 10:34 pm
Ditto with Automatic Target Acquisition addon.
This is Target Autolock Plus, yes?
It is now. But I'm not sure that it was at the time (Gnievmir implied that the other various aiming systems conflicted with his own on the Vimana HUD - I think I stashed the upgrade away). I'm sorry - I've not been keeping a record of how I modify my .oxps.

While I'm on the subject, same issue tonight with

Repairbots: Self-repair system recharge (5-pack)
Passenger Berth for Uncle Orixon (Long Way Round)

Re: Email System (Release)

Posted: Thu Feb 11, 2021 9:02 pm
by phkb
Version 1.7.9 has just been released, which fixes a few of the recently reported bugs.

Re: Email System (Release)

Posted: Thu Feb 11, 2021 10:56 pm
by Cholmondely
phkb wrote: Thu Feb 11, 2021 9:02 pm
Version 1.7.9 has just been released, which fixes a few of the recently reported bugs.
Thanking you, sir!

Re: Email System (Release)

Posted: Thu Jun 09, 2022 4:45 pm
by NorthenderPNE
Hi phkb, this came up in my log today, just thought I'd post it just in case. I was actually just sitting in the station and didn't open any emails during my game play. Oh and I was playing most recent Trunk version. :wink:

Code: Select all

[script.javaScript.exception.jsonBadParse]: ***** JavaScript exception (EmailSystem 1.7.9): SyntaxError: JSON.parse

Re: Email System (Release)

Posted: Thu Jun 09, 2022 11:26 pm
by phkb
NorthenderPNE wrote: Thu Jun 09, 2022 4:45 pm
[script.javaScript.exception.jsonBadParse]: ***** JavaScript exception (EmailSystem 1.7.9): SyntaxError: JSON.parse
:shock: :shock: :shock:

Err... there is only one place in the Email system that JSON.parse is used - during the "startUpComplete" event that happens soon after loading the save game. It's been there since the first version, so it's a complete surprise that somehow you're getting a "Syntax error" on it. The only thing I can imaging is if something in the missionVariable it's trying to read from is causing it to fail (although I'm struggling to come up with a valid explanation on how it could be doing that). Do you still have the save game you loaded that caused the error? Does it happen every time you load that file?