Oolite Bulletins

Old Murgh wrote: ↑Wed Jul 06, 2022 9:12 pm

No added RandomShipName given to my Scrub in space. Just plain Scrub.

phkb wrote: ↑Wed Jul 06, 2022 10:30 pm

Question: When/How are you spawning your "scrub" ships?

Old Murgh wrote: ↑Wed Jul 06, 2022 10:37 pm

It's a script action (checkForShips->addShipsAtPrecisely) in a planetinfo.plist, my chosen role appears next to the buoy as I eject from Lave.

this.startUpComplete = function() {

this.startUp = function() {

phkb wrote: ↑Wed Jul 06, 2022 10:41 pm

OK, change this:

Code: Select all

this.startUpComplete = function() {

To this

Code: Select all

this.startUp = function() {

And see how that goes.

Old Murgh wrote: ↑Wed Jul 06, 2022 10:50 pm

Tried twice, emptied cache. Alas, same result. No effect, no logged error.

worldScripts.scrubNamer._ships = system.addShipsToRoute("scrub", 2, 0.7, "sw");

var ships = worldScripts.scrubNamer._ships; for (var i = 0; i < ships.length; i++) log("testing", ships[i].primaryRole + " -- " + ships[i].displayName + " -- " + ships[i]);

phkb wrote: ↑Wed Jul 06, 2022 11:06 pm

Can you try spawning a ship via the console, after the game is started? eg

Code: Select all

worldScripts.scrubNamer._ships = system.addShipsToRoute("scrub", 2, 0.7, "sw");

That should create a couple of scrub ships on the sun-witchpoint route, and store a reference to them in your script. Then, after a second or two, run this command:

Code: Select all

var ships = worldScripts.scrubNamer._ships; for (var i = 0; i < ships.length; i++) log("testing", ships[i].primaryRole + " -- " + ships[i].displayName + " -- " + ships[i]);

And see what the output in the log shows.

phkb wrote: ↑Wed Jul 06, 2022 11:43 pm

Yep, send me a PM with a link if you like.

montana05 wrote: ↑Wed Jul 06, 2022 11:47 pm

If you want to be independent of random ship names you can simply build your own selection by either use arrays or the descriptions.plist. An example could be found in ADCK Imperial Trader OXP worldscript. Please note that you need to switch random ship names off as well (shipdata.plist),

phkb wrote: ↑Thu Jul 07, 2022 12:02 am

OK, I think I've spotted the problem.
In your planetInfo, your spawning code says this:

Code: Select all

"addShipsAtPrecisely: junk1 1 pwm 18015 66700 22486"

But, I assumed you would be spawning ships with primaryRole of "scrub". The code you have would make the primaryRole of the ship "junk1", not "scrub".

So, change this line of the script file from this:

Code: Select all

rsn.$externalNameEngine(this.name, "scrub", 1);

to this

Code: Select all

rsn.$externalNameEngine(this.name, "junk1", 1);

And see how that goes.

Old Murgh wrote: ↑Thu Jul 07, 2022 12:11 am

Thank you . You javascriptgeniuses can do anything!

Fritz wrote: ↑Tue Oct 27, 2015 10:29 pm

The bounty part should go into the part of the display with the legal status, e.g. "Fugitive, Bounty 98 Cr", but I don't know if this would be possible.