Ouch. Yes, that’s a bug fixed as part of a general robustification of JS code for 1.70. In the mean time, Math.round(Math.random() * 5) should do the trick.
I am still (slowly) working on this. Now up to three ships, and one of them is only seen in a mission.
Sticking with the general pirate role of the Caiman, in order to make it consistent with the rest of the game, what should the relative chances of them appearing in each government type be? I.e. what are the mean number of pirates in each type of system?
I.e. what are the mean number of pirates in each type of system?
Very complex and a lot of randomisation. But in general it uses:
1 pirate in a Corporate state and 1 more for every lower political level and above that 25% extra for a anarchy. Added to this are 1 pirate for every 3 traders. And trader count itself depend with economic state of a system. The higher the economy the more traders. Surprising?
After this exact calculation there are added and subtracted a lot of pirates at random so you only can roughly say: the lower the political lever the more and the higher the economy the more. And this is what we all already saw.
But the exact number of added pirates is written down the the computers logfile on every witchspacejump with version 1.65 and with version 1.69 you can set this logging in the logcontrol.plist.
The higher the economy the more traders. Surprising?
Considering that poor agriculturals are more profitable, yes, unless it's more to either end of the range (such a simple choice of where to trade is one of the serious problems Elite has always had).
Anyway, cheers for that, it's enough to go on to add my Caiman in approximate proportion to the rest of the pirates. Hmm, it's still adding pirates, therefore increasing the overall danger of each system. Might have to have a think about that one...
Considering that poor agriculturals are more profitable.
I mend higher economic levels like industries have more traders as there is more to trade. In scripting strong economies have lower numbers. Could be confusing.
Anyway, cheers for that, it's enough to go on to add my Caiman in approximate proportion to the rest of the pirates.
Best thing is just add a role of "pirate" to the roles list in shipdata. Then the system itself will select your ships in the appropriate amount without influencing the overall count. An other way is doing it as the pirate_cove.OXP does. This OXP counts the numbers of pirates in the system after a witchspacejump. And then adds his own stuff based on this count.
And you can look at the "score_number". This is the hitcount of a player. Don't add tho much extra pirates with a player of harmless or poor rating.
Best thing is just add a role of "pirate" to the roles list in shipdata. Then the system itself will select your ships in the appropriate amount without influencing the overall count. An other way is doing it as the pirate_cove.OXP does. This OXP counts the numbers of pirates in the system after a witchspacejump. And then adds his own stuff based on this count.
And you can look at the "score_number". This is the hitcount of a player. Don't add tho much extra pirates with a player of harmless or poor rating.
I don't want to just add them with role pirate, as explained earlier in this thread (because I want swarms of just them to appear on their own), although they can also appear in the pirate role as ordinary pirates too. I like the sound of the pirate_cover.OXP solution, so I may have a think about that one.
I'm totally against the hitcount approach. The universe should not change in relation to the player's actions, unless it's some justifiable mission-related alteration. A beginner should keep clear of dangerous systems, so perhaps I should bias their generation towards dangerous systems more than normal pirates, leaving the safe ones more or less unchanged.
Hmm, in order to keep the number of pirates the same, I wonder if it's possible to delete some existing ones upon system entry by generating a q-bomb in their areas
One way is to completely repopulate a system by starting with a sendAllShipsAway, which makes all jump-capable ships hyperspace away. Then you can start with zero.
It is not an ideal solution, though, because all the ships leave their wormholes, of course. So the player will ask himself for what reason this system is full of wormholes when he arrives.
@ Ahruman: Should I request a method for emptying a system without a trace of the action?
Just to prove that I'm still very, very occasionally working on ArcElite ships, I've run into a problem, which appears to be related to trying to do a loop in Javascript. The idea is to calculate a number of groups of Caiman (yes, back to that one!) to add to the system, then loop around adding them. Unfortunately if it decides to generate any the game just hangs (it might be going in an eternal loop). I could get around this by just using a few ifs (I don't intend to add more than 3 lots even in the worst Anarchies).
the STATUS_EXITING_WITCHSPACE, which I guess is equivalent to willExitHyperspace i is triggered only once. And cannot be used to loop a script. (I tried to in Thargorn_threat, adding ships is AFTER the ExitFrom Hyperspace is complete, thus I couldnt check for added ships.)
Instead,
use STATUS_IN_FLIGHT for several loops and increment a timervariable to keep track of the times the loop has run.
Or use the Caiman themseves to run a check-for-Caiman(mother) routine in their launch_actions.
the STATUS_EXITING_WITCHSPACE, which I guess is equivalent to willExitHyperspace i is triggered only once. And cannot be used to loop a script.
This type of restriction is not relevant to JavaScript.
Helvellyn, the obvious thing to do is add a Log("Adding " + g + " ships") before the loop to check that g is what you think it is. If this doesn’t expose an obvious problem, e-mail me a test case (I do look at them eventually…).
shouldn't have "gov" as the second argument (it's supposed to be 1), and by this point gov is almost certainly not an integer, causing the same crash I had earlier.
Another bug was that I didn't recalculate pos, so the whole lot got generated at the same place, much to my surprise when I ran into them. The Q-bomb looking impressive, though. It would've been better if I'd still had some fuel to inject out of there after dropping it...
shouldn't have "gov" as the second argument (it's supposed to be 1), and by this point gov is almost certainly not an integer, causing the same crash I had earlier.
Ahh yes. I believe I’ve said it before, but there were a bunch of cases like that which are now fixed in the trunk (passing non-integers should be safe and result in rounding).
