Page 2 of 2

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 8:25 am
by Cholmondely
phkb wrote: Mon Jun 27, 2022 5:33 am
For the Galactic Almanac (v0.7) it's a bit more involved, as there are 33 different calls to "runScreen", and 32 of them need a change. But the fix would be at lines 4655, 4684, 4713, 4740, 4778, 4833, 4886, 4917, 4960, 4991, 5023, 5066, 5098, 5120, 5205, 5283, 8764, 8787, 8814, 8841, 8868, 9215, 9238, 9348, 9381, 9653, 9677, 9791, 9832, 9885, 10050, and 10107.
In each of those instances, between the final "}" and ")" symbols ", this" needs to be inserted, so it looks like this:

Code: Select all

}, this);
That should clear up Galactic Almanac.
I was wondering if this was something to do with the Galactic Almanac changing the title of its interface on the F4 screen from Galactic Almanac Off-line: reality under construction back to Galactic Almanac (when starting / restarting a game with Strangers World up and running).

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 8:48 am
by phkb
Cholmondely wrote: Mon Jun 27, 2022 8:25 am
I was wondering if this was something to do with the Galactic Almanac changing the title of its interface on the F4 screen from Galactic Almanac Off-line: reality under construction back to Galactic Almanac (when starting / restarting a game with Strangers World up and running).
No, nothing to do with that. It’s just a small omission that wouldn’t normally be a problem, but has been brought to the surface by this OXP.

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 5:56 pm
by Alnivel
phkb wrote: Mon Jun 27, 2022 3:29 am
A suggestion: In "interface-reordering-main.js", lines 500-504, try the following instead of the "\u2xxx" nomenclature:

Code: Select all

    const markerBeforeOthers = String.fromCharCode(31) + String.fromCharCode(160) + String.fromCharCode(160); // abb
    const markerOthers       = String.fromCharCode(160) + String.fromCharCode(31) + String.fromCharCode(160); // bab
    const markerAfterOthers  = String.fromCharCode(160) + String.fromCharCode(160) + String.fromCharCode(31); // bba
    const markerDepth = String.fromCharCode(160);
And at line 63, try this:

Code: Select all

let prefix = script.$interfacePrefixes[key] || script.$interfacePrefixes[interfaceDefinition.category] || String.fromCharCode(160) + String.fromCharCode(31) + String.fromCharCode(160); // see "markerOther" in $makeInterfacePrefixes
That should remove all the question marks popping up everywhere.
Thank you. I've tried my best to avoid the visible indent before the category name, but sadly it doesn't seem to work well.
In fact, at first I couldn’t even understand what question marks you were talking about and understood only after Cholmondely's screenshots on wiki and checking in the Windows version - it works great on my main system

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 6:04 pm
by Cholmondely
Alnivel wrote: Mon Jun 27, 2022 5:56 pm
phkb wrote: Mon Jun 27, 2022 3:29 am
A suggestion: In "interface-reordering-main.js", lines 500-504, try the following instead of the "\u2xxx" nomenclature:

Code: Select all

    const markerBeforeOthers = String.fromCharCode(31) + String.fromCharCode(160) + String.fromCharCode(160); // abb
    const markerOthers       = String.fromCharCode(160) + String.fromCharCode(31) + String.fromCharCode(160); // bab
    const markerAfterOthers  = String.fromCharCode(160) + String.fromCharCode(160) + String.fromCharCode(31); // bba
    const markerDepth = String.fromCharCode(160);
And at line 63, try this:

Code: Select all

let prefix = script.$interfacePrefixes[key] || script.$interfacePrefixes[interfaceDefinition.category] || String.fromCharCode(160) + String.fromCharCode(31) + String.fromCharCode(160); // see "markerOther" in $makeInterfacePrefixes
That should remove all the question marks popping up everywhere.
Thank you. I've tried my best to avoid the visible indent before the category name, but sadly it doesn't seem to work well.
In fact, at first I couldn’t even understand what question marks you were talking about and understood only after Cholmondely's screenshots on wiki and checking in the Windows version - it works great on my main system
! I was quite convinced that the question marks were supposed to be there and signified that the items in question had yet to be sorted!

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 6:10 pm
by LittleBear
Made the changes to the Almanac script (thanks for the line numbers). Given it a quick test and it seems to work fine with the Re-Ordering OXP.

I'll put a v0.8 on the manager over the weekend hopefully, but I'm still having a problem uploading a file to the Wiki, as if I try to upload a ,oxz file it says that .oxz is not an accepted format.

Re: Interface Reordering OXP

Posted: Mon Jun 27, 2022 6:43 pm
by Cody
LittleBear wrote: Mon Jun 27, 2022 6:10 pm
...if I try to upload a .oxz file it says that .oxz is not an accepted format.
The Wiki Wizards are still waiting on Winston to fix that.

Re: Interface Reordering OXP

Posted: Fri Jul 01, 2022 4:10 pm
by Alnivel
Version 0.2
  • Fixed question marks at the beginning of category names (I hope)
  • Added reset to no ordering
  • Now changes need to be saved explicitly
Download link: https://www.dropbox.com/s/5c4bbeuw6ntlz ... 2.oxz?dl=1

I would be very grateful if someone could check if I managed to fix the question marks.

Re: Interface Reordering OXP

Posted: Fri Jul 01, 2022 6:40 pm
by Cholmondely
Alnivel wrote: Fri Jul 01, 2022 4:10 pm
Version 0.2
  • Fixed question marks at the beginning of category names (I hope)
  • Added reset to no ordering
  • Now changes need to be saved explicitly
Download link: https://www.dropbox.com/s/5c4bbeuw6ntlz ... 2.oxz?dl=1

I would be very grateful if someone could check if I managed to fix the question marks.
Downloaded - thanks! Will report back, in the fullness of time, at the appropriate juncture!

Re: Interface Reordering OXP

Posted: Fri Jul 01, 2022 6:50 pm
by Cody
A quick and dirty test reveals no question marks. I presume these log messages are purely informational:

Code: Select all

Screen "Reorder interfaces" restarting has been stopped by key 20CONTENT00_00_NO_KEY

Re: Interface Reordering OXP

Posted: Fri Jul 01, 2022 7:14 pm
by Cholmondely
No question marks on my AppleMac - and this seems a tad more intuitive that v.0.1 - well done!

And, thank you!

Re: Interface Reordering OXP

Posted: Fri Jul 01, 2022 7:56 pm
by Alnivel
Cholmondely wrote: Fri Jul 01, 2022 7:14 pm
No question marks on my AppleMac - and this seems a tad more intuitive that v.0.1 - well done!
Cody wrote: Fri Jul 01, 2022 6:50 pm
A quick and dirty test reveals no question marks.
Thanks for checking!
Now I can get on with the Wiki page and publishing in the EM.