Page 2 of 4
Re: Display Current Course OXP
Posted: Wed Nov 25, 2015 6:07 pm
by phkb
Zireael wrote:he image in first post doesn't show up
Really? The image is stored on the wiki - can you get to this wiki link OK:
http://wiki.alioth.net/index.php/Display_Current_Course?
Re: Display Current Course OXP
Posted: Sun Nov 29, 2015 7:34 pm
by ffutures
I hate to say it, but the problem with the displayed route changing has appeared a couple more times. But only on the parcel contract screen, not cargo or passengers. Could there be something different about this page that might cause it?
Re: Display Current Course OXP
Posted: Sun Nov 29, 2015 9:24 pm
by phkb
Hmm, there shouldn't be any difference with parcel contracts. Can you produce the issue consistently? Is there a definite sequence of events that will produce the issue? Do you have any other OXP's installed that may be involved (for instance, I know that Escort Contracts doesn't reset the player's original course after displaying contract details)?
Re: Display Current Course OXP
Posted: Sun Nov 29, 2015 10:18 pm
by Fritz
phkb wrote:for instance, I know that Escort Contracts doesn't reset the player's original course after displaying contract details
The target system is changed if you use the map during contract selection, like it is changed when selecting any other system on the map. The bad thing is that the change is also made permanent when the contract isn't selected. I'll try to fix it.
Re: Display Current Course OXP
Posted: Sun Nov 29, 2015 11:47 pm
by phkb
The fix is pretty simple - store the players current "targetSystem" when opening the page, and restore it when leaving. The built in contracts screens have a good sample for when the save and restore should take place.
Re: Display Current Course OXP
Posted: Mon Nov 30, 2015 12:00 am
by ffutures
Sorry - I should make this clearer, this is only showing on the contract map, it isn't changing the course that's actually set for the ship.
Re: Display Current Course OXP
Posted: Mon Nov 30, 2015 12:07 am
by Fritz
Yes, it's working already.
Re: Display Current Course OXP
Posted: Mon Nov 30, 2015 10:31 pm
by phkb
ffutures, I'm really struggling to reproduce the issue. I'm obviously too close to the code, and I'm doing things the program expects, so I'm not seeing the same results as you. I've tried every menu option combination and screen sequence I can think of, but I can only get the current route plotted. If you're able to document a sequence of events I can really nail this bug. To the wall. With a nail gun.
Re: Display Current Course OXP
Posted: Mon Nov 30, 2015 10:50 pm
by Cody
Just installed this for a poke around - first use gets this:
set route and
contract route.
With no set route, it still displays both routes as in the contract image above.
Re: Display Current Course OXP
Posted: Mon Nov 30, 2015 10:53 pm
by ffutures
Cody wrote:Just installed this for a poke around - first use gets this:
set route and
contract route.
With no set route, it still displays both routes as in the contract image above.
I've occasionally got that result even when a different route has been set. I can't think of any other special circumstances, if it happens again I'll try to see what else seems to be happening.
Re: Display Current Course OXP
Posted: Tue Dec 01, 2015 1:15 am
by phkb
Cody wrote:With no set route, it still displays both routes as in the contract image above.
Cody, when you say "No route set", do you mean you set your destination to your current system, thus completely removing any route information. Or do you use Shift-6 on the galactic chart and switch to "Route Mode - None"? Because if it's the latter I think I can see the problem - I'm assuming that switching to "route mode - none" you still have a route, which I'm plotting with fewest jumps. However, I now can see that assumption is incorrect. "Route mode - none" means just that - no route is selected.
Re: Display Current Course OXP
Posted: Tue Dec 01, 2015 1:42 am
by Cody
phkb wrote:Or do you use Shift-6 on the galactic chart and switch to "Route Mode - None"?
<nods> Yeah... exactly that!
Re: Display Current Course OXP
Posted: Tue Dec 01, 2015 2:58 am
by phkb
Right! Fix on the way! <starts rummaging through code>
Re: Display Current Course OXP
Posted: Tue Dec 01, 2015 3:06 am
by phkb
OK, version 1.4 is now available, which corrects my assumptions about the "Route Mode - None" selection on the Galactic chart.
Re: Display Current Course OXP
Posted: Tue Dec 01, 2015 3:15 am
by Cody
I think that gets it... with parcels, anyway.