Oolite Bulletins

another_commander wrote:

@phkb: I am at work and can't test, but I am almost convinced that the solution here is to adjust the drawing of the V so that its x-axis coordinates (or y-axis if viewing port/starboard) get multiplied by the FOV fraction representation.

Can you please try this? Inside HeadUpDisplay.m, find the drawScannerGrid function. At the top there are these two lines:

Code: Select all

GLfloat w2 = 0.250 * siz.width;
GLfloat h2 = 0.250 * siz.height;

Change them to

Code: Select all

GLfloat w2 = [[UNIVERSE gameView] fov:YES] * siz.width / 2.0;
GLfloat h2 = [[UNIVERSE gameView] fov:YES] * siz.height / 2.0;

Does this fix it for you? If yes, we can push it to trunk.

kanthoney wrote:

I think that would cause the ends of the V not to join up with the oval. We might have to break out the trig on this one.

kanthoney wrote:

Sorted in commit 1989319.

MyOpenGLView* gameView = [UNIVERSE gameView];
GLfloat aspect = [gameView viewSize].width / [gameView viewSize].height;
GLfloat fieldOfView = [gameView fov:YES];
GLfloat const criticalAspect = 4.0 / 3.0;
// make sure that the scanner "V" takes FOV into account
GLfloat w2 = fieldOfView / 2.0 * siz.width;
GLfloat h2 = fieldOfView / 2.0 * siz.height;

if (aspect < criticalAspect)
{
	w2 *= aspect / criticalAspect;
	h2 *= aspect / criticalAspect;
}

another_commander wrote:

We value quick and effective customer service.

Disembodied wrote:

This is pretty amazing, really: something has been queried, misunderstood, carefully explained to the hard of thinking, considered by more agile minds, discussed, and sorted, all within 48 hours.

Smivs wrote:

If only we had any quick and effective customers...