Page 2 of 2

Re: [RELEASE] The Classic Ships

Posted: Sat May 09, 2015 5:12 pm
by csperkins
Hi,

The classicships and variety pack are throwing plist errors for me on the Mac, which look to be due to missing semicolons in dictionary entries. The fix for the classicships Config/shipdata.plist file looks to be:

Code: Select all

286c286
< 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a";};
404c404
< 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a";};
777c777
< 			       classicShipsSpecular = {name = classicAsp_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicAsp_normal-specular.png; extract_channel = "a";};
1024c1024
< 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a";};
1137c1137
< 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a";};
1418c1418
< 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a";};
1524c1524
< 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a";};
1789c1789
< 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a";};
1908c1908
< 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a";};
2026c2026
< 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a";};
2834c2834
< 			       classicShipsSpecular = {name = classicFerdelance_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicFerdelance_normal-specular.png; extract_channel = "a";};
4242c4242
< 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a";};
4334c4334
< 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a";};
4576c4576
< 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a";};
5151c5151
< 			       classicShipsSpecular = {name = classicViper_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicViper_normal-specular.png; extract_channel = "a";};
5280c5280
< 			       classicShipsSpecular = {name = classicInterceptor_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicInterceptor_normal-specular.png; extract_channel = "a";};
5436c5436
< 			       classicShipsSpecular = {name = classicViper_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicViper_normal-specular.png; extract_channel = "a";};
and for the variety pack:

Code: Select all

127c127
< 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicAnaconda_normal-specular.png; extract_channel = "a";};
329c329
< 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a";};
442c442
< 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa_normal-specular.png; extract_channel = "a";};
553c553
< 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicBoa2_normal-specular.png; extract_channel = "a";};
662c662
< 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicCobra3_normal-specular.png; extract_channel = "a";};
980c980
< 			       classicShipsSpecular = {name = classicFerdelance_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicFerdelance_normal-specular.png; extract_channel = "a";};
1569c1569
< 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a";};
1661c1661
< 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a"};
---
> 			       classicShipsSpecular = {name = classicPython_normal-specular.png; extract_channel = "a";};

Re: [RELEASE] The Classic Ships

Posted: Sun May 10, 2015 12:31 pm
by Cody
Smivs will be about it later, I expect. <chortles>

Re: [RELEASE] The Classic Ships

Posted: Sun May 10, 2015 1:10 pm
by Smivs
Cody wrote:
Smivs will be about it later, I expect. <chortles>
Indeed he already is, thanks to the report on the Clippers thread. Looking on the bright side I don't seem to have stuffed-up the Classic Shipyard plist.
This is obviously one of those c&p type errors, and has gone undetected before now as they all work fine on my Linux box and probably Windows machines as well. Macs do seem to be more unforgiving where coding errors are concerned.
Thanks again for the heads-up, and they should all be sorted by tomorrow evening.

Re: [RELEASE] The Classic Ships

Posted: Sun May 10, 2015 1:21 pm
by csperkins
Much appreciated. The Mac does seem overly strict with its plist parser...

Re: [RELEASE] The Classic Ships

Posted: Mon May 11, 2015 3:18 pm
by Smivs
v1.2 now available

Following on from the error report above, and other problems I have found, this OXZ has been updated.

Changelog:-
1) Minor bugfix to the shipdata.plist to avoid parsing errors on Macs.
2) A mis-positioned engine on the Viper Interceptor has also been corrected.

Re: [UPDATE RELEASE] The Classic Ships

Posted: Sun May 17, 2015 10:54 am
by Smivs
I've just spotted another plist error :roll:
The python player seems to have two like_ship references

Code: Select all

	"classic_python-player" =
	{
		like_ship = "oolite_template_python-player";
		exhaust = ("0.0 0.0 -68.5 2.0.0 2.0 8.0");
		like_ship = "oolite_template_python";
                materials = 
<snip>
It seems to be working allright so can wait till the next update to be fixed, but I'm just interested really - does the game read the first one and use that, or automatically work for a player ship because that is one of the two options? Or did I just get lucky? :P

Re: The Classic Ships OXZ

Posted: Sun Aug 28, 2016 3:03 pm
by Smivs
There may be a problem with both the Addition and Replace versions of this expansion relating to a core game mission in G5.
The fix is ready to go, but I cannot upload it at the moment due to the Wiki currently being unable to accept large file uploads. As soon as the Wiki is fixed I'll get the update posted.
If anybody wants to fix this for themselves, open the shipdata.plist and go to the entry for

Code: Select all

"classic_asp-cloaked"
Then delete the following section.

Code: Select all

                
script = "classicShipsScript.js";
script_info = {
                    classicShipsTexture = "classicAsp-A_diffuse.png";
                    classicShipsDiffuse = "classicAsp-A_diffuse.png";
                    classicShipsLighting = "classicAsp_lighting.png";
                    classicShipsNormal = "classicAsp_normal-specular.png";
                    classicShipsSpecular = {name = "classicAsp_normal-specular.png"; extract_channel = "a";};
                    classicShipsDerelict = "classicShipsDerelict.png";
		        };

Re: The Classic Ships OXZ

Posted: Fri Sep 09, 2016 6:10 pm
by Smivs
v1.4 Release.

The updates have now been uploaded to the manager, and correct a couple of the issues mentioned above.
The duplicate "like_ship" entries have been removed. This update was numbered v1.3 but was never released, so I have gone straight to v1.4 which also has the fix for the 'Cloaked Asp' issue.
Any more problems, just let me know.... <ducks>