Page 2 of 2

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 4:28 pm
by spara
laxori666 wrote:
This is a great idea! I have installed the In-System_Market_Restore_1.2.oxp but it doesn't work 100% with commodity markets. In particular I have:

- marketObserver_2.2.2.oxp
- mO-Commodity_Markets_1.1.oxp

What seems to happen is that the base price is stored and doesn't change, but the adjustment for the buy & sell is re-generated when the game is loaded. So this is a humble feature request..
Hmmm. That would require mO-Commodity_Markets to save the commodities' pricefactors on save and load them on startup. Quite an easy tweak, but not nr. 1 on my todo list. I'll implement it some time :) .

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 4:46 pm
by laxori666
spara wrote:
Hmmm. That would require mO-Commodity_Markets to save the commodities' pricefactors on save and load them on startup. Quite an easy tweak, but not nr. 1 on my todo list. I'll implement it some time :) .
Wow that was really easy! I just did it, hah. I had to rename the folder to get the game to load it again but it seems to work... here's a pastebin for the modified file.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 4:52 pm
by Diziet Sma
laxori666 wrote:
I had to rename the folder to get the game to load it again but it seems to work...
That's what shift-starts are for..

Oolite didn't notice your change because it builds a cache of all the scripts, etc. It makes for faster game starts that way. But it means Oolite won't notice any changes you make until it rebuilds the cache. (Oolite automatically rebuilds the cache if it notices an OXP has been added or removed. That's why renaming the folder worked for you.)

A simpler method is to just hold down the Shift key when you start the game, hold it down until you see the spinning Cobra MkIII, and Oolite will rebuild its' cache.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 4:55 pm
by laxori666
Diziet Sma wrote:
laxori666 wrote:
I had to rename the folder to get the game to load it again but it seems to work...
That's what shift-starts are for..

Oolite didn't notice your change because it builds a cache of all the scripts, etc. It makes for faster game starts that way. But it means Oolite won't notice any changes you make until it rebuilds the cache. (Oolite automatically rebuilds the cache if it notices an OXP has been added or removed. That's why renaming the folder worked for you.)

A simpler method is to just hold down the Shift key when you start the game, hold it down until you see the spinning Cobra MkIII, and Oolite will rebuild its' cache.
Oh ok, great. I was wondering if there was an easier way - thanks!

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 4:58 pm
by Diziet Sma
Old hands at editing Oolite OXP files edit their GNUstepDefaults file and set 'always-flush-cache' to YES. This is known as "putting a brick on the shift key". :mrgreen:

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 5:01 pm
by Cody
Diziet Sma wrote:
Old hands at editing Oolite OXP files edit their GNUstepDefaults file and set 'always-flush-cache' to YES. This is known as "putting a brick on the shift key".
Even without the brick, it becomes automatic when one has tinkered - as does checking the log after every flight.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 5:02 pm
by Gimi
Diziet Sma wrote:
Old hands at editing Oolite OXP files edit their GNUstepDefaults file and set 'always-flush-cache' to YES. This is known as "putting a brick on the shift key". :mrgreen:
Or they always hold down the shift key every time they launch Oolite because that is just how you start Oolite. Of course, one day, having forgotten all about it, they start wondering why Oolite is started this way.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 6:06 pm
by spara
laxori666 wrote:
spara wrote:
Hmmm. That would require mO-Commodity_Markets to save the commodities' pricefactors on save and load them on startup. Quite an easy tweak, but not nr. 1 on my todo list. I'll implement it some time :) .
Wow that was really easy! I just did it, hah. I had to rename the folder to get the game to load it again but it seems to work... here's a pastebin for the modified file.
:shock: "Impressive. Most impressive." :D I'll put that into mO-Commodity_Markets and release a new version.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 7:35 pm
by laxori666
spara wrote:
laxori666 wrote:
Wow that was really easy! I just did it, hah. I had to rename the folder to get the game to load it again but it seems to work... here's a pastebin for the modified file.
:shock: "Impressive. Most impressive." :D I'll put that into mO-Commodity_Markets and release a new version.
Coolio! This community is pretty great. This game is a living and breathing entity. The tinkering possibilities are endless =D.

Re: [Release] In-System Market Restore 1.2

Posted: Wed Sep 04, 2013 7:38 pm
by Cody
laxori666 wrote:
The tinkering possibilities are endless.
Here... have a cookie!

Re: [Release] In-System Market Restore 1.2

Posted: Thu Sep 05, 2013 4:45 am
by Diziet Sma
Cody wrote:
laxori666 wrote:
The tinkering possibilities are endless.
Here... have a cookie!
And welcome to what we refer to as "The Darkside" of Oolite! :)

Re: [Release] In-System Market Restore 1.2

Posted: Tue Jun 03, 2014 7:14 pm
by spara
When saving the game at a secondary station on Oolite 1.79, the game saves the state of that station's market. This clashed with this oxp, especially with hermits. I have done what I could and uploaded a new version (1.3) to the expansion manager. It's far from perfect, as same types of stations get their markets shuffled on load, but I still think it's better than totally resetting them.

Re: [Retired] In-System Market Restore

Posted: Sat Aug 30, 2014 10:07 am
by spara
I'm taking this OXP off because so many oxp stations have been upgraded to use the populator in 1.80 and that way the core game handles the saving and restoring of the markets.

Re: [Retired] In-System Market Restore

Posted: Sat Aug 30, 2014 11:11 am
by Diziet Sma
I'd suggest perhaps you consider leaving it available for those that stay with 1.77.1 for whatever reasons..

Re: [Retired] In-System Market Restore

Posted: Sat Aug 30, 2014 11:14 am
by spara
Diziet Sma wrote:
I'd suggest perhaps you consider leaving it available for those that stay with 1.77.1 for whatever reasons..
Yep. It's still available from the wiki. I moved it to the "OXPs with Problems" section in the main list. That's for broken and deprecated OXPs I believe.