Page 2 of 2

Re: [RELEASE] Talkative Space Compass

Posted: Mon Nov 19, 2012 8:58 pm
by cim
I'll have a look at it, then.

Re: [RELEASE] Talkative Space Compass

Posted: Mon Nov 19, 2012 9:11 pm
by Thargoid
My Planetary Compass (Beta) OXP does planet/moon names already with the TSC.

Re: [RELEASE] Talkative Space Compass

Posted: Tue Nov 20, 2012 12:27 am
by superbatprime
getting it to state planet names was painless enough.

Code: Select all

} else if (mode == "COMPASS_MODE_PLANET") {
				player.consoleMessage("Compass: "+system.name);
I'm bugging Wildeblood now about what I need for star types.

Re: [RELEASE] Talkative Space Compass

Posted: Wed Jan 09, 2013 6:41 pm
by Diziet Sma
On 1.77 I'm seeing this a few times in the logs..
07:21:46.626 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Talkative Space Compass 1.0.3): Error: Vector3D.distanceTo: Could not construct vector from parameters (null) -- expected Vector, Entity or array of three numbers.
07:21:46.626 [script.javaScript.exception.ooliteDefined]: AddOns/TalkativeCompass_1.0.3.oxp/Config/script.js, line 68.

Re: [RELEASE] Talkative Space Compass

Posted: Thu Jan 10, 2013 8:30 pm
by spara
Diziet Sma wrote:
On 1.77 I'm seeing this a few times in the logs..
07:21:46.626 [script.javaScript.exception.ooliteDefined]: ***** JavaScript exception (Talkative Space Compass 1.0.3): Error: Vector3D.distanceTo: Could not construct vector from parameters (null) -- expected Vector, Entity or array of three numbers.
07:21:46.626 [script.javaScript.exception.ooliteDefined]: AddOns/TalkativeCompass_1.0.3.oxp/Config/script.js, line 68.
Have you implemented the distance fix into the TSC? If so, then the error is probably from that line.

Re: [RELEASE] Talkative Space Compass

Posted: Fri Jan 11, 2013 7:43 am
by Diziet Sma
Well spotted.. I have:

Code: Select all

//distance to object
if (mode != "COMPASS_MODE_BASIC") {
           dist = (player.ship.position.distanceTo(whom) - whom.collisionRadius)/1000;
           player.consoleMessage(dist.toFixed(3)+" Klicks");	
}
So (whom) is somehow returning null for some entities? (I say some, because it's clearly still working for most entities)

Found this as well in the current log, so yep, seems to be something along those lines.

Code: Select all

12:54:06.541 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (Talkative Space Compass 1.0.3): TypeError: whom is null
12:54:06.541 [script.javaScript.exception.unexpectedType]:       AddOns/TalkativeCompass_1.0.3.oxp/Config/script.js, line 30.

Re: [RELEASE] Talkative Space Compass

Posted: Fri Jan 11, 2013 2:33 pm
by spara
Diziet Sma wrote:
Well spotted.. I have:

Code: Select all

//distance to object
if (mode != "COMPASS_MODE_BASIC") {
           dist = (player.ship.position.distanceTo(whom) - whom.collisionRadius)/1000;
           player.consoleMessage(dist.toFixed(3)+" Klicks");	
}
So (whom) is somehow returning null for some entities? (I say some, because it's clearly still working for most entities)

Found this as well in the current log, so yep, seems to be something along those lines.

Code: Select all

12:54:06.541 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (Talkative Space Compass 1.0.3): TypeError: whom is null
12:54:06.541 [script.javaScript.exception.unexpectedType]:       AddOns/TalkativeCompass_1.0.3.oxp/Config/script.js, line 30.
Try this:

Code: Select all

if (!player.ship.compassTarget) return;
//distance to object
if (mode != "COMPASS_MODE_BASIC") {
           dist = (player.ship.position.distanceTo(whom) - whom.collisionRadius)/1000;
           player.consoleMessage(dist.toFixed(3)+" Klicks");	
}

Re: [RELEASE] Talkative Space Compass

Posted: Fri Jan 11, 2013 2:50 pm
by Diziet Sma
Thanks! Will do. 8)

Re: [RELEASE] Talkative Space Compass

Posted: Fri Jan 11, 2013 5:47 pm
by cim
Updated to 1.0.4 to fix some cases causing errors and to display main planet/sun names if another OXP sets them. Thanks for the reports.

Re: [RELEASE] Talkative Space Compass

Posted: Tue Sep 03, 2013 6:12 pm
by laxori666
Bug report: currently this conflicts with [EliteWiki] Destination ETA. If the ETA indicator is on, then the talkative description is wiped and replaced by the generic one by Destination ETA. I'm not sure which OXP would have to be modified - this one or Destination ETA or both - so I've cross-posted this. Maybe the two can be merged into one OXP? Perhaps would also be more immersive if both upgrades had to be purchased.

Re: [RELEASE] Talkative Space Compass

Posted: Tue Sep 03, 2013 6:54 pm
by spara
laxori666 wrote:
Bug report: currently this conflicts with [EliteWiki] Destination ETA. If the ETA indicator is on, then the talkative description is wiped and replaced by the generic one by Destination ETA. I'm not sure which OXP would have to be modified - this one or Destination ETA or both - so I've cross-posted this. Maybe the two can be merged into one OXP? Perhaps would also be more immersive if both upgrades had to be purchased.
See my Updating TSC oxp, it's quite configurable via variables in the script.

Personally, I tweaked my own hud (Aad-HUD) to show ETA, as the updating function in both Updating TSC and Destination ETA uses suppresses messages when running.

Re: [RELEASE] Talkative Space Compass

Posted: Sat Sep 14, 2013 5:55 pm
by laxori666
spara wrote:
laxori666 wrote:
Bug report: currently this conflicts with [EliteWiki] Destination ETA. If the ETA indicator is on, then the talkative description is wiped and replaced by the generic one by Destination ETA. I'm not sure which OXP would have to be modified - this one or Destination ETA or both - so I've cross-posted this. Maybe the two can be merged into one OXP? Perhaps would also be more immersive if both upgrades had to be purchased.
See my Updating TSC oxp, it's quite configurable via variables in the script.

Personally, I tweaked my own hud (Aad-HUD) to show ETA, as the updating function in both Updating TSC and Destination ETA uses suppresses messages when running.
Ah that's something I'd want to do as well. Could you share how you tweaked your hud to show the ETA? Or share the files and I can figure it out and adapt my HUD to do the same. Would be much appreciated!

Re: [RELEASE] Talkative Space Compass

Posted: Sat Sep 14, 2013 6:28 pm
by spara
laxori666 wrote:
Ah that's something I'd want to do as well. Could you share how you tweaked your hud to show the ETA? Or share the files and I can figure it out and adapt my HUD to do the same. Would be much appreciated!
It's a feature of the latest version of the Aad-HUD. Get it from the wiki.

Re: [RELEASE] Talkative Space Compass

Posted: Sat Sep 14, 2013 6:45 pm
by laxori666
spara wrote:
laxori666 wrote:
Ah that's something I'd want to do as well. Could you share how you tweaked your hud to show the ETA? Or share the files and I can figure it out and adapt my HUD to do the same. Would be much appreciated!
It's a feature of the latest version of the Aad-HUD. Get it from the wiki.
So it is - thanks!