Oolite Bulletins

Frame wrote:

Javascript

loadSound("sound.ogg")
playSound.("sound.ogg")

whereby sounds can overlap... playMusic will stop any current music playing...

Eric Walch wrote:

I like to see an event handler for buying equipment. That would it make possible to immediately initialise equipment after purchase. e.g. this equipment could be a custom "remove specific equipment", like the remove passenger berth or remove missiles.
A script could than divine a remove equipment that only shows as he has the equipment. With the handler the oxp can immediately remove the just bought remove-equipment and the equipment itself. After this the normal code will update the screen were the just removed equipment is probably shown again when the tech level is right.

Code: Select all

It should offer the equipment name as parameter. I added the line in above code. I'm not sure if the argument is defined right. (I just copied it from a few lines below in the code)[/quote]

Done. The handler is called [b]playerBoughtEquipment[/b] and is taking the EQ_* key string as parameter. The handler is used in a script as shown here:
[code]
this.playerBoughtEquipment = function(equipmentKey)
{
	log("playerBoughtEquipment","Player has bought equipment: " + equipmentKey);
}

The above example handler will generate on the stderr:

Code: Select all

2008-09-17 14:19:39.369 oolite.exe[5604] [playerBoughtEquipment]: Player has bought equipment: EQ_WEAPON_MILITARY_LASER
2008-09-17 14:19:40.994 oolite.exe[5604] [playerBoughtEquipment]: Player has bought equipment: EQ_PASSENGER_BERTH
2008-09-17 14:19:44.119 oolite.exe[5604] [playerBoughtEquipment]: Player has bought equipment: EQ_ADVANCED_NAVIGATIONAL_ARRAY

Thanks for pointing out the correct place to look at the code, Eric. It made things really easy.

Eric Walch wrote:

Thanks Another Commander,

I immediately have an other request. Probably just as simple to implement:

Make the destination of a ship available to the script as read/write.

Thargoid wrote:

color=green]And one from me, based on the same discussion with Eric. Would it be possible to expand the AI command sendScriptMessage to accept parameters, so we can use it to pass them to the function in the script?

sendScriptMessage: functionName parameter string

sendScriptMessage: functionName foo bar     baz

Eric Walch wrote:

Done by another_commander – Ahruman[/b]

I like to see an event handler for buying equipment. That would it make possible to immediately initialise equipment after purchase. e.g. this equipment could be a custom "remove specific equipment", like the remove passenger berth or remove missiles.
A script could than divine a remove equipment that only shows as he has the equipment. With the handler the oxp can immediately remove the just bought remove-equipment and the equipment itself. After this the normal code will update the screen were the just removed equipment is probably shown again when the tech level is right.

The right place to put the handler would be in "playerEntity.m" in the function "buySelectedItem":

Code: Select all

	if ([self tryBuyingItem:item])
	{
		if (credits == old_credits)
		{
			[self playCantBuyCommodity];
		}
		else
		{
			[self playBuyCommodity];
			
			// wind the clock forward by 10 minutes plus 10 minutes for every 60 credits spent
			double time_adjust = (old_credits > credits) ? (old_credits - credits) : 0.0;
			ship_clock_adjust += time_adjust + 600.0;
			[self doScriptEvent:@"boughtEquipment" withArgument:[[equipdata arrayAtIndex:index] stringAtIndex:EQUIPMENT_KEY_INDEX]];
		}

It should offer the equipment name as parameter. I added the line in above code. I'm not sure if the argument is defined right. (I just copied it from a few lines below in the code)

Ahruman wrote:

Eric Walch wrote:

Make the destination of a ship available to the script as read/write.

This is problematic because the meaning of destination depends on AI state, and various bits of code write to it at potentially unpredictable times. Its meaning varies; it’s sometimes in absolute coordinates, sometimes relative to the ship. Its usages may change in future, as well.

Commander McLane wrote:

Hey, I had already requested the same thing two posts (and seven weeks) earlier. Why am I not stroken out? :P

Eric Walch wrote:

With the current explode method you already can selectively explode subentities away. That means just a copy of this current method without the explosion itself would be sufficient.

subentity = ship.subEntitties[x]
subentity.setPosition(0,0,15000000)
subentity.explode()

Frame wrote:

A js work around could be

this.removeSubs = function()
{
    let subPresent = false
    for(let i=0;i<this.reverseShip.subEntities.length;i++)
    {
        subPresent = false
        for(let j=0;j<this.ship.subEntities.length;j++)
        {
            let Org = this.ship.subEntities[j].position
            let Copy = this.reverseShip.subEntities[i].position
            if(Copy.x == -Org.x && Copy.y == Org.y && Copy.z == -Org.z) subPresent = true
            // Ships copy is rotated over the y-axis. x and z position are inverted!
        }
        if(!subPresent) this.reverseShip.subEntities[i].explode()
    }
}