Page 10 of 13
Re: Email System (Release)
Posted: Thu Nov 12, 2015 9:05 pm
by phkb
OK, here's a zip of the OXP version:
https://app.box.com/s/jb3rzelnmao1xroh9rb2jhjr8esnhk06. Rather than just increment the size of the column, I've included adaptive code that should scale up if the font size is larger than expected. If this works for you, I'll update the OXZ as well.
Re: Email System (Release)
Posted: Fri Nov 13, 2015 2:35 am
by pagroove
Thank you. Will test later on this day.
Re: Email System (Release)
Posted: Fri Nov 13, 2015 8:47 pm
by pagroove
phkb wrote:pagroove, can I get you to test something for me? Rather than keep publishing micro-updates, can you extract the OXZ to an OXP, and open the "scripts\emailsystem_base.js" file, go to line 664 and change it from this:
Code: Select all
ret += this.$padTextRight("!", 0.4);
to this
Code: Select all
ret += this.$padTextRight("!", 0.6);
Save the file, restart holding shift down (I know you probably know that, but in case someone else is reading), and see if that fixes the issue. If not, increase "0.6" to "0.8" and try again.
Installed the new oxp version.
Went into the file however the above line is not on line 664. I use Textwrangler for Mac btw. Also did a search on it and it could not find that line.
Then went on and deinstalled Font Dangerous and also Xenon UI recourse to return to the original menu's.
Did start Oolite with SHIFT pressed. Made now difference though. It still won't let me enter the menu. Is this a Mac thing?
Re: Email System (Release)
Posted: Fri Nov 13, 2015 11:08 pm
by phkb
It does look like it. I've tried every font I have and can't reproduce the issue. 1.82 and 1.83.
I think I caused confusion by doing something slightly different in the download version to what I asked you to do. I tried to be clever with how the OXP calculates column widths, but it appears my cleverness had no impact if you still have the issue.
OK, if you're still OK with messing with a text editor here's a change to try.
Change lines 666-670 of emailsystem_base.js from this:
Code: Select all
if (email.Read == false) {
ret += this.$padTextRight("!", this._readColumn);
} else {
ret += this.$padTextRight("", this._readColumn);
}
to this
Code: Select all
if (email.Read == false) {
ret += "!";
} else {
ret += " ";
}
Let me know if that makes a difference.
Re: Email System (Release)
Posted: Sat Nov 14, 2015 11:54 am
by pagroove
Hello I did replace those lines. Then-SHIFT- started Oolite but still the same.
It won't let me enter the menu when pressing enter on the Interface screen.
Re: Email System (Release)
Posted: Sat Nov 14, 2015 7:43 pm
by phkb
pagroove, would you be able to PM me your save game? I'm wondering if something might be in there to help me track this bug down.
Re: Email System (Release)
Posted: Sat Nov 14, 2015 7:57 pm
by phkb
Also, can you try this bug fix:
At line 692 in "emailsystem_base.js", can you change the code from this:
Code: Select all
do {
tmp = tmp.substring(0, tmp.length - 2) + ellip;
} while (defaultFont.measureString(tmp) > desiredLength);
to this:
Code: Select all
do {
tmp = tmp.substring(0, tmp.length - 2) + ellip;
if (tmp == ellip) break;
} while (defaultFont.measureString(tmp) > desiredLength);
Re: Email System (Release)
Posted: Tue Dec 01, 2015 4:00 pm
by pagroove
Sorry for the ultra late reply
This was due to OS upgrade here on and me actually trying out Elite Dangerous
But I will try out your 2 latest suggestions of code changes. If they don't work I'il put up a link with a download to my save game.
Beware it will probably be a mess inside the save game file.
Playing with this commander since 2006 and the save game was planted over almost every Oolite version in between till now. I also have a mission hanging from G1 Feudal systems that never clears. So there is obviously more wrong. However as it is not game breaking I do not mind. J
Re: Email System (Release)
Posted: Tue Dec 01, 2015 4:04 pm
by Cody
pagroove wrote:Playing with this commander since 2006 and the save game was planted over almost every Oolite version in between till now.
<chortles> Mine dates back to 2009 (first created on Oolite 1.65, I think), and has been used on every version since.
Re: Email System (Release)
Posted: Tue Dec 01, 2015 4:10 pm
by pagroove
Cody wrote:pagroove wrote:Playing with this commander since 2006 and the save game was planted over almost every Oolite version in between till now.
<chortles> Mine dates back to 2009 (first created on Oolite 1.65, I think), and has been used on every version since.
Yes next year I will be playing Oolite for 10 years
now that I call gameplay value.
Re: Email System (Release)
Posted: Sun Aug 14, 2016 9:57 pm
by Anonymissimus
As soon as I enter the email menu over the entry in the station menu, HUD elements also visible while docked disappear, and I need to use key_hud_toggle after undocking.
See also
https://bb.oolite.space/viewtopic.php?p=250760#p250760
Re: Email System (Release)
Posted: Sun Aug 14, 2016 10:22 pm
by phkb
Thanks for that. I'll check it out.
Edit: Actually, the Email System deliberately turns off the HUD if the "allow_big_gui" setting is false for a HUD in order to get more screen real estate. However, it should turn it back on again whenever you leave. In my tests this appears to work as designed. Which HUD are you using?
Re: Email System (Release)
Posted: Mon Aug 15, 2016 2:02 am
by Anonymissimus
ExtraLarge HUD with 10 MFDs and custom dials
from HUD selector
Is this "deliberately turns off the HUD" a relatively new thing ? (About as new/old as 1.84 ? I may have updated the game and the email system at the same time.)
Re: Email System (Release)
Posted: Mon Aug 15, 2016 2:35 am
by phkb
Anonymissimus wrote:Is this "deliberately turns off the HUD" a relatively new thing ?
No, it's been doing that for a long time.
Re: Email System (Release)
Posted: Mon Aug 15, 2016 10:44 am
by Anonymissimus
Okay, then it cannot be the only reason. I am actually using a customized version of the mentioned HUD and it hasn't been changed since before it started to happen.
I don't recall the exact changes I had made to the HUD, a diff program should be able to show them.