Oolite Bulletins

timer wrote: ↑Tue Sep 12, 2023 12:52 am

hiran wrote: ↑Mon Sep 11, 2023 8:58 pm

Mind the difference:
https://addons.oolite.space/api/1.0/overview
https://addons.oolite.space/api/1.0/overview/

yep - it maybe a problem... url without slash - "give me this file", url with trailing slash is mean "show index file of directory"

What is the default option in the config file? If second - it is problem :(

addons.oolite.space/api/1.0/overview/
Forwarding URL
(Status Code: 301 - Permanent Redirect, Url: http://addons.oolite.space/api/1.0/overview)

timer wrote: ↑Tue Sep 12, 2023 1:57 am

timer wrote: ↑Tue Sep 12, 2023 12:52 am

hiran wrote: ↑Mon Sep 11, 2023 8:58 pm

Mind the difference:
https://addons.oolite.space/api/1.0/overview
https://addons.oolite.space/api/1.0/overview/

yep - it maybe a problem... url without slash - "give me this file", url with trailing slash is mean "show index file of directory"

What is the default option in the config file? If second - it is problem

Found "Page Rules" in CloudFlare, set rule:

Code: Select all

addons.oolite.space/api/1.0/overview/
Forwarding URL
(Status Code: 301 - Permanent Redirect, Url: http://addons.oolite.space/api/1.0/overview)

@hiran, It is must help! (in theory...)

hiran wrote: ↑Tue Sep 12, 2023 6:07 am

The redirect is not necessarily the solution.
I cannot tell how Oolite downloads the data. But my OoliteStarter directly ecpects the result - it does not follow a redirect.

While I can add the redirect feature or simply the new URL we will invalidate all the clients that have been installed so far. Not a good idea.

Please keep the URL as it used to be.

timer wrote: ↑Tue Sep 12, 2023 11:18 am

well... manifest file moved as overview/index.html, now it must working as u expect - opening directory url overview/ - will send content of index file (thanks to GitHub Pages - it support index files).

redirect swaped, now
overview >> 301 redirect >> overview/

timer wrote: ↑Tue Sep 12, 2023 11:18 am

But in general, I consider it incorrect to use the directory address to obtain data instead of the address of a specific file.
It will be difficult to change/fix this.

PS ingame manager correctly processing redirects.

hiran wrote: ↑Tue Sep 12, 2023 12:33 pm

The design of the API may have issues. But it already happened, it has been there for years and there are clients out there that rely on it.
So I totally agree with you: It is difficult to change/fix this. Maybe it is easier to simply accept that flaw. AFAIK it is the only API function we have.

/*static NSString * const kOOOXZDataURL = @"http://addons.oolite.org/api/1.0/overview";*/
static NSString * const kOOOXZDataURL = @"http://addons.oolite.space/api/1.0/overview";

hiran wrote: ↑Tue Sep 12, 2023 12:33 pm

But if we want to change it, we will have to prepare the change better than it was done this time.
See https://bb.oolite.space/viewtopic.php?p=291143#p291143

Cholmondely wrote: ↑Tue Sep 12, 2023 5:25 pm

I am sitting here, reading a conversation between a German and a Russian.

That conversation is in English. I can actually understand each word individually, but have no idea what any complete sentence actually says.

Not a complaint. Not a demand to understand. Or to be included. Just rather amazed!

timer wrote: ↑Tue Sep 12, 2023 2:26 pm

Yep, it is our legacy, but...
in source file:

Code: Select all

/*static NSString * const kOOOXZDataURL = @"http://addons.oolite.org/api/1.0/overview";*/
static NSString * const kOOOXZDataURL = @"http://addons.oolite.space/api/1.0/overview";

so... in origin we have exactly file url - not directory?

This url give us 404 http://addons.oolite.org/api/1.0/overview/.
But http://addons.oolite.org/api/1.0/overview is downloading...
(Of course an entry in the hosts file is required for this checks)

Nginx on my VPS has special condition for processing overview/ without redirect.
Therefore, when the file was sent through my server, it accepted both URLs equally.
I don’t think that we can setup this on GitHub

Now we changed origin manifest url???

-static NSString * const kOOOXZDataURL = @"http://addons.oolite.org/api/1.0/overview";
+/* switching (temporarily maybe) to oolite.space - Nikos 20230507 */
+/*static NSString * const kOOOXZDataURL = @"http://addons.oolite.org/api/1.0/overview";*/
+static NSString * const kOOOXZDataURL = @"http://addons.oolite.space/api/1.0/overview";

timer wrote: ↑Tue Sep 12, 2023 2:26 pm

hiran wrote: ↑Tue Sep 12, 2023 12:33 pm

But if we want to change it, we will have to prepare the change better than it was done this time.
See https://bb.oolite.space/viewtopic.php?p=291143#p291143

IMHO this issue (bad utf symbol) is not related to main manifest url changes.
https://bb.oolite.space/viewtopic.php?p=291177#p291177

timer wrote: ↑Tue Sep 12, 2023 5:44 pm

Cholmondely wrote: ↑Tue Sep 12, 2023 5:25 pm

I am sitting here, reading a conversation between a German and a Russian.

That conversation is in English. I can actually understand each word individually, but have no idea what any complete sentence actually says.

Not a complaint. Not a demand to understand. Or to be included. Just rather amazed!

Oh, I hope @hiran will understand me

hiran wrote: ↑Tue Sep 12, 2023 6:32 pm

Actually you say that the files would be pushed into the github repository. I have not yet noticed any commit. Where would that get visible?

phkb wrote: ↑Thu Sep 21, 2023 11:55 am

Am I correct in assuming the old manifest DB is now no longer in use?

timer wrote: ↑Sat Sep 23, 2023 8:00 am

No!
We now use old site as DB+Manifest Editor!

My server periodically download manifests file from old server and (if it changed) - upload it to GitHub.