Page 9 of 13

Re: Tionisla Reporter

Posted: Thu Nov 24, 2016 10:02 am
by Cody
Haven't looked at this OXP for ages - does the text need sprucing up too? Or has the old text been replaced?

As for licences, I know nothing - but I think Eric still responds to PMs.

Re: Tionisla Reporter

Posted: Thu Nov 24, 2016 10:26 am
by Norby
phkb wrote:
I looked at the manifest.plist file, where the license is said to be "CC-BY-ND 4.0"
It contain SA both in the packaged plist and oxz db (~/GNUstep/Library/Caches/org.aegidian.oolite/Oolite-manifests.plist). I don't know where you saw ND.

Re: Tionisla Reporter

Posted: Thu Nov 24, 2016 10:55 am
by phkb
Norby wrote:
I don't know where you saw ND.
Don't tell me I miss read it?! Gack!
<wanders off muttering something about new glasses>

Re: Tionisla Reporter

Posted: Fri Nov 25, 2016 4:05 am
by RockDoctor
I don't know the location of Eric Walsh, but I'm looking forward to seeing an update on this. I spent quite a bit of time trying to get to Erehwon and I've still got that camera somewhere in a dark corner of the hold. I've a couple of unvisited systems in G1 and some pirates to squash before playing "hunt the Constrictor", and I was debating if I could do something with that camera or kick it out of the airlock.
Hope you get the licensing issue sorted out.

Re: Tionisla Reporter

Posted: Fri Nov 25, 2016 6:26 am
by phkb
I think the license issue is sorted. I want to send Eric a pm shortly (maybe tonight if I get a chance) and talk through the updates I've got and work out a release schedule. Stay tuned.

Re: Tionisla Reporter

Posted: Thu Dec 22, 2016 4:23 am
by phkb
Eric has given his blessing to my updated release, which, for the moment, is available here: Tionisla_Reporter.oxz (v 1.3.1)

Testers are welcome, and should no issues be found I'll arrange for the download manager to be updated.

Re: Tionisla Reporter

Posted: Thu Dec 22, 2016 10:02 pm
by Norby
Looking through the changes in the code I do not see any problems.

Re: Tionisla Reporter

Posted: Thu Dec 22, 2016 10:17 pm
by Cody
You have two different spellings of the planet's name in missiontext.plist - Erehwon is correct, Erewhon is not.

Re: Tionisla Reporter

Posted: Thu Dec 22, 2016 11:03 pm
by phkb
Cody wrote:
You have two different spellings of the planet's name in missiontext.plist
Oops. :oops: In my defense, I believe those mistakes have been in there for a long time!

Anyway, v1.3.2 has the fixes. Tionisla_Reporter.oxz

Re: Tionisla Reporter

Posted: Thu Dec 22, 2016 11:30 pm
by Cody
phkb wrote:
In my defense, I believe those mistakes have been in there for a long time!
<nods> If memory serves (not guaranteed), Eric added the epilogues - wherein lay the typos - after the first version which I'd been testing.
I can't be sure of that though - it is five years ago. Again if memory serves, Eric originally named the planet Achenar (a typo from FEII).

Re: Tionisla Reporter

Posted: Tue Dec 27, 2016 1:35 am
by RockDoctor
Cody wrote:
You have two different spellings of the planet's name in missiontext.plist - Erehwon is correct, Erewhon is not.
Because this satirical Utopia

Re: Tionisla Reporter

Posted: Tue Dec 27, 2016 3:06 pm
by Cody
<nods> Which is kinda why I chose Erehwon.

Re: Tionisla Reporter

Posted: Fri Jun 23, 2017 2:47 am
by phkb
Version 1.3.3 is now available in the download manager.

Re: Tionisla Reporter

Posted: Sun Jul 16, 2017 5:40 pm
by herodotus
Certain level of thread necromancy here, but I think it's worth pointing out for anyone else who comes to this anew like I did that this OXP is still very broken.

Apart from the fact (already pointed out) that it doesn't persist its state for giving the "hint" on how to get to the hidden planet - so you will only get it if you do the jump sequence from A.n. Other Planet -> Biorle -> Usle -> Biorle in one game session without saving/loading in between - there's also a much more fundamental bug that will prevent the planet from ever being populated in interstellar space. The current world script checks

Code: Select all

 if (missionVariables.hasOwnProperty("erehwonDestroyed") && missionVariables.erehwonDestroyed === false)
before setting missionVariables.showErehwon = "YES". The planet is only populated if showErehwon is "YES", obviously. The problem is, the script never initialises that mission variable, so the first part of the condition always fails. If the condition is changed to

Code: Select all

 if (!missionVariables.hasOwnProperty("erehwonDestroyed") || missionVariables.erehwonDestroyed === false)
it seems to work ok. There's another similar condition for presenting the Epilogue that looks like it has the same bug as well. Given that this is a mission that's recommended for beginners it would perhaps be nice to fix it so it at least basically works. Could someone in a position to fix the released version perhaps change the two instances of that condition?

I'd also like to suggest to either
a) change the use of "this.misjumpInfo" to be a mission variable (it looks like it should be a trivial change) so that pilots don't have to do the magic jump sequence all in one session
or
b) (better, IMO) just remove all of the logic around going back and forth between Usle and Biorle and show the mission hint the first time you arrive at Biorle each session so new pilots have a much better chance of actually seeing it!

Cheers,

Re: Tionisla Reporter

Posted: Sun Jul 16, 2017 9:32 pm
by phkb
Version 1.3.4 is now available from the download manager, which should address all of the issues raised. Thanks for reporting, herodotus!