Oolite Bulletins

Vincentz wrote:

Actually my request shouldn't even have been in this thread, but in this one : https://bb.oolite.space/viewtopic.php?f=6&t=3296

Wildeblood wrote:

Vincentz wrote:

Actually my request shouldn't even have been in this thread, but in this one : https://bb.oolite.space/viewtopic.php?f=6&t=3296

No, definitely not. This is the right place. The practical problem you face here is that the new way of defining markets is horrendously complicated, and also fundamentally BBD. Just ignore it completely, do your own calculations in JS, and use the set market price/quantity functions. That way you get something compatible with both 1.80 & 1.81, and never need to look into either commodities.plist or whatever the new thing is called.

Wildeblood wrote:

Just ignore it completely, do your own calculations in JS, and use the set market price/quantity functions.

Vincentz wrote:

and noticed that the HUD Selector can change between .plists, and while it is done manually with equipment, I think a script that changed trade-goods.plist on arrival depending on the economy level would be much simpler.

cim wrote:

Vincentz wrote:

So... (sorry for being so code illiterate) how would a market_script.js look like, and how would it be able to differentiate from different economiy levels?

You'd set a market script on the system (through planetinfo.plist, most likely) with something like this in:

Code: Select all

this.updateLocalCommodityDefinition = function(marketdef, station, system) {
    var systemInfo = System.infoForSystem(galaxyNumber,system); // get the system info
    var economyNumber = systemInfo.economy; // get the economy number for the system
    // you can also get other system properties or variables at this point

    // the precalculated details for the tradegood are in the marketdef object at this point
    // so you can still use the plist to set up a lot of the basic calculations, and only need
    // to adjust the result here

    var price = ...; // calculation of price based on economy
    var quantity = ...; // calculation of price based on economy

    // set the calculated price and quantity back onto the market definition
    marketdef.price = price;
    marketdef.quantity = quantity;
    // and give the market definition back to Oolite to use
    return marketdef;
};

cim wrote:

So what you have to do instead is use JS to change the merged resource definitions later - in this case, you could probably use trade-goods.plist on its own for all the non-Financial economies, and apply a market script to those economies to override the default behaviour - or, perhaps simpler to write, apply the market script everywhere but have it just return the market data unchanged for non-Financial economies.

this.name = "neweconomy.js";
this.author = "YOURNAMEHERE";
this.copyright = "April 2015";
this.description = "World Script for adding new types of economies";
this.version = "1.0";

this.setUpSystem = function()

{   
   if(system.economy = 7)
            {run market_script7.js}
    if(system.economy = 6)
            {run market_script6.js}
etc.
}

Vincentz wrote:

Wouldn't it be easier if the market script (which would have to be a total overhaul of the trade-goods.plist as making a general plist wouldn't fit very well.), was loaded as I originally planned :

Code: Select all

this.name = "neweconomy.js";
this.author = "YOURNAMEHERE";
this.copyright = "April 2015";
this.description = "World Script for adding new types of economies";
this.version = "1.0";

this.setUpSystem = function()

{   
   if(system.economy = 7)
            {run market_script7.js}
    if(system.economy = 6)
            {run market_script6.js}
etc.
}

this.updateLocalCommodityDefinition = function(marketdef, station, system) {
    if (system.economy == 7) {
        return this._updateForMarket7(marketdef,station,system);
    } else if (system.economy == 6) {
        return this._updateForMarket6(marketdef,station,system);
    } else if (system.economy == 5) {
        // and so on
    }
}

this._updateForMarket7 = function(marketdef, station, system) {
    // code for market 7 goes here
    return marketdef;
}

// and the same for the other markets

Layne wrote:

Ok, this one might be easy to solve with the right snippet of code, but I've got no idea how to do it.

I'm working on the Docking Fees OXP I proposed a few days ago, and am very close to finishing a working version. (I was hoping to have it running and posted tonight, in fact, until I ran into this.)

My problem seems to be that when two stations share a role, the formula for calculating the fees either cancels out (if one of them has no fee) or combines and increases (if they both have a fee set up). This only seems to happen for the special stations such as rock hermits or other OXP added stations. An example is this:

Code: Select all

if (station.hasRole("rockhermit")) {fee = 0; dock_mess = "rock";} // rockhermits are free
if (station.hasRole("astromine")) {fee *= 2.2; dock_mess = "astromine";} // penal colonies require a small bribe to enter

if (station.hasRole("astromine")) {fee *= 2.2; dock_mess = "astromine";} // penal colonies require a small bribe to enter
else if (station.hasRole("rockhermit")) {fee = 0; dock_mess = "rock";} // rockhermits are free

phkb wrote:

My suggestion would be to do something like this:

Code: Select all

var dock_mess = "";

Move the roles that are shared to the end of the list. That way, the stations that share that role will be picked up by their specific role first.

Wildeblood wrote:

Note the word "else" and corrected order...

Code: Select all

if (station.hasRole("astromine")) {fee *= 2.2; dock_mess = "astromine";} // penal colonies require a small bribe to enter
else if (station.hasRole("rockhermit")) {fee = 0; dock_mess = "rock";} // rockhermits are free

var fee = (system.techLevel * 0.5 + 0.5);
    // make sure the "dock_mess" value is the same as what you used in the descriptions.plist file
    var dock_mess = system.techLevel;
    if (station.hasRole("constore")) {fee = 0; dock_mess = "store";} // con stores are free for encouraging customers
    if (station.hasRole("random_hits_any_spacebar")) {fee *= 1.5; dock_mess = "spacebar";} // space bars are a little bit more expensive
    if (station.hasRole("rrs_group_spacestation")) {fee = 0; dock_mess = "RRS";} // rescue stations are free
    if (station.hasRole("casinoship")) {fee *= 2; dock_mess = "hoopy";} // casinos are a bit more expensive
    if (station.hasRole("wildShips_kiota")) {fee *= 1.3; dock_mess = "kiota";} // kiota ships are a little bit more expensive
    if (station.hasRole("rrs-mining-outpost")) {fee = 0; dock_mess = "mining";} // mining outposts are free
    if (station.hasRole("smivs_pizza_giftshop")) {fee = 0; dock_mess = "";} // space-pizza charges a fee of its own, so disable the dock message
    if (station.hasRole("free_trade_zone")) {fee = 0; dock_mess = "FTZ";} // free trade zones charge huge fuel prices in lieu of fee
    if (station.hasRole("astromine")) {fee *= 2.2; dock_mess = "astromine";} // penal colonies require a small bribe to enter
    if (station.hasRole("comczgf")) {fee *= 1.5; dock_mess = "ZGF";} // Zero-G-Factories require a small bribe to enter
    if (station.hasRole("comslapu")) {fee *= 1.5; dock_mess = "SLAPU";} // SLAPU collectives require a small bribe to enter
    if (station.hasRole("astrofactory")) {fee *= 1.5; dock_mess = "astrofactory";} // imperial factories require a small bribe to enter
    if (station.hasRole("anarchies_hacker_outpost")) {fee = 0; dock_mess = "hackers";} // if you can find them, hacker outposts are free
    if (station.hasRole("anarchies_salvage_gang")) {fee *= 2; dock_mess = "salvager";} // salvage gangs need a bribe to grease the wheels
    if (station.hasRole("navystat")) {fee = 0; dock_mess = "secom";} // navy stations are free (your tax dollars at work)
    if (station.hasRole("behemoth")) {fee = 0; dock_mess = "behemoth";} // behemoths are free
    if (station.hasRole("liners_liner")) {fee = 0; dock_mess = "liner";} // passenger liners are free
    if (station.hasRole("feudal-hunting-lodge")) {fee = 0; dock_mess = "hunting";} // royal lodges are free
    if (station.hasRole("planetFall_surface")) {fee *= 1.2; dock_mess = "planet";} // planets are slighly more to discourage spacers
    if (station.hasRole("monkbranch")) {fee = 0; dock_mess = "monks";} // black monk monasteries are free
    if (station.hasRole("taxi_station")) {fee *= 0.5; dock_mess = "taxi";} // taxi stations just charge for the parking
    else if (station.hasRole("rockhermit")) {fee = 0; dock_mess = "rock";} // rockhermits are free

Wildeblood wrote:

Use the else, Luke.

I dunno how many conditions you want to check for, or in what priority, but I know that you're continuing to check for them all even after you have a match because you're omitting all the else-s.

P.S. Alternatively, use a switch. But again, get the syntax right or it won't work.

cim wrote:

You'd set a market script on the system (through planetinfo.plist, most likely) with something like this in:

Code: Select all

this.updateLocalCommodityDefinition = function(marketdef, station, system) {
    var systemInfo = System.infoForSystem(galaxyNumber,system); // get the system info
    var economyNumber = systemInfo.economy; // get the economy number for the system
    // you can also get other system properties or variables at this point

    // the precalculated details for the tradegood are in the marketdef object at this point
    // so you can still use the plist to set up a lot of the basic calculations, and only need
    // to adjust the result here

    var price = ...; // calculation of price based on economy
    var quantity = ...; // calculation of price based on economy

    // set the calculated price and quantity back onto the market definition
    marketdef.price = price;
    marketdef.quantity = quantity;
    // and give the market definition back to Oolite to use
    return marketdef;
};